fix(crons): Add trailing slash to monitor environment detail endpoints #103480
Conversation
The project and organization monitor environment detail endpoint URL patterns were missing trailing slashes, causing 404 responses when requests included trailing slashes. This resulted in CORS preflight failures as only the OPTIONS method was reported as allowed. Fixed both URL patterns to accept trailing slashes: - sentry-api-0-project-monitor-environment-details - sentry-api-0-organization-monitor-environment-details
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| ), | ||
| re_path( | ||
| r"^(?P<organization_id_or_slug>[^/]+)/monitors/(?P<monitor_id_or_slug>[^/]+)/environments/(?P<environment>[^/]+)$", | ||
| r"^(?P<organization_id_or_slug>[^/]+)/monitors/(?P<monitor_id_or_slug>[^/]+)/environments/(?P<environment>[^/]+)/$", |
There was a problem hiding this comment.
Bug: URL Pattern: Trailing Slash Breaks Backward Compatibility
The URL pattern now requires a trailing slash instead of making it optional, breaking backward compatibility. Requests without trailing slashes (e.g., /monitors/abc/environments/prod) will no longer match. The pattern should use /?$ instead of /$ to accept both formats.
| ), | ||
| re_path( | ||
| r"^(?P<organization_id_or_slug>[^/]+)/(?P<project_id_or_slug>[^/]+)/monitors/(?P<monitor_id_or_slug>[^/]+)/environments/(?P<environment>[^/]+)$", | ||
| r"^(?P<organization_id_or_slug>[^/]+)/(?P<project_id_or_slug>[^/]+)/monitors/(?P<monitor_id_or_slug>[^/]+)/environments/(?P<environment>[^/]+)/$", |
There was a problem hiding this comment.
Bug: Trailing Slash Breaks URL Routing
The URL pattern now requires a trailing slash instead of making it optional, breaking backward compatibility. Requests without trailing slashes (e.g., /monitors/abc/environments/prod) will no longer match. The pattern should use /?$ instead of /$ to accept both formats.
github-actions
bot
added
the
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
evanpurkhiser
deleted the
evanpurkhiser/fix-crons-add-trailing-slash-to-monitor-environment-detail-endpoints
branch
The project and organization monitor environment detail endpoint URL
patterns were missing trailing slashes, causing 404 responses when
requests included trailing slashes. This resulted in CORS preflight
failures as only the OPTIONS method was reported as allowed.
Fixed both URL patterns to accept trailing slashes: