Skip to content

fix(crons): Add trailing slash to monitor environment detail endpoints #103480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2025
Merged

fix(crons): Add trailing slash to monitor environment detail endpoints #103480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d431b6b
fix(crons): Add trailing slash to monitor environment detail endpoints
evanpurkhiser Nov 17, 2025
bf79059
:hammer_and_wrench: Sync API Urls to TypeScirpt
getsantry[bot] Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/sentry/api/urls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2055,7 +2055,7 @@ def create_group_urls(name_prefix: str) -> list[URLPattern | URLResolver]:
name="sentry-api-0-organization-monitor-details",
),
re_path(
r"^(?P<organization_id_or_slug>[^/]+)/monitors/(?P<monitor_id_or_slug>[^/]+)/environments/(?P<environment>[^/]+)$",
r"^(?P<organization_id_or_slug>[^/]+)/monitors/(?P<monitor_id_or_slug>[^/]+)/environments/(?P<environment>[^/]+)/$",
Copy link
Contributor

@cursor cursor bot Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: URL Pattern: Trailing Slash Breaks Backward Compatibility

The URL pattern now requires a trailing slash instead of making it optional, breaking backward compatibility. Requests without trailing slashes (e.g., /monitors/abc/environments/prod) will no longer match. The pattern should use /?$ instead of /$ to accept both formats.

Fix in Cursor Fix in Web

OrganizationMonitorEnvironmentDetailsEndpoint.as_view(),
name="sentry-api-0-organization-monitor-environment-details",
),
Expand Down Expand Up @@ -3171,7 +3171,7 @@ def create_group_urls(name_prefix: str) -> list[URLPattern | URLResolver]:
name="sentry-api-0-project-monitor-check-in-index",
),
re_path(
r"^(?P<organization_id_or_slug>[^/]+)/(?P<project_id_or_slug>[^/]+)/monitors/(?P<monitor_id_or_slug>[^/]+)/environments/(?P<environment>[^/]+)$",
r"^(?P<organization_id_or_slug>[^/]+)/(?P<project_id_or_slug>[^/]+)/monitors/(?P<monitor_id_or_slug>[^/]+)/environments/(?P<environment>[^/]+)/$",
Copy link
Contributor

@cursor cursor bot Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Trailing Slash Breaks URL Routing

The URL pattern now requires a trailing slash instead of making it optional, breaking backward compatibility. Requests without trailing slashes (e.g., /monitors/abc/environments/prod) will no longer match. The pattern should use /?$ instead of /$ to accept both formats.

Fix in Cursor Fix in Web

ProjectMonitorEnvironmentDetailsEndpoint.as_view(),
name="sentry-api-0-project-monitor-environment-details",
),
Expand Down
4 changes: 2 additions & 2 deletions static/app/utils/api/knownSentryApiUrls.generated.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,7 @@ export type KnownSentryApiUrls =
| '/organizations/$organizationIdOrSlug/monitors/'
| '/organizations/$organizationIdOrSlug/monitors/$monitorIdOrSlug/'
| '/organizations/$organizationIdOrSlug/monitors/$monitorIdOrSlug/checkins/'
| '/organizations/$organizationIdOrSlug/monitors/$monitorIdOrSlug/environments/$environment'
| '/organizations/$organizationIdOrSlug/monitors/$monitorIdOrSlug/environments/$environment/'
| '/organizations/$organizationIdOrSlug/monitors/$monitorIdOrSlug/stats/'
| '/organizations/$organizationIdOrSlug/notifications/actions/'
| '/organizations/$organizationIdOrSlug/notifications/actions/$actionId/'
Expand Down Expand Up @@ -630,7 +630,7 @@ export type KnownSentryApiUrls =
| '/projects/$organizationIdOrSlug/$projectIdOrSlug/members/'
| '/projects/$organizationIdOrSlug/$projectIdOrSlug/monitors/$monitorIdOrSlug/'
| '/projects/$organizationIdOrSlug/$projectIdOrSlug/monitors/$monitorIdOrSlug/checkins/'
| '/projects/$organizationIdOrSlug/$projectIdOrSlug/monitors/$monitorIdOrSlug/environments/$environment'
| '/projects/$organizationIdOrSlug/$projectIdOrSlug/monitors/$monitorIdOrSlug/environments/$environment/'
| '/projects/$organizationIdOrSlug/$projectIdOrSlug/monitors/$monitorIdOrSlug/processing-errors/'
| '/projects/$organizationIdOrSlug/$projectIdOrSlug/monitors/$monitorIdOrSlug/stats/'
| '/projects/$organizationIdOrSlug/$projectIdOrSlug/overview/'
Expand Down
Loading