fix(timeseries): Remove unwanted groupBy parameter
#103482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
static/app/views/insights/common/queries/useSortedTimeSeries.tsx
Outdated
Show resolved
Hide resolved
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
| topEvents, | ||
| groupBy: fields as unknown as any, | ||
| groupBy, | ||
| pageFilters: pageFilters.selection, |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
nsdeschenes
approved these changes
Nov 18, 2025
gggritso
deleted the
georgegritsouk/eng-5914-remove-unneeded-groupby-parameter-from-queries
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an API difference between
/events-stats/and/events-timeseries/. In/events-stats/, the fields parameter includes both the group by, and the Y axis. e.g., fields can be["count(span.duration)", "environment"]and the Y axis would be["count(span.duration)"]which works correctly, and the"environment"field is only used for the grouping.In
/events-timeseries/, there is not "fields", there is only an explicit group by, and an explicit Y axis. In this PR, I'm filtering the Y axis values out of thegroupBy, to prevent us sending an unnecessarygroupByparameter. This doesn't change the response at all, it's just less confusing when looking at the request.