ci: Enable Objectstore #103483
Merged
ci: Enable Objectstore #103483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #103483 +/- ##
===========================================
+ Coverage 80.61% 80.63% +0.01%
===========================================
Files 9280 9280
Lines 396184 396165 -19
Branches 25250 25247 -3
===========================================
+ Hits 319402 319458 +56
+ Misses 76322 76247 -75
Partials 460 460 |
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
jjbayer
reviewed
Nov 21, 2025
| if report.stored_id: | ||
| session = get_attachments_session(self.project.organization_id, self.project.id) | ||
| storage_url = session.object_url(report.stored_id) | ||
| storage_url = maybe_rewrite_objectstore_url(storage_url) |
Member
There was a problem hiding this comment.
Instead of rewriting the the URL here, can we set the objectstore.config option to point to objectstore in tests?
Member
Author
There was a problem hiding this comment.
If you did that you would run into the opposite problem, i.e. sentry wouldn't be able to reach http://objectstore:8888, because sentry is not running in docker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backend-cimode of devservicesrequires_objectstoredecorator if the service is not running