feat(seer): Add separate scanner acknowledgement function with rollout rate #103496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t rate - Add `get_seer_org_acknowledgement_for_scanner` function that uses deterministic rollout via `in_rollout_group` instead of random.random() - Add `seer.scanner_no_consent.rollout_rate` option for controlling scanner rollout - Update `is_issue_eligible_for_seer_automation` to use new function - Add comprehensive unit tests for `get_seer_org_acknowledgement_for_scanner` - Add unit tests for `is_issue_eligible_for_seer_automation` - Fix duplicate return statements in `has_seer_access_with_detail` The new function allows independent control of scanner behavior with a deterministic rollout based on organization ID, separate from the general Seer acknowledgement logic.
github-actions
bot
added
the
Scope: Backend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #103496 +/- ##
===========================================
- Coverage 80.68% 80.68% -0.01%
===========================================
Files 9246 9246
Lines 394964 394968 +4
Branches 25182 25182
===========================================
Hits 318686 318686
- Misses 75847 75851 +4
Partials 431 431 |
kddubey
approved these changes
Nov 17, 2025
src/sentry/seer/seer_setup.py
Outdated
Comment on lines
49
to
54
| if features.has("organizations:gen-ai-consent-flow-removal", organization) and in_rollout_group( | ||
| "seer.scanner_no_consent.rollout_rate", organization.id | ||
| ): | ||
| return True | ||
|
|
||
| return False |
Contributor
There was a problem hiding this comment.
nit: can replace w/ return features.has(...) and ...?
- Simplify get_seer_org_acknowledgement_for_scanner to use a single return statement - Update all test patches from get_seer_org_acknowledgement to get_seer_org_acknowledgement_for_scanner - Fix failing tests in test_post_process.py
shashjar
reviewed
Nov 17, 2025
| ) | ||
|
|
||
| register( | ||
| "seer.scanner_no_consent.rollout_rate", |
Member
There was a problem hiding this comment.
nit but i believe we prefer to use hyphens rather than underscores in options
Member
Author
There was a problem hiding this comment.
really? i see both in the file.
Member
There was a problem hiding this comment.
ah yeah, that's not surprising. kind of a convention that's hard to stick to/enforce. we document it here but i couldn't tell you why 🤷♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
get_seer_org_acknowledgement_for_scannerfunction that provides independent control over scanner behavior with respect to AI consent. We were seeing increased volume from scanner after enabling theno_ai_consentflag, and we'd like to roll this increased volume out separately to the in-UI AI changes.We do this by adding a new option which will allow us to control the rollout rate of scanner separately to the rest of our AI features.