ref(workflow_engine): Further reduce debug log size #103505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…his helps with import cycles in an upcoming commit
…typing to the snapshot with notes about how it's easy to make expensive
github-actions
bot
added
the
Scope: Backend
ceorourke
reviewed
Nov 19, 2025
|
|
||
| associated_detector: DetectorSnapshot | None | ||
| event_id: str | None # ID in NodeStore | ||
| group: Group | None |
Member
There was a problem hiding this comment.
Wouldn't group be quite large? Do you need the entire object or just parts of it?
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Was looking at the data, and we're still logging quite a bit of data; refactoring to use the IDs and added type safety to the snapshot.
This will also add types to the WorkflowEvaluationSnapshot, which is useful when decomposing the
.to_logdata.