chore(issues): Remove old reference to performance category when building alert message #103580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
ceorourke
approved these changes
Nov 20, 2025
malwilley
deleted the
malwilley/chore/remove-old-reference-to-performance-category-when-building-messages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to remove existing references to the performance category on the backend so that the old categories can be removed. The categories aren't meant to be used for anything besides issue search.
This shouldn't be necessary anymore (according to the old comment), so I think it makes sense to remove. The worst that could happen is that some alerts would have the wrong color. (and if that is the case, it's already wrong because there are other issue types besides performance). If the logic is still needed, we could change this to
group.issue_category != error