fix(checkout): Use correct unit for attachments #103647
Merged
+41
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #103647 +/- ##
========================================
Coverage 80.59% 80.59%
========================================
Files 9261 9261
Lines 395372 395372
Branches 25198 25198
========================================
Hits 318643 318643
Misses 76299 76299
Partials 430 430 |
brendanhsentry
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also gets rid of a two redundant functions.
The only difference between
formatReservedWithUnitsandgetEventsWithUnit(the function I got rid of) is that the latter doesn't include a space between "" and "GB" (ie. "1GB" instead of "1 GB"). The difference is so minute that I don't think it's worth keeping the function around.