Skip to content

Conversation

@evanpurkhiser
Copy link
Member

Part of NEW-564: There needs to be some way to mute the entire cron detector

Now that is_muted of a monitor is computed, we need to allow unmuting
environments when they are all muted.

Part of [NEW-564: There needs to be some way to mute the entire cron detector](https://linear.app/getsentry/issue/NEW-564/there-needs-to-be-some-way-to-mute-the-entire-cron-detector)

Now that `is_muted` of a monitor is computed, we need to allow unmuting
environments when they are all muted.
@evanpurkhiser evanpurkhiser requested a review from a team as a code owner November 19, 2025 21:56
@linear
Copy link

linear bot commented Nov 19, 2025

@evanpurkhiser evanpurkhiser requested review from a team and removed request for a team November 19, 2025 21:57
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 19, 2025
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Mute button label misleading when monitor is muted

The label for toggling environment mute state only shows "Unmute Environment" when both the environment is muted AND the monitor is not muted. Now that the button is always enabled (removed disabled: monitor.isMuted), when an environment is muted but the monitor is also muted, the label incorrectly says "Mute Environment" even though clicking the button actually unmutes the environment. The label logic should be based on the isMuted prop alone to accurately reflect the button's behavior.

static/app/views/insights/crons/components/overviewTimeline/overviewRow.tsx#L148-L156

? [
(env: string, isMuted: boolean) => ({
label:
isMuted && !monitor.isMuted
? t('Unmute Environment')
: t('Mute Environment'),
key: 'mute',
onAction: () => onToggleMuteEnvironment(env, !isMuted),
}),

Fix in Cursor Fix in Web


@evanpurkhiser evanpurkhiser merged commit 6adafa9 into master Nov 19, 2025
49 checks passed
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/ref-crons-allow-unmuting-monitor-envs-when-monitor-muted- branch November 19, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants