ref(crons): Fix N+1 query in MonitorSerializer by removing is_muted property #103693
+126
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
…roperty Removes the computed property Monitor.is_muted and replaces it with a standalone is_monitor_muted(monitor) function for better clarity and to fix an N+1 query issue in MonitorSerializer. The serializer now efficiently computes mute status for multiple monitors in a single pass by checking if any environment is unmuted, rather than calling the property on each monitor individually which would trigger separate queries. Changes: - Removed @Property is_muted from Monitor model - Added standalone is_monitor_muted() function that aggregates environment mute status - Updated MonitorSerializer to compute is_muted efficiently using defaultdict pattern - Updated all test files to use is_monitor_muted(monitor) instead of monitor.is_muted
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-crons-fix-n-1-query-in-monitorserializer-by-removing-is-muted-property
branch
from
d5f30bf to
689a7f3
Compare
wedamija
approved these changes
Nov 19, 2025
markstory
approved these changes
Nov 20, 2025
evanpurkhiser
deleted the
evanpurkhiser/ref-crons-fix-n-1-query-in-monitorserializer-by-removing-is-muted-property
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the computed property Monitor.is_muted and replaces it with a standalone
is_monitor_muted(monitor) function for better clarity and to fix an N+1 query
issue in MonitorSerializer.
The serializer now efficiently computes mute status for multiple monitors in a
single pass by checking if any environment is unmuted, rather than calling the
property on each monitor individually which would trigger separate queries.
Changes: