ref(seer): Update add-on enum #103695
Merged
ref(seer): Update add-on enum #103695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
❌ 15 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
dashed
approved these changes
Nov 21, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| ) | ||
| ) && | ||
| (addOnInfo.apiName !== AddOnCategory.SEER || | ||
| !subscription.addOns?.[AddOnCategory.LEGACY_SEER]?.enabled) |
Contributor
There was a problem hiding this comment.
Bug: Usage metrics for Seer hidden when Legacy Seer enabled
The addOnsToShow filter hides the SEER add-on if LEGACY_SEER is enabled. Since the SEER add-on includes unique data categories (like SEER_USER) not present in LEGACY_SEER, users with both add-ons enabled cannot see usage statistics for Seer Users.
Member
Author
There was a problem hiding this comment.
this is correct
| item => item.type.startsWith('reserved_') && !item.type.endsWith('_budget') | ||
| ); | ||
| // TODO(prevent): This needs to be updated once we determine how to display Prevent enablement and PAYG changes on this page | ||
| // TODO(seer): This needs to be updated once we determine how to display Seer enablement and PAYG changes on this page |
Contributor
There was a problem hiding this comment.
Bug: New Seer product excluded from checkout success add-ons list
The products filter explicitly restricts items to reserved_seer_budget, causing the new reserved_seer_users invoice item type to be excluded from the add-ons list. This forces the new Seer product to be rendered as a generic volume item instead of using the updated add-on presentation logic in reservedInvoiceItemTypeToAddOn.
Member
Author
There was a problem hiding this comment.
this is fine for now since we haven't finalized what it's going to look like in the success page (see TODO)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes BIL-1796 and BIL-1757
Depends on https://github.com/getsentry/getsentry/pull/18869