ref(seer): Introduce legacy add-on #103724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| const addOnKey = `addOn${toTitleCase(productInfo.apiName, {allowInnerUpperCase: true})}`; | ||
| const enabled = subscription.addOns?.[productInfo.apiName]?.enabled; | ||
| formModel.setValue(addOnKey, enabled); | ||
| }); |
Contributor
There was a problem hiding this comment.
Bug: Form values for add-ons initialized during render, causing overwrite on re-render
Form values are being set directly in the component render function using formModel.setValue(). This is a side effect that gets executed on every re-render. When the parent component re-renders, this code runs again and resets form values to the current subscription state, overwriting any user changes. For example, if a user enables a checkbox, then the parent re-renders for any reason, the form value gets reset back to the subscription's disabled state. This should use a useEffect hook to initialize form values only when the subscription prop actually changes.
vbro
approved these changes
Nov 20, 2025
brendanhsentry
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pt 1 of BIL-1796
This introduces the new value for the
AddOnCategoryenum, as well as compatibility with the new enum in the _admin Change Plan action and checkout (the two places where you can enable or disable Seer).Follow up PRs will update the backend and the rest of the frontend. This PR is necessary for maintaining compatibility in the limbo state when the backend is updated but the rest of the frontend still needs to be updated.
See https://github.com/getsentry/getsentry/pull/18869 for order of operations.