Skip to content

Conversation

@jennmueng
Copy link
Member

@jennmueng jennmueng commented Nov 20, 2025

Adds a toggle for whether the cursor agent should auto create prs or not. this will be updated in the future to be a setting for all coding-agents.

This toggle ONLY shows if you select the cursor agent as the handoff. Making it a separate card because following up with custom instructions for the cursor agent.
CleanShot 2025-11-20 at 23 54 00@2x

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 20, 2025
@codecov
Copy link

codecov bot commented Nov 20, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
12660 1 12659 10
View the top 1 failed test(s) by shortest run time
ProjectSeer can update the autofix autorun threshold setting
Stack Traces | 1.44s run time
Error: expect(jest.fn()).toHaveBeenCalledTimes(expected)

Expected number of calls: 1
Received number of calls: 2

Ignored nodes: comments, script, style
...
    at toHaveBeenCalledTimes (.../settings/projectSeer/index.spec.tsx:324:33)
    at runWithExpensiveErrorDiagnosticsDisabled (.../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/config.js:47:12)
    at checkCallback (.../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/wait-for.js:124:77)
    at checkRealTimersCallback (.../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/wait-for.js:118:16)
    at Timeout.task [as _onTimeout] (.../sentry/node_modules/.pnpm/jsdom@26.1..../jsdom/browser/Window.js:579:19)
    at listOnTimeout (node:internal/timers:588:17)
    at processTimers (node:internal/timers:523:7)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Comment on lines +142 to +144
getData: () => ({}),
getValue: () => initialValue,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems to stop the request from actually happening --- in tests at least

@jennmueng jennmueng force-pushed the cursor-agent-auto-create-pr-toggle-fe branch from 5354d32 to b14ef12 Compare November 21, 2025 17:11
@jennmueng jennmueng marked this pull request as ready for review November 21, 2025 17:37
@jennmueng jennmueng requested a review from a team as a code owner November 21, 2025 17:37
Copy link
Contributor

@Mihir-Mavalankar Mihir-Mavalankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Though I'm am not the best person to review frontend PR.

jennmueng added a commit that referenced this pull request Nov 24, 2025
We'll default PR creation to false because there's a lot of noise

1. We add a new field `auto_create_pr` to the seer preferences handoff
configuration.
2. We get it from the project preferences when calling a coding agent
3. We pass it into the launch call

Seer PR getsentry/seer#4078
Frontend PR #103730
initialData={{
auto_create_pr: initialValue,
}}
>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Form makes API requests to empty endpoint

The CodingAgentSettings Form is missing an apiEndpoint prop but has saveOnBlur enabled. When the auto_create_pr field is blurred, the form attempts to POST to an empty endpoint. While getData: () => ({}) on line 143 prevents data from being sent, the API request still fires to an empty URL, which interferes with the intended onChange handler on line 146 that actually updates preferences. This explains why "the request stops happening in tests" as noted in the PR discussion.

Fix in Cursor Fix in Web

@jennmueng jennmueng enabled auto-merge (squash) November 25, 2025 18:20
@jennmueng jennmueng merged commit be796c9 into master Nov 25, 2025
48 checks passed
@jennmueng jennmueng deleted the cursor-agent-auto-create-pr-toggle-fe branch November 25, 2025 18:27
Mihir-Mavalankar added a commit that referenced this pull request Dec 1, 2025
…gnals-v0 [feature flagged] (#103932)

## PR Details
+ When the triage-signals-v0 feature flag is enabled, replace the "Where
should Seer stop?" dropdown with two simpler toggles:
+ Auto-open PR: Controls whether Seer automatically opens PRs
(off=code_changes, on=open_pr)
+ Hand off to Cursor: Enables Cursor cloud agent handoff at root cause
+ The toggles are mutually exclusive - enabling one disables the other.
+ Screenshots: 
+ <img width="2151" height="1167" alt="Screenshot 2025-11-24 at 2 08
09 PM"
src="https://github.com/user-attachments/assets/02a960f1-3963-40ff-888e-a64346ac9e13"
/>
+ <img width="2068" height="1118" alt="Screenshot 2025-11-24 at 2 07
52 PM"
src="https://github.com/user-attachments/assets/165d5bc6-cd18-4f43-a88b-f8c36185da49"
/>
+ Will rebase after [this
one](#103730) merged
jerryzhou196 pushed a commit that referenced this pull request Dec 1, 2025
…gnals-v0 [feature flagged] (#103932)

## PR Details
+ When the triage-signals-v0 feature flag is enabled, replace the "Where
should Seer stop?" dropdown with two simpler toggles:
+ Auto-open PR: Controls whether Seer automatically opens PRs
(off=code_changes, on=open_pr)
+ Hand off to Cursor: Enables Cursor cloud agent handoff at root cause
+ The toggles are mutually exclusive - enabling one disables the other.
+ Screenshots: 
+ <img width="2151" height="1167" alt="Screenshot 2025-11-24 at 2 08
09 PM"
src="https://github.com/user-attachments/assets/02a960f1-3963-40ff-888e-a64346ac9e13"
/>
+ <img width="2068" height="1118" alt="Screenshot 2025-11-24 at 2 07
52 PM"
src="https://github.com/user-attachments/assets/165d5bc6-cd18-4f43-a88b-f8c36185da49"
/>
+ Will rebase after [this
one](#103730) merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants