-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat(cursor-agent): add frontend toggle for whether to create pr #103730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
| getData: () => ({}), | ||
| getValue: () => initialValue, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems to stop the request from actually happening --- in tests at least
5354d32 to
b14ef12
Compare
Mihir-Mavalankar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Though I'm am not the best person to review frontend PR.
We'll default PR creation to false because there's a lot of noise 1. We add a new field `auto_create_pr` to the seer preferences handoff configuration. 2. We get it from the project preferences when calling a coding agent 3. We pass it into the launch call Seer PR getsentry/seer#4078 Frontend PR #103730
| initialData={{ | ||
| auto_create_pr: initialValue, | ||
| }} | ||
| > |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Form makes API requests to empty endpoint
The CodingAgentSettings Form is missing an apiEndpoint prop but has saveOnBlur enabled. When the auto_create_pr field is blurred, the form attempts to POST to an empty endpoint. While getData: () => ({}) on line 143 prevents data from being sent, the API request still fires to an empty URL, which interferes with the intended onChange handler on line 146 that actually updates preferences. This explains why "the request stops happening in tests" as noted in the PR discussion.
…gnals-v0 [feature flagged] (#103932) ## PR Details + When the triage-signals-v0 feature flag is enabled, replace the "Where should Seer stop?" dropdown with two simpler toggles: + Auto-open PR: Controls whether Seer automatically opens PRs (off=code_changes, on=open_pr) + Hand off to Cursor: Enables Cursor cloud agent handoff at root cause + The toggles are mutually exclusive - enabling one disables the other. + Screenshots: + <img width="2151" height="1167" alt="Screenshot 2025-11-24 at 2 08 09 PM" src="https://github.com/user-attachments/assets/02a960f1-3963-40ff-888e-a64346ac9e13" /> + <img width="2068" height="1118" alt="Screenshot 2025-11-24 at 2 07 52 PM" src="https://github.com/user-attachments/assets/165d5bc6-cd18-4f43-a88b-f8c36185da49" /> + Will rebase after [this one](#103730) merged
…gnals-v0 [feature flagged] (#103932) ## PR Details + When the triage-signals-v0 feature flag is enabled, replace the "Where should Seer stop?" dropdown with two simpler toggles: + Auto-open PR: Controls whether Seer automatically opens PRs (off=code_changes, on=open_pr) + Hand off to Cursor: Enables Cursor cloud agent handoff at root cause + The toggles are mutually exclusive - enabling one disables the other. + Screenshots: + <img width="2151" height="1167" alt="Screenshot 2025-11-24 at 2 08 09 PM" src="https://github.com/user-attachments/assets/02a960f1-3963-40ff-888e-a64346ac9e13" /> + <img width="2068" height="1118" alt="Screenshot 2025-11-24 at 2 07 52 PM" src="https://github.com/user-attachments/assets/165d5bc6-cd18-4f43-a88b-f8c36185da49" /> + Will rebase after [this one](#103730) merged
Adds a toggle for whether the cursor agent should auto create prs or not. this will be updated in the future to be a setting for all coding-agents.
This toggle ONLY shows if you select the cursor agent as the handoff. Making it a separate card because following up with custom instructions for the cursor agent.
