Skip to content

Conversation

@trevor-e
Copy link
Member

@trevor-e trevor-e commented Nov 20, 2025

This field is still useful to have as a boolean and if needed we can fetch the entire list from the size analysis response. Moving this to a boolean because in some rare cases this list can be larger (70+) than I'd like to store in a JSON field.

In the frontend this is declared as missing_dsym_binaries?: string[]; so it's fine to migrate to a new name.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 20, 2025
@trevor-e trevor-e marked this pull request as ready for review November 20, 2025 17:11
@trevor-e trevor-e requested a review from a team as a code owner November 20, 2025 17:11
@codecov
Copy link

codecov bot commented Nov 20, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
29906 2 29904 245
View the top 2 failed test(s) by shortest run time
tests.sentry.preprod.api.endpoints.test_project_preprod_build_details.ProjectPreprodBuildDetailsEndpointTest::test_get_build_details_with_missing_dsym_binaries
Stack Traces | 3.5s run time
#x1B[1m#x1B[.../api/endpoints/test_project_preprod_build_details.py#x1B[0m:246: in test_get_build_details_with_missing_dsym_binaries
    assert resp_data["app_info"]["apple_app_info"]["missing_dsym_binaries"] == [
#x1B[1m#x1B[31mE   KeyError: 'missing_dsym_binaries'#x1B[0m
tests.sentry.preprod.api.endpoints.test_project_preprod_artifact_update.ProjectPreprodArtifactUpdateEndpointTest::test_update_preprod_artifact_with_apple_app_info
Stack Traces | 3.53s run time
#x1B[1m#x1B[.../api/endpoints/test_project_preprod_artifact_update.py#x1B[0m:180: in test_update_preprod_artifact_with_apple_app_info
    assert stored_apple_info == apple_info
#x1B[1m#x1B[31mE   AssertionError: assert {'code_signat...': False, ...} == {'code_signat...r': True, ...}#x1B[0m
#x1B[1m#x1B[31mE     #x1B[0m
#x1B[1m#x1B[31mE     Omitting 5 identical items, use -vv to show#x1B[0m
#x1B[1m#x1B[31mE     Left contains 1 more item:#x1B[0m
#x1B[1m#x1B[31mE     {'has_missing_dsym_binaries': True}#x1B[0m
#x1B[1m#x1B[31mE     Right contains 1 more item:#x1B[0m
#x1B[1m#x1B[31mE     {'missing_dsym_binaries': ['TestLib.dylib', 'TestFramework.framework']}#x1B[0m
#x1B[1m#x1B[31mE     #x1B[0m
#x1B[1m#x1B[31mE     Full diff:#x1B[0m
#x1B[1m#x1B[31mE       {#x1B[0m
#x1B[1m#x1B[31mE           'code_signature_errors': [#x1B[0m
#x1B[1m#x1B[31mE               'Certificate expired',#x1B[0m
#x1B[1m#x1B[31mE               'Missing entitlements',#x1B[0m
#x1B[1m#x1B[31mE           ],#x1B[0m
#x1B[1m#x1B[31mE           'codesigning_type': 'development',#x1B[0m
#x1B[1m#x1B[31mE     +     'has_missing_dsym_binaries': True,#x1B[0m
#x1B[1m#x1B[31mE           'is_code_signature_valid': False,#x1B[0m
#x1B[1m#x1B[31mE           'is_simulator': True,#x1B[0m
#x1B[1m#x1B[31mE     -     'missing_dsym_binaries': [#x1B[0m
#x1B[1m#x1B[31mE     -         'TestLib.dylib',#x1B[0m
#x1B[1m#x1B[31mE     -         'TestFramework.framework',#x1B[0m
#x1B[1m#x1B[31mE     -     ],#x1B[0m
#x1B[1m#x1B[31mE           'profile_name': 'Test Profile',#x1B[0m
#x1B[1m#x1B[31mE       }#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@trevor-e trevor-e merged commit 9bf09d0 into master Nov 20, 2025
65 of 66 checks passed
@trevor-e trevor-e deleted the telkins/missing-dsym branch November 20, 2025 20:01
trevor-e added a commit that referenced this pull request Nov 20, 2025
…3735)

Frontend portion of #103733, we
already had this field declared in `AppSizeApiResponse`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants