Skip to content

Conversation

@edwardgou-sentry
Copy link
Contributor

  • Removes project allowlist usage in Web Vitals Issue Detection task
    • Task now runs against all eligible projects (settings enabled, seer acknowledged, etc)
    • Task is still protected by a global issue-detection.web-vitals-detection.enabled option
  • Small optimization to groups projects into batches of 1000

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 20, 2025
@edwardgou-sentry
Copy link
Contributor Author

Another improvement could be to add a countdown to each detection task so that we spread out the load, but the pool of eligible projects is already very small. I think we can wait to see what the traffic looks like before further optimization.

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/tasks/web_vitals_issue_detection.py 88.88% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #103740      +/-   ##
===========================================
+ Coverage   79.70%    80.59%   +0.89%     
===========================================
  Files        9273      9274       +1     
  Lines      395877    395934      +57     
  Branches    25220     25220              
===========================================
+ Hits       315537    319118    +3581     
+ Misses      79911     76387    -3524     
  Partials      429       429              

@edwardgou-sentry edwardgou-sentry requested a review from a team November 20, 2025 18:32
@edwardgou-sentry edwardgou-sentry marked this pull request as ready for review November 20, 2025 18:32
@edwardgou-sentry edwardgou-sentry merged commit e979204 into master Nov 20, 2025
68 of 69 checks passed
@edwardgou-sentry edwardgou-sentry deleted the egou/feat/wv-ss-issue-detection-batching branch November 20, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants