Skip to content

Conversation

@DominikB2014
Copy link
Contributor

@DominikB2014 DominikB2014 commented Nov 20, 2025

This PR ensure tooltips have a legend, this way it more closely resembles the current insight page
image

@DominikB2014 DominikB2014 requested a review from a team as a code owner November 20, 2025 19:29
@linear
Copy link

linear bot commented Nov 20, 2025

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 20, 2025
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing legend updates for two LINE chart widgets

The PR aims to add legends to query module charts by populating the name field in widget queries, but two LINE chart widgets (metrics-throughput-line and metrics-duration-line) were missed. Their queries[0].name fields remain empty strings (lines 189 and 220), and their title fields use hardcoded strings instead of the new constants (lines 182 and 212). This means these charts won't display legends in tooltips like the other updated widgets.

static/app/views/dashboards/utils/prebuiltConfigs/queries/querySummary.ts#L181-L238

id: 'metrics-throughput-line',
title: 'Queries Per Minute',
description: '',
displayType: DisplayType.LINE,
thresholds: null,
interval: '1h',
queries: [
{
name: '',
fields: ['epm()'],
aggregates: ['epm()'],
columns: [],
fieldAliases: [],
conditions: '',
orderby: 'epm()',
onDemand: [],
isHidden: false,
linkedDashboards: [],
},
],
widgetType: WidgetType.SPANS,
layout: {
x: 0,
minH: 2,
w: 3,
h: 2,
y: 3,
},
},
{
id: 'metrics-duration-line',
title: 'Average Duration',
description: '',
displayType: DisplayType.LINE,
widgetType: WidgetType.SPANS,
thresholds: null,
interval: '1h',
queries: [
{
name: '',
fields: [`avg(${SpanFields.SPAN_SELF_TIME})`],
aggregates: [`avg(${SpanFields.SPAN_SELF_TIME})`],
columns: [],
fieldAliases: [],
conditions: '',
orderby: `avg(${SpanFields.SPAN_SELF_TIME})`,
onDemand: [],
isHidden: false,
},
],
layout: {
x: 3,
minH: 2,
w: 3,
h: 2,
y: 3,
},
},

Fix in Cursor Fix in Web


@DominikB2014 DominikB2014 merged commit 4ab92b4 into master Nov 21, 2025
50 checks passed
@DominikB2014 DominikB2014 deleted the dominikbuszowiecki/browse-124-add-series-name-tooltips-to-prebuilt-queries-dashboards branch November 21, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants