feat(events): Add logging to debug queries

[wmak]

• Also add error logging to top events
• This adds a log event on events queries

[sentry]

Bug: The rpc_request variable is incorrectly reassigned in a loop, causing the exception handler and set_debug_meta to use the wrong request's debug information.
_{Severity: HIGH | Confidence: High}

🔍 Detailed Analysis

The rpc_request variable is reassigned within the debug logging loop (lines 813-814). After the loop, rpc_request incorrectly holds the last item from the requests list (the other_request when include_other=True). This leads to incorrect debug information being attached to exceptions (lines 820-824) and in set_debug_meta (line 846) when params.debug=True and include_other=True. If the first request causes an error, the debug info will misleadingly show the second request's details, hindering effective debugging.

💡 Suggested Fix

Rename the loop variable rpc_request to avoid reassigning the outer scope's rpc_request. Alternatively, store the rpc_request that caused the error in a separate variable before the try block, or ensure the correct rpc_request is accessible in the except block.

🤖 Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: src/sentry/snuba/rpc_dataset_common.py#L820-L824

Potential issue: The `rpc_request` variable is reassigned within the debug logging loop
(lines 813-814). After the loop, `rpc_request` incorrectly holds the last item from the
`requests` list (the `other_request` when `include_other=True`). This leads to incorrect
debug information being attached to exceptions (lines 820-824) and in `set_debug_meta`
(line 846) when `params.debug=True` and `include_other=True`. If the first request
causes an error, the debug info will misleadingly show the second request's details,
hindering effective debugging.

_{Did we get this right? 👍 / 👎 to inform future reviews.
Reference_id: 2862835}

[cursor]

Bug: Wrong request attached to exception in error handler

The exception handler references rpc_request from the logging loop above, which contains only the last request from the requests list. When multiple requests are sent (e.g., when include_other is True), the wrong request gets attached to the exception. The error could be caused by any request in the list, but only the last one from the logging loop is captured.

 

[cursor]

Bug: Variable shadowing causes wrong request in debug metadata

The logging loop reuses the variable name rpc_request, shadowing the first request that was assigned on line 786. This causes set_debug_meta on line 832 to receive the wrong request (the last one from the loop instead of the first one), mismatching it with rpc_response which is always the first response.

 

[codecov]

Codecov Report

❌ Patch coverage is 5.55556% with 17 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
src/sentry/snuba/rpc_dataset_common.py	5.55%	17 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #103766      +/-   ##
===========================================
- Coverage   80.62%    80.60%   -0.02%     
===========================================
  Files        9278      9278              
  Lines      396075    396191     +116     
  Branches    25247     25247              
===========================================
+ Hits       319348    319369      +21     
- Misses      76267     76362      +95     
  Partials      460       460