From d56729bc108988ef76896f1b9fc809aec48afcf9 Mon Sep 17 00:00:00 2001 From: Shashank Jarmale Date: Thu, 20 Nov 2025 14:07:32 -0800 Subject: [PATCH] Create a constant for the EAP insert items endpoint path ("/tests/entities/eap_items/insert_bytes") --- src/sentry/eventstream/snuba.py | 3 ++- src/sentry/replays/lib/eap/write.py | 3 ++- src/sentry/testutils/cases.py | 15 ++++++++------- src/sentry/utils/eap.py | 1 + 4 files changed, 13 insertions(+), 9 deletions(-) create mode 100644 src/sentry/utils/eap.py diff --git a/src/sentry/eventstream/snuba.py b/src/sentry/eventstream/snuba.py index 2a250a0198f78a..ca6d1955b8906f 100644 --- a/src/sentry/eventstream/snuba.py +++ b/src/sentry/eventstream/snuba.py @@ -18,6 +18,7 @@ from sentry.options.rollout import in_rollout_group from sentry.services.eventstore.models import GroupEvent from sentry.utils import json, metrics, snuba +from sentry.utils.eap import EAP_ITEMS_INSERT_ENDPOINT from sentry.utils.safe import get_path from sentry.utils.sdk import set_current_event_project @@ -498,7 +499,7 @@ def _send_item(self, trace_item: TraceItem) -> None: try: resp = snuba._snuba_pool.urlopen( "POST", - "/tests/entities/eap_items/insert_bytes", + EAP_ITEMS_INSERT_ENDPOINT, fields={"item_0": trace_item.SerializeToString()}, ) diff --git a/src/sentry/replays/lib/eap/write.py b/src/sentry/replays/lib/eap/write.py index 4f26685dcea68a..6135e0b369f2cb 100644 --- a/src/sentry/replays/lib/eap/write.py +++ b/src/sentry/replays/lib/eap/write.py @@ -13,6 +13,7 @@ from sentry.conf.types.kafka_definition import Topic from sentry.replays.lib.eap.snuba_transpiler import TRACE_ITEM_TYPE_MAP, TRACE_ITEM_TYPES from sentry.replays.lib.kafka import EAP_ITEMS_CODEC, eap_producer +from sentry.utils.eap import EAP_ITEMS_INSERT_ENDPOINT from sentry.utils.kafka_config import get_topic_definition Value = bool | bytes | str | int | float | Sequence["Value"] | MutableMapping[str, "Value"] @@ -86,7 +87,7 @@ def write_trace_items_test_suite(trace_items: list[EAPTraceItem]) -> None: `docker logs -f snuba-snuba-1` """ response = requests.post( - settings.SENTRY_SNUBA + "/tests/entities/eap_items/insert_bytes", + settings.SENTRY_SNUBA + EAP_ITEMS_INSERT_ENDPOINT, files={ f"item_{i}": trace_item.SerializeToString() for i, trace_item in enumerate(trace_items) }, diff --git a/src/sentry/testutils/cases.py b/src/sentry/testutils/cases.py index 8744df314d087c..938b741d6a5fce 100644 --- a/src/sentry/testutils/cases.py +++ b/src/sentry/testutils/cases.py @@ -151,6 +151,7 @@ from sentry.users.models.useremail import UserEmail from sentry.utils import json from sentry.utils.auth import SsoSession +from sentry.utils.eap import EAP_ITEMS_INSERT_ENDPOINT from sentry.utils.json import dumps_htmlsafe from sentry.utils.not_set import NOT_SET, NotSet, default_if_not_set from sentry.utils.samples import load_data @@ -1147,7 +1148,7 @@ def store_spans(self, spans, is_eap=False): files[f"item_{i}"] = trace_item.SerializeToString() assert ( requests.post( - settings.SENTRY_SNUBA + "/tests/entities/eap_items/insert_bytes", + settings.SENTRY_SNUBA + EAP_ITEMS_INSERT_ENDPOINT, files=files, ).status_code == 200 @@ -1164,7 +1165,7 @@ def store_spans(self, spans, is_eap=False): def store_ourlogs(self, ourlogs): files = {f"log_{i}": log.SerializeToString() for i, log in enumerate(ourlogs)} response = requests.post( - settings.SENTRY_SNUBA + "/tests/entities/eap_items/insert_bytes", + settings.SENTRY_SNUBA + EAP_ITEMS_INSERT_ENDPOINT, files=files, ) assert response.status_code == 200 @@ -1175,7 +1176,7 @@ def store_trace_metrics(self, trace_metrics): for i, trace_metric in enumerate(trace_metrics) } response = requests.post( - settings.SENTRY_SNUBA + "/tests/entities/eap_items/insert_bytes", + settings.SENTRY_SNUBA + EAP_ITEMS_INSERT_ENDPOINT, files=files, ) assert response.status_code == 200 @@ -1186,7 +1187,7 @@ def store_profile_functions(self, profile_functions): for i, profile_function in enumerate(profile_functions) } response = requests.post( - settings.SENTRY_SNUBA + "/tests/entities/eap_items/insert_bytes", + settings.SENTRY_SNUBA + EAP_ITEMS_INSERT_ENDPOINT, files=files, ) assert response.status_code == 200 @@ -2266,7 +2267,7 @@ def store_spans(self, spans, is_eap=False): files[f"item_{i}"] = trace_item.SerializeToString() assert ( requests.post( - settings.SENTRY_SNUBA + "/tests/entities/eap_items/insert_bytes", + settings.SENTRY_SNUBA + EAP_ITEMS_INSERT_ENDPOINT, files=files, ).status_code == 200 @@ -3897,7 +3898,7 @@ def store_replays_eap(self, replays): files = {f"replay_{i}": replay.SerializeToString() for i, replay in enumerate(replays)} response = requests.post( - settings.SENTRY_SNUBA + "/tests/entities/eap_items/insert_bytes", + settings.SENTRY_SNUBA + EAP_ITEMS_INSERT_ENDPOINT, files=files, ) assert response.status_code == 200 @@ -4044,7 +4045,7 @@ def store_uptime_results(self, uptime_results): f"uptime_{i}": result.SerializeToString() for i, result in enumerate(uptime_results) } response = requests.post( - settings.SENTRY_SNUBA + "/tests/entities/eap_items/insert_bytes", + settings.SENTRY_SNUBA + EAP_ITEMS_INSERT_ENDPOINT, files=files, ) assert response.status_code == 200 diff --git a/src/sentry/utils/eap.py b/src/sentry/utils/eap.py new file mode 100644 index 00000000000000..f5dc8dc2fa9f0f --- /dev/null +++ b/src/sentry/utils/eap.py @@ -0,0 +1 @@ +EAP_ITEMS_INSERT_ENDPOINT = "/tests/entities/eap_items/insert_bytes"