feat(dashboards): allow a single equation on a chart #103783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe we had held over logic from the errors dataset, which requires that a single series is selected before you can use an equation. This limitation does not exist on the spans dataset. This addresses the problem of using equations with a signifcantly different scale than a series.
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| // The spans dataset can have a single equation, so isOnlyFieldOrAggregate | ||
| // is not applicable. The errors dataset requires one series to be | ||
| // selected for equations to work. | ||
| state.dataset !== WidgetType.SPANS; |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Member
Author
There was a problem hiding this comment.
I don't think this suggestion from cursor is correct, isOnlyFieldOrAggregate is used to force there to be at least one series and equation. The spans dataset needs just one or the other.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Talking with @narsaynorath, I believe we had logic in place, to restrict a single equation on a chart, that's only applicable to the errors dataset. This limitation does not exist on the spans dataset.
This addresses the problem of using equations with a significantly different scale of events than the default
count()series.