feat(deletions): Cleanup more groups per project #103851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of deleting 10k groups let's remove 30k per project. There's also some other minor code removal.
github-actions
bot
added
the
Scope: Backend
armenzg
commented
Nov 21, 2025
| debug_output("Running bulk deletes in DELETES_BY_PROJECT") | ||
|
|
||
| # Count total projects for progress tracking | ||
| total_projects = project_deletion_query.count() |
Member
Author
There was a problem hiding this comment.
We don't use any of this.
| ) | ||
|
|
||
| for chunk in q.iterator(chunk_size=100): | ||
| for chunk in q.iterator(chunk_size=100, batch_size=30000): |
Member
Author
There was a problem hiding this comment.
The default is 10k:
sentry/src/sentry/db/deletion.py
Line 94 in 43e4297
Let's try doing 3x and see if things improve.
wedamija
approved these changes
Nov 22, 2025
Member
wedamija
left a comment
wedamija
left a comment
There was a problem hiding this comment.
Doesn't hurt to try, let's just make sure to set it back if it doesn't help
armenzg
added a commit
that referenced
this pull request
Nov 25, 2025
This partially reverts #103851 since it did not make a difference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of deleting 10k groups let's remove 30k per project.
There's also some other minor code removal.