Skip to content

fix(aci): Snake casing for data sources in evidence data #103858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2025
Merged

fix(aci): Snake casing for data sources in evidence data #103858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/sentry/workflow_engine/handlers/detector/stateful.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
from sentry_redis_tools.retrying_cluster import RetryingRedisCluster

from sentry.api.serializers import serialize
from sentry.api.serializers.rest_framework.base import camel_to_snake_case, convert_dict_key_case
from sentry.issues.issue_occurrence import IssueOccurrence
from sentry.issues.status_change_message import StatusChangeMessage
from sentry.models.group import GroupStatus
Expand Down Expand Up @@ -370,7 +371,8 @@ def _build_evidence_data_sources(
},
)
return []
return serialize(data_sources)
# Serializers return camelcased keys, but evidence data should use snakecase
return convert_dict_key_case(serialize(data_sources), camel_to_snake_case)
except Exception:
logger.exception(
"Failed to serialize data source definition when building workflow engine evidence data"
Expand Down
14 changes: 7 additions & 7 deletions tests/sentry/incidents/test_metric_issue_detector_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,22 +54,22 @@ def generate_evidence_data(
"data_sources": [
{
"id": str(self.data_source.id),
"organizationId": str(self.organization.id),
"organization_id": str(self.organization.id),
"type": self.data_source.type,
"sourceId": str(self.query_subscription.id),
"queryObj": {
"source_id": str(self.query_subscription.id),
"query_obj": {
"id": str(self.query_subscription.id),
"status": self.query_subscription.status,
"subscription": self.query_subscription.subscription_id,
"snubaQuery": {
"snuba_query": {
"id": str(self.snuba_query.id),
"dataset": self.snuba_query.dataset,
"query": self.snuba_query.query,
"aggregate": self.snuba_query.aggregate,
"timeWindow": self.snuba_query.time_window,
"time_window": self.snuba_query.time_window,
"environment": self.environment.name,
"eventTypes": ["error"],
"extrapolationMode": "unknown",
"event_types": ["error"],
"extrapolation_mode": "unknown",
},
},
}
Expand Down
Loading