From 30037c690f6f3ed11489e82740e20f0b498509dd Mon Sep 17 00:00:00 2001 From: Shashank Jarmale Date: Fri, 21 Nov 2025 15:31:14 -0800 Subject: [PATCH] Fix attribute name in EAP delete trace items requests - "group_id", not "sentry.group_id" --- src/sentry/eventstream/eap.py | 2 +- tests/sentry/eventstream/test_eap.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/sentry/eventstream/eap.py b/src/sentry/eventstream/eap.py index 30debe457bdbc9..1136546640f675 100644 --- a/src/sentry/eventstream/eap.py +++ b/src/sentry/eventstream/eap.py @@ -59,7 +59,7 @@ def _create_group_id_filter(group_ids: list[int]) -> TraceItemFilter: comparison_filter=ComparisonFilter( key=AttributeKey( type=AttributeKey.TYPE_INT, - name="sentry.group_id", + name="group_id", ), op=ComparisonFilter.OP_IN, value=AttributeValue(val_int_array=IntArray(values=group_ids)), diff --git a/tests/sentry/eventstream/test_eap.py b/tests/sentry/eventstream/test_eap.py index 77024490df1358..dbe83cb5cf09d5 100644 --- a/tests/sentry/eventstream/test_eap.py +++ b/tests/sentry/eventstream/test_eap.py @@ -38,7 +38,7 @@ def test_deletion_with_error_dataset(self, mock_rpc): assert len(request.filters) == 1 assert request.filters[0].item_type == TraceItemType.TRACE_ITEM_TYPE_OCCURRENCE assert request.filters[0].filter.HasField("comparison_filter") - assert request.filters[0].filter.comparison_filter.key.name == "sentry.group_id" + assert request.filters[0].filter.comparison_filter.key.name == "group_id" assert ( list(request.filters[0].filter.comparison_filter.value.val_int_array.values) == self.group_ids @@ -60,7 +60,7 @@ def test_multiple_group_ids(self, mock_rpc): request = mock_rpc.call_args[0][0] group_filter = request.filters[0].filter assert group_filter.HasField("comparison_filter") - assert group_filter.comparison_filter.key.name == "sentry.group_id" + assert group_filter.comparison_filter.key.name == "group_id" assert list(group_filter.comparison_filter.value.val_int_array.values) == many_group_ids @patch("sentry.eventstream.eap.snuba_rpc.delete_trace_items_rpc")