From 7d09f06b3a7970dd112c12f08cb856823ff50448 Mon Sep 17 00:00:00 2001 From: Tony Xiao Date: Mon, 24 Nov 2025 11:41:18 -0500 Subject: [PATCH] fix(tracemetrics): Add metric button not working The default metric uses empty strings and relies on the component filling it later. So permit it in the validation. --- static/app/views/explore/metrics/metricQuery.tsx | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/static/app/views/explore/metrics/metricQuery.tsx b/static/app/views/explore/metrics/metricQuery.tsx index 5c6ca8db7ce26e..5f440737b686fe 100644 --- a/static/app/views/explore/metrics/metricQuery.tsx +++ b/static/app/views/explore/metrics/metricQuery.tsx @@ -24,7 +24,12 @@ function isTraceMetric(value: unknown): value is TraceMetric { return false; } - return 'name' in value && !!value.name && 'type' in value && !!value.type; + return ( + 'name' in value && + typeof value.name === 'string' && + 'type' in value && + typeof value.type === 'string' + ); } export interface BaseMetricQuery {