feat(explore-attr-breakdowns): Persisting search #103918
Merged
+236
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Abdkhan14
commented
Nov 24, 2025
Abdkhan14
commented
- I will be consolidating code between the two views in following PRs
github-actions
bot
added
the
Scope: Frontend
Base automatically changed from
abdk/attr-breakdowns-url-persistence
to
master
November 25, 2025 16:59
- I will be consolidating shared components between the 2 views (comparison view, total distribution view and loading view) in following PRs <img width="1132" height="736" alt="Screenshot 2025-11-24 at 9 08 59 PM" src="https://github.com/user-attachments/assets/aaa805cb-26fa-4e40-b006-c7a50f889de6" /> --------- Co-authored-by: Abdullah Khan <abdullahkhan@PG9Y57YDXQ.local>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
|
||
| if (isAttributeBreakdownsError || isCohortCountError) { | ||
| return <LoadingError message={t('Failed to load attribute breakdowns')} />; | ||
| } |
Contributor
There was a problem hiding this comment.
Bug: Error rendering changed from wrapped to unwrapped
Error handling logic changed: LoadingError now returns early without Panel and Flex wrappers that were present in the original implementation. Previously, errors displayed within the same container layout as normal content. This could cause visual inconsistency in how errors appear compared to the rest of the component layout and prior behavior.
Additional Locations (1)
Contributor
Author
There was a problem hiding this comment.
Will be working on the error state next
edwardgou-sentry
approved these changes
Nov 25, 2025
Comment on lines
+153
to
+155
| onChange={q => { | ||
| setSearchQuery(q); | ||
| }} |
Contributor
There was a problem hiding this comment.
Suggested change
| onChange={q => { | |
| setSearchQuery(q); | |
| }} | |
| onChange={setSearchQuery} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.