fix(aci): correctly query open periods within date range

[ameliahsu]

we were only returning open periods that started during/after query_start, which does not include open periods that started before query_start but were still ongoing during the query range

[codecov]

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
23158	1	23157	178

View the top 1 failed test(s) by shortest run time

tests.sentry.workflow_engine.endpoints.test_organization_open_periods.OrganizationOpenPeriodsTest::test_open_periods_limit

Stack Traces | 3.02s run time

#x1B[1m#x1B[.../workflow_engine/endpoints/test_organization_open_periods.py#x1B[0m:285: in test_open_periods_limit
    assert resp["lastChecked"].replace(second=0, microsecond=0) == second_resolved_time.replace(
#x1B[1m#x1B[31mE   KeyError: 'lastChecked'#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

[cathteng]

I feel like it's a bit easier to grok if you phrase it as

"Either the end time is between the [start, end] or the start time is between [start, end]"

Suggested change

	group_open_periods = (
	GroupOpenPeriod.objects.filter(
	group=group,
	date_started__lte=query_end,
	)
	.filter(Q(date_ended__gte=query_start) | Q(date_ended__isnull=True))
	.order_by("-date_started")
	)
	group_open_periods = GroupOpenPeriod.objects.filter(
	Q(date_ended__lte=query_end) & Q(date_ended__gte=query_start)
	| (Q(date_started__lte=query_end) & Q(date_started__gte=query_start)),
	group=group,
	).order_by("-date_started")

[ameliahsu]

unfortunately this doesn't account for open periods that extend beyond the query period in both directions 🥲

ex. if i have an open period from day 0 to day 7 and i query for day 2 to 3, then the open period wouldn't be returned

i'll update the comment to make it easier to grok the current logic

[cathteng]

sadge

perhaps add this specific case as another condition to the query then?

[cathteng]

alternatively, explain what cases the current query covers, I think that's what got me