Skip to content

chore(aci): log missing WorkflowActionGroupStatus after bulk create #103928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 24, 2025
Merged

chore(aci): log missing WorkflowActionGroupStatus after bulk create #103928

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bcd81fb
log missing WorkflowActionGroupStatus after bulk create
cathteng Nov 24, 2025
e558c98
use status.id to check if it was actually created
cathteng Nov 24, 2025
2515611
make the log nicer
cathteng Nov 24, 2025
455d764
rename var for typing
cathteng Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/sentry/workflow_engine/processors/action.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,11 +119,19 @@ def update_workflow_action_group_statuses(
id__in=statuses_to_update, date_updated__lt=now
).update(date_updated=now)

WorkflowActionGroupStatus.objects.bulk_create(
all_statuses = WorkflowActionGroupStatus.objects.bulk_create(
missing_statuses,
batch_size=1000,
ignore_conflicts=True,
)
missing_status_pairs = [
(status.workflow_id, status.action_id) for status in all_statuses if status.id is None
]
if missing_status_pairs:
logger.warning(
"Failed to create WorkflowActionGroupStatus objects",
extra={"missing_status_pairs": missing_status_pairs},
)


def get_unique_active_actions(
Expand Down
Loading