feat(logs): Without chart data when table is empty #103930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This withholds the chart data when the table is empty. It happens when the user is searching for a log closer to the start of the query period. The chart query successfully finds the results, but because the table query is using the flex time strategy, it may not have scanned that point in time just yet. It will if the user clicks on `Continue Scanning` a few times but until the table finds the log, we have a weird state that is difficult to explain. To address this, we opted to withhold the chart data and make it look like the chart is still loading when the user clicks on `Continue Scanning`. And only when the table finds some results, will the chart finally render.
github-actions
bot
added
the
Scope: Frontend
Zylphrex
commented
Nov 24, 2025
| timeseriesResult: { | ||
| ...timeseriesResult, | ||
| isPending: timeseriesResult.isPending || tableIsPending, | ||
| } as ChartInfo['timeseriesResult'], |
Member
Author
There was a problem hiding this comment.
Getting a weird type error here about not able to assign boolean to false here for some reason.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| // This is to avoid a state where there is data in the chart but not in | ||
| // the table which is very weird. By withholding the chart data, we create | ||
| // the illusion the 2 are being queries in sync. | ||
| const withholdData = tableIsEmpty || tableIsPending; |
Contributor
There was a problem hiding this comment.
Bug: Chart data not withheld during Continue Scanning
When the user clicks Continue Scanning with existing table data, the chart data isn't withheld as intended. The isPending property from useLogsPageDataQueryResult only includes isFetchingNextPage when data is empty. With existing data, isPending remains false during pagination, so withholdData becomes false, showing chart data while the table loads more results. This contradicts the PR's goal to withhold chart data during Continue Scanning operations. The code needs to also check isFetchingNextPage in the withholdData calculation.
k-fish
approved these changes
Nov 25, 2025
Zylphrex
deleted the
txiao/feat/withhold-chart-data-when-table-is-empty
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This withholds the chart data when the table is empty. It happens when the user is searching for a log closer to the start of the query period. The chart query successfully finds the results, but because the table query is using the flex time strategy, it may not have scanned that point in time just yet. It will if the user clicks on
Continue Scanninga few times but until the table finds the log, we have a weird state that is difficult to explain. To address this, we opted to withhold the chart data and make it look like the chart is still loading when the user clicks onContinue Scanning. And only when the table finds some results, will the chart finally render.