-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
ref(explorer): rm old issue rpc #103935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(explorer): rm old issue rpc #103935
Conversation
roaga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably needs to be removed from seer_rpc.py too, and any tests
❌ 13 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Frontend references orphaned RPC method
The get_issue_details RPC method is removed from the backend registry, but the frontend still references it in static/app/views/seerExplorer/utils.tsx (lines 65 and 417). When Seer attempts to call this method or the frontend tries to handle responses from it, the RPC endpoint will return "Unknown method" errors. The frontend code needs updating to use get_issue_and_event_details or remove the get_issue_details cases entirely.
src/sentry/seer/endpoints/seer_rpc.py#L1032-L1033
sentry/src/sentry/seer/endpoints/seer_rpc.py
Lines 1032 to 1033 in f9af9b9
| "get_trace_waterfall": rpc_get_trace_waterfall, | |
| "get_issue_and_event_details": get_issue_and_event_details, |
frontend uses seer tool call name, which is still called the same thing |
No description provided.