-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
add copy as markdown to user feedback #103954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9bd675c to
0725ea7
Compare
0725ea7 to
9635c0b
Compare
| const markdown = [ | ||
| '# User Feedback', | ||
| '', | ||
| `**Summary:** ${summary}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what if we just skipped this line if there's no summary provided?
If an org turns off their AI stuff, or is on-prem and doesn't have Seer at all then it'll be really annoying to see **Summary:** No summary provided every time
| ...(sourceLines.length | ||
| ? [ | ||
| '', | ||
| '## Source (_where user was when feedback was sent_)', | ||
| sourceLines.join('\n'), | ||
| ] | ||
| : []), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we also include tags? I feel like those are useful to us internally, we use them almost everywhere now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at a few examples, I think many of the tags are superfluous to implementing a feedback fix/ticket. Going to merge initial version without and we can easily add in if we fill they'd be a benefit
| }); | ||
|
|
||
| copy(markdown, { | ||
| successMessage: t('Copied feedback summary'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| successMessage: t('Copied feedback summary'), | |
| successMessage: t('Copied feedback'), |
ryan953
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iteration suggestions, but overall cool
static/app/components/feedback/feedbackItem/feedbackActions.tsx
Outdated
Show resolved
Hide resolved
<img width="1800" height="130" alt="image" src="https://github.com/user-attachments/assets/495ea37a-8333-48d3-8588-061557aa248e" /> copy feedback as markdown to make it easier to dump into LLM. For reviewers, talked this over with @jas-kas and see it as a low-hanging fruit addition that could be helpful for addressing individual feedback items
copy feedback as markdown to make it easier to dump into LLM.
For reviewers, talked this over with @jas-kas and see it as a low-hanging fruit addition that could be helpful for addressing individual feedback items