Skip to content

Conversation

@isabellaenriquez
Copy link
Member

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 25, 2025
@codecov
Copy link

codecov bot commented Nov 25, 2025

❌ 5 Tests Failed:

Tests completed Failed Passed Skipped
12748 5 12743 10
View the top 3 failed test(s) by shortest run time
UsageOverview does not render spend columns for non-self-serve without PAYG support
Stack Traces | 0.134s run time
Error: expect(received).toHaveLength(expected)

Expected length: 2
Received length: 5
Received array:  [<th><span class="css-1kc4ptp-Text e1cz2wip0">Feature</span></th>, <th><span class="css-1kc4ptp-Text e1cz2wip0">Usage</span></th>, <th><div class="css-1r3o8wo-TextOverflow-overflowEllipsis e1lyrgnz0">Errors</div></th>, <th><div class="css-1r3o8wo-TextOverflow-overflowEllipsis e1lyrgnz0">Quantity</div></th>, <th><div class="css-1r3o8wo-TextOverflow-overflowEllipsis e1lyrgnz0">% of Errors</div></th>]
    at Object.toHaveLength (.../usageOverview/components/table.spec.tsx:117:49)
UsageOverview renders columns for non-billing users
Stack Traces | 0.137s run time
Error: expect(received).toHaveLength(expected)

Expected length: 3
Received length: 6
Received array:  [<th><span class="css-1kc4ptp-Text e1cz2wip0">Feature</span></th>, <th><span class="css-1kc4ptp-Text e1cz2wip0">Usage</span></th>, <th><span class="css-1orknf9-Text-rc e1cz2wip0">Additional spend</span></th>, <th><div class="css-1r3o8wo-TextOverflow-overflowEllipsis e1lyrgnz0">Errors</div></th>, <th><div class="css-1r3o8wo-TextOverflow-overflowEllipsis e1lyrgnz0">Quantity</div></th>, <th><div class="css-1r3o8wo-TextOverflow-overflowEllipsis e1lyrgnz0">% of Errors</div></th>]
    at Object.toHaveLength (.../usageOverview/components/table.spec.tsx:62:49)
    at runNextTicks (node:internal/process/task_queues:65:5)
    at processTimers (node:internal/timers:520:9)
UsageOverview renders columns for non-self-serve with PAYG support
Stack Traces | 0.141s run time
Error: expect(received).toHaveLength(expected)

Expected length: 3
Received length: 6
Received array:  [<th><span class="css-1kc4ptp-Text e1cz2wip0">Feature</span></th>, <th><span class="css-1kc4ptp-Text e1cz2wip0">Usage</span></th>, <th><span class="css-1orknf9-Text-rc e1cz2wip0">Additional spend</span></th>, <th><div class="css-1r3o8wo-TextOverflow-overflowEllipsis e1lyrgnz0">Errors</div></th>, <th><div class="css-1r3o8wo-TextOverflow-overflowEllipsis e1lyrgnz0">Quantity</div></th>, <th><div class="css-1r3o8wo-TextOverflow-overflowEllipsis e1lyrgnz0">% of Errors</div></th>]
    at Object.toHaveLength (.../usageOverview/components/table.spec.tsx:91:49)
UsageOverview renders columns and buttons for billing users
Stack Traces | 0.167s run time
Error: expect(received).toHaveLength(expected)

Expected length: 3
Received length: 6
Received array:  [<th><span class="css-1kc4ptp-Text e1cz2wip0">Feature</span></th>, <th><span class="css-1kc4ptp-Text e1cz2wip0">Usage</span></th>, <th><span class="css-1orknf9-Text-rc e1cz2wip0">Additional spend</span></th>, <th><div class="css-1r3o8wo-TextOverflow-overflowEllipsis e1lyrgnz0">Errors</div></th>, <th><div class="css-1r3o8wo-TextOverflow-overflowEllipsis e1lyrgnz0">Quantity</div></th>, <th><div class="css-1r3o8wo-TextOverflow-overflowEllipsis e1lyrgnz0">% of Errors</div></th>]
    at Object.toHaveLength (.../usageOverview/components/table.spec.tsx:39:49)
    at runNextTicks (node:internal/process/task_queues:65:5)
    at processTimers (node:internal/timers:520:9)
Subscription > Overview renders for new billing UI
Stack Traces | 0.474s run time
TestingLibraryElementError: Found multiple elements with the text: Business plan

Here are the matching elements:

Ignored nodes: comments, script, style
...

Ignored nodes: comments, script, style
...

(If this is intentional, then use the `*AllBy*` variant of the query (like `queryAllByText`, `getAllByText`, or `findAllByText`)).

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/config.js:37:19)
    at getElementError (.../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:20:35)
    at getMultipleElementsFoundError (.../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:23:10)
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:55:13
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:95:19
    at Object.getByText (.../views/subscriptionPage/overview.spec.tsx:179:19)
    at runNextTicks (node:internal/process/task_queues:65:5)
    at processTimers (node:internal/timers:520:9)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

isabellaenriquez added a commit that referenced this pull request Dec 2, 2025
Split out from #103983

Pt 2 of
https://linear.app/getsentry/issue/BIL-1817/update-usage-overview-table-with-new-designs

This PR updates the Usage Overview buttons (including a copy and small
design change: `View usage history` -> `View all usage`) and also moves
Usage Overview-related components to a subfolder.

<img width="397" height="104" alt="Screenshot 2025-11-28 at 2 07 18 PM"
src="https://github.com/user-attachments/assets/827b8cf6-d0dd-4f6d-8f19-7b6f6ac934ed"
/>

On mobile, becomes ellipsis button with dropdown:
<img width="489" height="170" alt="Screenshot 2025-11-28 at 2 08 02 PM"
src="https://github.com/user-attachments/assets/369d4e2b-a3dc-44a5-8577-2937faea3a38"
/>

Also updated some styling related to borders, padding, and background
colors on the Overview page:

<img width="1512" height="859" alt="Screenshot 2025-11-28 at 2 18 33 PM"
src="https://github.com/user-attachments/assets/200cf043-3763-4a99-81bf-7cdb30149db1"
/>

<img width="1512" height="857" alt="Screenshot 2025-11-28 at 2 18 42 PM"
src="https://github.com/user-attachments/assets/910c97b9-a351-48e6-a741-aae1411a7194"
/>
isabellaenriquez added a commit that referenced this pull request Dec 2, 2025
Split out from #103983

Pt 3 of
https://linear.app/getsentry/issue/BIL-1817/update-usage-overview-table-with-new-designs

Extracts the chart and tables used in the existing category drawer into
a component + updates designs
isabellaenriquez added a commit that referenced this pull request Dec 2, 2025
Split out from #103983

Pt 4 of
https://linear.app/getsentry/issue/BIL-1817/update-usage-overview-table-with-new-designs

Introduces the new panel (behind a non-existent FF) + fixes file
structure so components are nested
isabellaenriquez added a commit that referenced this pull request Dec 2, 2025
Split out from #103983

Pt 5 of
https://linear.app/getsentry/issue/BIL-1817/update-usage-overview-table-with-new-designs

Introduces the new panel (behind a non-existent FF) + fixes file
structure so components are nested
<img width="706" height="772" alt="Screenshot 2025-11-28 at 4 08 50 PM"
src="https://github.com/user-attachments/assets/1469dd73-090d-4f3a-9b31-d654f6f36545"
/>
isabellaenriquez added a commit that referenced this pull request Dec 2, 2025
Split out from #103983

Pt 6 of
https://linear.app/getsentry/issue/BIL-1817/update-usage-overview-table-with-new-designs

Introduces the new table designs. Final PR will actually "GA" everything
and remove the dead code.
<img width="603" height="665" alt="Screenshot 2025-12-01 at 12 18 46 PM"
src="https://github.com/user-attachments/assets/1b1ab6a0-c53a-465f-bc24-ac88649c2fc6"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants