chore(trace-items): Add debug data to attribute items endpoint #103988
+59
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
|
||
| attributes = list(attribute_keys.values()) | ||
| sentry_sdk.set_context("api_response", {"attributes": attributes}) | ||
| return attributes |
Contributor
There was a problem hiding this comment.
Bug: Missing span debug data in sentry conventions branch
The span.set_data() calls for attribute_count and attribute_type are only executed in the use_sentry_conventions=False branch. When use_sentry_conventions is True, the function returns early at line 319 without setting this debug data on the span. Given this PR intends to add debug data to the endpoint, this inconsistency appears to be an oversight.
Additional Locations (1)
wmak
approved these changes
Nov 25, 2025
Zylphrex
deleted the
txiao/chore/add-debug-data-to-attribute-items-endpoint
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.