fix(tracemetrics): Wait for datascanned #103993
Merged
+45
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will not fire an analytics unless datascanned is provided.
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| metricAggregatesTableResult.result.isPending || | ||
| metricTimeseriesResult.isPending | ||
| metricTimeseriesResult.isPending || | ||
| !dataScanned |
Contributor
There was a problem hiding this comment.
Bug: Wrong data source for dataScanned in aggregate mode
The dataScanned check in AGGREGATE mode uses data from metricSamplesTableResult, but in AGGREGATE mode the relevant metadata comes from metricAggregatesTableResult. This causes the analytics to wait for the wrong data source - it checks whether samples table has dataScanned when it should check the aggregates table instead. This can prevent analytics from firing even when aggregate data is available, or allow it to fire with mismatched data.
Additional Locations (2)
Zylphrex
approved these changes
Nov 25, 2025
| if ( | ||
| metricSamplesTableResult.result.isFetching || | ||
| metricTimeseriesResult.isPending || | ||
| !dataScanned |
Member
There was a problem hiding this comment.
this check shouldn't be necessary anymore but no harm in keeping it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This will not fire an analytics unless datascanned is provided.