feat(explore-attr-breakdowns): Adding error and empty search state UI #104012
+108
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Abdkhan14
commented
Nov 25, 2025
Abdkhan14
commented
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| feedbackLink: <FeedbackLink />, | ||
| }), | ||
| }, | ||
| }; |
Contributor
There was a problem hiding this comment.
Bug: React hook called at module scope
The ERROR_STATE_CONFIG object is defined at module scope and includes JSX elements that render FeedbackLink components. Since FeedbackLink calls the useFeedbackForm() hook, this violates React's rules of hooks by executing a hook outside of a component render cycle. This will cause a runtime error when the module loads. The config object needs to be moved inside the ErrorState component or use a function that returns the config dynamically during render.
nsdeschenes
approved these changes
Nov 26, 2025
| ERROR_STATE_CONFIG[error?.status ?? 'default'] ?? ERROR_STATE_CONFIG.default; | ||
|
|
||
| return ( | ||
| <Flex direction="column" gap="2xl" padding="3xl" align="center" justify="center"> |
Contributor
There was a problem hiding this comment.
nit: There is also the <Stack /> for flex column, removing one prop from being added 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.