Skip to content

Conversation

@mifu67
Copy link
Contributor

@mifu67 mifu67 commented Nov 26, 2025

I'm a bit concerned that we have 500 million+ open periods already. Bump the offset for fake IDs to 10 billion so there's a vastly reduced risk of us running into it with real open period IDs.

@mifu67 mifu67 requested a review from a team November 26, 2025 17:49
@mifu67 mifu67 requested a review from a team as a code owner November 26, 2025 17:49
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 26, 2025
@codecov
Copy link

codecov bot commented Nov 26, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
30050 1 30049 240
View the top 1 failed test(s) by shortest run time
tests.sentry.incidents.serializers.test_workflow_engine_detector.TestDetectorSerializer::test_new_models_only
Stack Traces | 2.7s run time
#x1B[1m#x1B[.../incidents/serializers/test_workflow_engine_detector.py#x1B[0m:216: in test_new_models_only
    assert serialized_detector == self.expected
#x1B[1m#x1B[31mE   AssertionError: assert {'aggregate':...one.utc), ...} == {'aggregate':...one.utc), ...}#x1B[0m
#x1B[1m#x1B[31mE     #x1B[0m
#x1B[1m#x1B[31mE     Omitting 15 identical items, use -vv to show#x1B[0m
#x1B[1m#x1B[31mE     Differing items:#x1B[0m
#x1B[1m#x1B[31mE     {'triggers': [{'actions': [{'alertRuleTriggerId': '10000000084', 'dateCreated': datetime.datetime(2024, 12, 11, 3, 21,... 'alertThreshold': 100, 'dateCreated': datetime.datetime(2024, 12, 11, 3, 21, 34, tzinfo=datetime.timezone.utc), ...}]} != {'triggers': [{'actions': [{'alertRuleTriggerId': '1000000084', 'dateCreated': datetime.datetime(2024, 12, 11, 3, 21, ... 'alertThreshold': 100, 'dateCreated': datetime.datetime(2024, 12, 11, 3, 21, 34, tzinfo=datetime.timezone.utc), ...}]}#x1B[0m
#x1B[1m#x1B[31mE     {'id': '10000000021'} != {'id': '1000000021'}#x1B[0m
#x1B[1m#x1B[31mE     #x1B[0m
#x1B[1m#x1B[31mE     Full diff:#x1B[0m
#x1B[1m#x1B[31mE       {#x1B[0m
#x1B[1m#x1B[31mE           'aggregate': 'count()',#x1B[0m
#x1B[1m#x1B[31mE           'createdBy': None,#x1B[0m
#x1B[1m#x1B[31mE           'dateCreated': datetime.datetime(2024, 12, 11, 3, 21, 34, tzinfo=datetime.timezone.utc),#x1B[0m
#x1B[1m#x1B[31mE           'dateModified': datetime.datetime(2024, 12, 11, 3, 21, 34, tzinfo=datetime.timezone.utc),#x1B[0m
#x1B[1m#x1B[31mE           'description': '',#x1B[0m
#x1B[1m#x1B[31mE           'detectionType': 'static',#x1B[0m
#x1B[1m#x1B[31mE     -     'id': '1000000021',#x1B[0m
#x1B[1m#x1B[31mE     +     'id': '10000000021',#x1B[0m
#x1B[1m#x1B[31mE     ?             +#x1B[0m
#x1B[1m#x1B[31mE           'name': 'Sound Pigeon',#x1B[0m
#x1B[1m#x1B[31mE           'organizationId': '4555195392327680',#x1B[0m
#x1B[1m#x1B[31mE           'owner': None,#x1B[0m
#x1B[1m#x1B[31mE           'projects': [#x1B[0m
#x1B[1m#x1B[31mE               'bar',#x1B[0m
#x1B[1m#x1B[31mE           ],#x1B[0m
#x1B[1m#x1B[31mE           'query': 'level:error',#x1B[0m
#x1B[1m#x1B[31mE           'resolution': 1.0,#x1B[0m
#x1B[1m#x1B[31mE           'status': 0,#x1B[0m
#x1B[1m#x1B[31mE           'thresholdPeriod': 1,#x1B[0m
#x1B[1m#x1B[31mE           'timeWindow': 10.0,#x1B[0m
#x1B[1m#x1B[31mE           'triggers': [#x1B[0m
#x1B[1m#x1B[31mE               {#x1B[0m
#x1B[1m#x1B[31mE                   'actions': [#x1B[0m
#x1B[1m#x1B[31mE                       {#x1B[0m
#x1B[1m#x1B[31mE     -                     'alertRuleTriggerId': '1000000084',#x1B[0m
#x1B[1m#x1B[31mE     +                     'alertRuleTriggerId': '10000000084',#x1B[0m
#x1B[1m#x1B[31mE     ?                                             +#x1B[0m
#x1B[1m#x1B[31mE                           'dateCreated': datetime.datetime(2024, 12, 11, 3, 21, 34, tzinfo=datetime.timezone.utc),#x1B[0m
#x1B[1m#x1B[31mE                           'desc': 'Send a notification to admin@localhost',#x1B[0m
#x1B[1m#x1B[31mE     -                     'id': '1000000042',#x1B[0m
#x1B[1m#x1B[31mE     +                     'id': '10000000042',#x1B[0m
#x1B[1m#x1B[31mE     ?                             +#x1B[0m
#x1B[1m#x1B[31mE                           'inputChannelId': None,#x1B[0m
#x1B[1m#x1B[31mE                           'integrationId': None,#x1B[0m
#x1B[1m#x1B[31mE                           'priority': None,#x1B[0m
#x1B[1m#x1B[31mE                           'sentryAppId': None,#x1B[0m
#x1B[1m#x1B[31mE                           'targetIdentifier': '316',#x1B[0m
#x1B[1m#x1B[31mE                           'targetType': 'user',#x1B[0m
#x1B[1m#x1B[31mE                           'type': 'email',#x1B[0m
#x1B[1m#x1B[31mE                       },#x1B[0m
#x1B[1m#x1B[31mE                   ],#x1B[0m
#x1B[1m#x1B[31mE     -             'alertRuleId': '1000000021',#x1B[0m
#x1B[1m#x1B[31mE     +             'alertRuleId': '10000000021',#x1B[0m
#x1B[1m#x1B[31mE     ?                              +#x1B[0m
#x1B[1m#x1B[31mE                   'alertThreshold': 100,#x1B[0m
#x1B[1m#x1B[31mE                   'dateCreated': datetime.datetime(2024, 12, 11, 3, 21, 34, tzinfo=datetime.timezone.utc),#x1B[0m
#x1B[1m#x1B[31mE     -             'id': '1000000084',#x1B[0m
#x1B[1m#x1B[31mE     +             'id': '10000000084',#x1B[0m
#x1B[1m#x1B[31mE     ?                     +#x1B[0m
#x1B[1m#x1B[31mE                   'label': 'critical',#x1B[0m
#x1B[1m#x1B[31mE                   'resolveThreshold': 100,#x1B[0m
#x1B[1m#x1B[31mE                   'thresholdType': 0,#x1B[0m
#x1B[1m#x1B[31mE               },#x1B[0m
#x1B[1m#x1B[31mE           ],#x1B[0m
#x1B[1m#x1B[31mE       }#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@mifu67 mifu67 merged commit 591b4ea into master Nov 26, 2025
66 checks passed
@mifu67 mifu67 deleted the mifu67/aci/bump-offset branch November 26, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants