feat(traces): Add cross event dropdown functionality #104100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Contributor
Author
|
@sentry review |
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
nsdeschenes
force-pushed
the
nd/exp-618/feat-add-cross-event-dropdown-functionality
branch
from
f2a401a to
2dcbb84
Compare
nsdeschenes
force-pushed
the
nd/exp-618/feat-add-cross-event-dropdown-functionality
branch
from
2dcbb84 to
6bd0ad2
Compare
Zylphrex
approved these changes
Dec 1, 2025
nsdeschenes
deleted the
nd/exp-618/feat-add-cross-event-dropdown-functionality
branch
jerryzhou196
pushed a commit
that referenced
this pull request
Dec 1, 2025
This PR adds in some refinements to the cross event dropdown, such as proper labels, ability to add a second cross event, and disabling itself when there are two cross events present. I also moved the search section of the spans tab into its own file to keep things a bit more tidy, as well as refactoring the spans tab tests to use the `additionalWrapper` arg, over wrapping in the wrapper saving a couple lines. Ticket: EXP-618
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds in some refinements to the cross event dropdown, such as proper labels, ability to add a second cross event, and disabling itself when there are two cross events present.
I also moved the search section of the spans tab into its own file to keep things a bit more tidy, as well as refactoring the spans tab tests to use the
additionalWrapperarg, over wrapping in the wrapper saving a couple lines.Ticket: EXP-618