Skip to content

feat(dashboards): Prevents rendering edit and save ui on prebuilt insights dashboards #104101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 27, 2025
Merged

feat(dashboards): Prevents rendering edit and save ui on prebuilt insights dashboards #104101

merged 7 commits into from
Nov 27, 2025
+74 −30

Conversation

@edwardgou-sentry
Copy link
Contributor

@edwardgou-sentry edwardgou-sentry commented Nov 27, 2025

Prebuilt insights dashboards are not editable by users. Removes save and edit buttons when rendering a prebuilt dashboard

@edwardgou-sentry edwardgou-sentry requested a review from a team November 27, 2025 16:18
@edwardgou-sentry edwardgou-sentry requested a review from a team as a code owner November 27, 2025 16:18
@linear
Copy link

linear bot commented Nov 27, 2025

BROWSE-89 Prebuilt Session Health Dashboard should not be editable

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 27, 2025
cursor[bot]
cursor bot reviewed Nov 27, 2025
View reviewed changes
@codecov
Copy link

codecov bot commented Nov 27, 2025 •
edited
Loading

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
42813 3 42810 251
View the top 3 failed test(s) by shortest run time 
tests.acceptance.test_organization_dashboards.OrganizationDashboardsAcceptanceTest::test_resize_big_number_widget
Stack Traces | 103s run time 
#x1B[1m#x1B[31mtests/acceptance/test_organization_dashboards.py#x1B[0m:321: in test_resize_big_number_widget
    self.page.enter_edit_state()
#x1B[1m#x1B[31mfixtures/page_objects/dashboard_detail.py#x1B[0m:41: in enter_edit_state
    button = self.browser.element('[data-test-id="dashboard-edit"]')
#x1B[1m#x1B[.../testutils/pytest/selenium.py#x1B[0m:136: in element
    self.wait_until(selector)
#x1B[1m#x1B[.../testutils/pytest/selenium.py#x1B[0m:230: in wait_until
    wait.until(expected_conditions.presence_of_element_located((By.CSS_SELECTOR, selector)))
#x1B[1m#x1B[31m.venv/lib/python3.13.../webdriver/support/wait.py#x1B[0m:105: in until
    raise TimeoutException(message, screen, stacktrace)
#x1B[1m#x1B[31mE   selenium.common.exceptions.TimeoutException: Message: #x1B[0m
#x1B[1m#x1B[31mE   Stacktrace:#x1B[0m
#x1B[1m#x1B[31mE   #0 0x5639ed94d32a <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #1 0x5639ed399e4b <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #2 0x5639ed3ec82b <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #3 0x5639ed3eca61 <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #4 0x5639ed43ba44 <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #5 0x5639ed438df7 <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #6 0x5639ed3dec1a <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #7 0x5639ed3df921 <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #8 0x5639ed914239 <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #9 0x5639ed9171e8 <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #10 0x5639ed8fd4c9 <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #11 0x5639ed917db5 <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #12 0x5639ed8e4e93 <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #13 0x5639ed93a098 <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #14 0x5639ed93a273 <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #15 0x5639ed94c2c3 <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #16 0x7f044829caa4 <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #17 0x7f0448329c6c <unknown>#x1B[0m
tests.acceptance.test_organization_dashboards.OrganizationDashboardsAcceptanceTest::test_move_existing_widget_on_existing_dashboard
Stack Traces | 104s run time 
#x1B[1m#x1B[31mtests/acceptance/test_organization_dashboards.py#x1B[0m:127: in test_move_existing_widget_on_existing_dashboard
    self.page.enter_edit_state()
#x1B[1m#x1B[31mfixtures/page_objects/dashboard_detail.py#x1B[0m:41: in enter_edit_state
    button = self.browser.element('[data-test-id="dashboard-edit"]')
#x1B[1m#x1B[.../testutils/pytest/selenium.py#x1B[0m:136: in element
    self.wait_until(selector)
#x1B[1m#x1B[.../testutils/pytest/selenium.py#x1B[0m:230: in wait_until
    wait.until(expected_conditions.presence_of_element_located((By.CSS_SELECTOR, selector)))
#x1B[1m#x1B[31m.venv/lib/python3.13.../webdriver/support/wait.py#x1B[0m:105: in until
    raise TimeoutException(message, screen, stacktrace)
#x1B[1m#x1B[31mE   selenium.common.exceptions.TimeoutException: Message: #x1B[0m
#x1B[1m#x1B[31mE   Stacktrace:#x1B[0m
#x1B[1m#x1B[31mE   #0 0x56259c5db32a <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #1 0x56259c027e4b <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #2 0x56259c07a82b <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #3 0x56259c07aa61 <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #4 0x56259c0c9a44 <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #5 0x56259c0c6df7 <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #6 0x56259c06cc1a <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #7 0x56259c06d921 <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #8 0x56259c5a2239 <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #9 0x56259c5a51e8 <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #10 0x56259c58b4c9 <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #11 0x56259c5a5db5 <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #12 0x56259c572e93 <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #13 0x56259c5c8098 <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #14 0x56259c5c8273 <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #15 0x56259c5da2c3 <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #16 0x7f2d0689caa4 <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #17 0x7f2d06929c6c <unknown>#x1B[0m
tests.acceptance.test_organization_dashboards.OrganizationDashboardsAcceptanceTest::test_deleting_stacked_widgets_by_context_menu_does_not_trigger_confirm_on_edit_cancel
Stack Traces | 109s run time 
#x1B[1m#x1B[31mtests/acceptance/test_organization_dashboards.py#x1B[0m:508: in test_deleting_stacked_widgets_by_context_menu_does_not_trigger_confirm_on_edit_cancel
    self.page.enter_edit_state()
#x1B[1m#x1B[31mfixtures/page_objects/dashboard_detail.py#x1B[0m:41: in enter_edit_state
    button = self.browser.element('[data-test-id="dashboard-edit"]')
#x1B[1m#x1B[.../testutils/pytest/selenium.py#x1B[0m:136: in element
    self.wait_until(selector)
#x1B[1m#x1B[.../testutils/pytest/selenium.py#x1B[0m:230: in wait_until
    wait.until(expected_conditions.presence_of_element_located((By.CSS_SELECTOR, selector)))
#x1B[1m#x1B[31m.venv/lib/python3.13.../webdriver/support/wait.py#x1B[0m:105: in until
    raise TimeoutException(message, screen, stacktrace)
#x1B[1m#x1B[31mE   selenium.common.exceptions.TimeoutException: Message: #x1B[0m
#x1B[1m#x1B[31mE   Stacktrace:#x1B[0m
#x1B[1m#x1B[31mE   #0 0x55d534bbc32a <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #1 0x55d534608e4b <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #2 0x55d53465b82b <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #3 0x55d53465ba61 <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #4 0x55d5346aaa44 <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #5 0x55d5346a7df7 <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #6 0x55d53464dc1a <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #7 0x55d53464e921 <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #8 0x55d534b83239 <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #9 0x55d534b861e8 <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #10 0x55d534b6c4c9 <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #11 0x55d534b86db5 <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #12 0x55d534b53e93 <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #13 0x55d534ba9098 <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #14 0x55d534ba9273 <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #15 0x55d534bbb2c3 <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #16 0x7f8aa289caa4 <unknown>#x1B[0m
#x1B[1m#x1B[31mE   #17 0x7f8aa2929c6c <unknown>#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

sentry[bot]
sentry bot reviewed Nov 27, 2025
View reviewed changes
DominikB2014
DominikB2014 approved these changes Nov 27, 2025
View reviewed changes
Copy link
Contributor

@DominikB2014 DominikB2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

sentry[bot]
sentry bot reviewed Nov 27, 2025
View reviewed changes
@edwardgou-sentry edwardgou-sentry enabled auto-merge (squash) November 27, 2025 16:57
@edwardgou-sentry
maybe fix?
d789713
@edwardgou-sentry
Merge branch 'edwardgou/browse-89-prebuilt-session-health-dashboard-s…
36dcb54 
…hould-not-be-editable' of github.com:getsentry/sentry into edwardgou/browse-89-prebuilt-session-health-dashboard-should-not-be-editable
sentry[bot]
sentry bot reviewed Nov 27, 2025
View reviewed changes
sentry[bot]
sentry bot reviewed Nov 27, 2025
View reviewed changes
@edwardgou-sentry edwardgou-sentry merged commit ef9d0a4 into master Nov 27, 2025
47 checks passed
@edwardgou-sentry edwardgou-sentry deleted the edwardgou/browse-89-prebuilt-session-health-dashboard-should-not-be-editable branch November 27, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@mjq mjq mjq approved these changes

@DominikB2014 DominikB2014 DominikB2014 approved these changes

+1 more reviewer

@sentry sentry[bot] sentry[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@edwardgou-sentry @mjq @DominikB2014