-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat(usage overview): Update buttons #104134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| {`${startDate.format(startsAndEndsSameYear ? 'MMM D' : 'MMM D, YYYY')} - ${endDate.format('MMM D, YYYY')}`} | ||
| </Text> | ||
| </Flex> | ||
| {hasBillingPerms && ( | ||
| <Flex gap="lg" direction={{xs: 'column', sm: 'row'}}> | ||
| <LinkButton | ||
| icon={<IconGraph />} | ||
| aria-label={t('View usage history')} | ||
| priority="link" | ||
| to="/settings/billing/usage/" | ||
| > | ||
| {t('View usage history')} | ||
| </LinkButton> | ||
| <Button | ||
| icon={<IconDownload />} | ||
| aria-label={t('Download as CSV')} | ||
| disabled={isPending || isError} | ||
| onClick={() => { | ||
| trackGetsentryAnalytics('subscription_page.download_reports.clicked', { | ||
| organization, | ||
| reportType: 'summary', | ||
| }); | ||
| if (currentHistory) { | ||
| window.open(currentHistory.links.csv, '_blank'); | ||
| } | ||
| }} | ||
| > | ||
| {t('Download as CSV')} | ||
| </Button> | ||
| </Flex> | ||
| )} | ||
| {hasBillingPerms && <UsageOverviewActions organization={organization} />} | ||
| </Flex> | ||
| <UsageOverviewTable | ||
| subscription={subscription} |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
intentional since button design has changed on mobile views
| </Button> | ||
| </Flex> | ||
| )} | ||
| {hasBillingPerms && <UsageOverviewActions organization={organization} />} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Removed responsive direction from header Flex
The parent Flex container lost its direction={{xs: 'column', sm: 'row'}} prop during the refactor. On narrow screens that aren't classified as NavLayout.MOBILE (like small tablets), the header will remain in row layout instead of stacking vertically, potentially causing layout overflow or cramped appearance. The align={{xs: 'start', sm: 'center'}} prop suggests this flex was intended to have responsive direction behavior.
Split out from #103983
Pt 2 of https://linear.app/getsentry/issue/BIL-1817/update-usage-overview-table-with-new-designs
This PR updates the Usage Overview buttons (including a copy and small design change:
View usage history->View all usage) and also moves Usage Overview-related components to a subfolder.On mobile, becomes ellipsis button with dropdown:

Also updated some styling related to borders, padding, and background colors on the Overview page: