fix(issues): Handle None users in GroupSearchView serializer #104178
Merged
+40
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes [ISWF-719](https://linear.app/getsentry/issue/ISWF-719) When user_service.serialize_many() returns None for a deleted , the dict comprehension would crash with: TypeError: 'NoneType' object is not subscriptable The fix filters out None values when building the serialized_users dict. Views with users that can't be serialized will now have createdBy: None instead of crashing the entire endpoint.
github-actions
bot
added
the
Scope: Backend
evanpurkhiser
deleted the
evanpurkhiser/fix-issues-handle-none-users-in-groupsearchview-serializer
branch
jerryzhou196
pushed a commit
that referenced
this pull request
Dec 1, 2025
Fixes [ISWF-719](https://linear.app/getsentry/issue/ISWF-719) When user_service.serialize_many() returns None for a deleted , the dict comprehension would crash with: TypeError: 'NoneType' object is not subscriptable The fix filters out None values when building the serialized_users dict. Views with users that can't be serialized will now have createdBy: None instead of crashing the entire endpoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ISWF-719
When user_service.serialize_many() returns None for a deleted user, the dict
comprehension would crash with: TypeError: 'NoneType' object is not
subscriptable
The fix filters out None values when building the serialized_users dict.
Views with users that can't be serialized will now have createdBy: None
instead of crashing the entire endpoint.