Skip to content

Conversation

@billyvg
Copy link
Member

@billyvg billyvg commented Nov 20, 2018

This refactors the stream search bar into two components so that the base
component can be re-used. The stream search bar will provide supported
tags, default tags, and the API call to get tag values.

Required for #10689

This refactors the stream search bar into two components so that the base component
can be re-used. The stream search bar will provide supported tags, default tags, and the API call to get tag values.
@billyvg
Copy link
Member Author

billyvg commented Nov 20, 2018

Review the most recent commit for a better diff.

@billyvg billyvg requested a review from a team November 20, 2018 21:08
@evanpurkhiser
Copy link
Member

taking a look.

Copy link
Member

@evanpurkhiser evanpurkhiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work

@billyvg billyvg force-pushed the ref/ui/refactor-stream-search-bar branch from 23588f1 to 50f60f4 Compare November 20, 2018 23:53
@billyvg billyvg merged commit 6d82434 into master Nov 29, 2018
@billyvg billyvg deleted the ref/ui/refactor-stream-search-bar branch November 29, 2018 16:24
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants