From eb6c68f2c46b53e9d43e6950074a1a065b0b8a34 Mon Sep 17 00:00:00 2001 From: Hector Date: Mon, 26 Jan 2026 19:31:25 +0000 Subject: [PATCH] feat(preprod): Settings URL /builds/ -> /mobile-builds/ --- .../preprod/vcs/status_checks/size/templates.py | 2 +- static/app/router/routes.tsx | 2 +- .../header/buildDetailsHeaderContent.tsx | 2 +- static/app/views/preprod/buildList/buildList.tsx | 2 +- .../settings/project/navigationConfiguration.tsx | 2 +- .../vcs/status_checks/size/test_templates.py | 14 +++++--------- 6 files changed, 10 insertions(+), 14 deletions(-) diff --git a/src/sentry/preprod/vcs/status_checks/size/templates.py b/src/sentry/preprod/vcs/status_checks/size/templates.py index 8ded6472aa91a1..df1a3cbd7b371f 100644 --- a/src/sentry/preprod/vcs/status_checks/size/templates.py +++ b/src/sentry/preprod/vcs/status_checks/size/templates.py @@ -292,7 +292,7 @@ def _get_settings_url( triggered_rules: list[TriggeredRule] | None = None, ) -> str: """Build the settings URL for the project's preprod settings page.""" - base_url = f"/settings/projects/{project.slug}/builds/" + base_url = f"/settings/projects/{project.slug}/mobile-builds/" if triggered_rules: expanded_params = "&".join(f"expanded={tr.rule.id}" for tr in triggered_rules) return project.organization.absolute_url(base_url, query=expanded_params) diff --git a/static/app/router/routes.tsx b/static/app/router/routes.tsx index e28e75e1571f58..b1993ec6b40bee 100644 --- a/static/app/router/routes.tsx +++ b/static/app/router/routes.tsx @@ -683,7 +683,7 @@ function buildRoutes(): RouteObject[] { component: make(() => import('sentry/views/settings/project/tempest')), }, { - path: 'builds/', + path: 'mobile-builds/', name: t('Mobile Builds'), component: make(() => import('sentry/views/settings/project/preprod')), }, diff --git a/static/app/views/preprod/buildDetails/header/buildDetailsHeaderContent.tsx b/static/app/views/preprod/buildDetails/header/buildDetailsHeaderContent.tsx index e57adc306f5fec..d3e09f0d0f70ac 100644 --- a/static/app/views/preprod/buildDetails/header/buildDetailsHeaderContent.tsx +++ b/static/app/views/preprod/buildDetails/header/buildDetailsHeaderContent.tsx @@ -182,7 +182,7 @@ export function BuildDetailsHeaderContent(props: BuildDetailsHeaderContentProps) size="sm" icon={} aria-label={t('Settings')} - to={`/settings/${organization.slug}/projects/${projectId}/builds/`} + to={`/settings/${organization.slug}/projects/${projectId}/mobile-builds/`} /> } aria-label={t('Settings')} - to={`/settings/${organization.slug}/projects/${projectId}/builds/`} + to={`/settings/${organization.slug}/projects/${projectId}/mobile-builds/`} /> )} diff --git a/static/app/views/settings/project/navigationConfiguration.tsx b/static/app/views/settings/project/navigationConfiguration.tsx index 24d34455bdfe25..904fcf5e95df8c 100644 --- a/static/app/views/settings/project/navigationConfiguration.tsx +++ b/static/app/views/settings/project/navigationConfiguration.tsx @@ -139,7 +139,7 @@ export default function getConfiguration({ show: () => !!(organization && hasTempestAccess(organization)) && !isSelfHosted, }, { - path: `${pathPrefix}/builds/`, + path: `${pathPrefix}/mobile-builds/`, title: t('Mobile Builds'), show: () => !!organization?.features?.includes('preprod-issues'), badge: () => 'beta', diff --git a/tests/sentry/preprod/vcs/status_checks/size/test_templates.py b/tests/sentry/preprod/vcs/status_checks/size/test_templates.py index 34fd7e43d7e67f..b5334471d0046c 100644 --- a/tests/sentry/preprod/vcs/status_checks/size/test_templates.py +++ b/tests/sentry/preprod/vcs/status_checks/size/test_templates.py @@ -799,7 +799,7 @@ def test_mixed_platforms_render_separate_tables(self): android_url = f"http://testserver/organizations/{self.organization.slug}/preprod/size/{android_artifact.id}?project={self.project.slug}" ios_url = f"http://testserver/organizations/{self.organization.slug}/preprod/size/{ios_artifact.id}?project={self.project.slug}" - settings_url = f"http://testserver/settings/projects/{self.project.slug}/builds/" + settings_url = f"http://testserver/settings/projects/{self.project.slug}/mobile-builds/" expected = f"""\ ## 2 Apps Analyzed @@ -1127,9 +1127,7 @@ def test_single_triggered_rule_shows_details_section(self): ) artifact_url = f"http://testserver/organizations/{self.organization.slug}/preprod/size/{artifact.id}?project={self.project.slug}" - settings_url = ( - f"http://testserver/settings/projects/{self.project.slug}/builds/?expanded=rule-1" - ) + settings_url = f"http://testserver/settings/projects/{self.project.slug}/mobile-builds/?expanded=rule-1" expected = f"""\ ## ❌ 1 App Failed Size Checks @@ -1224,7 +1222,7 @@ def test_multiple_triggered_rules_url_formatting(self): ) artifact_url = f"http://testserver/organizations/{self.organization.slug}/preprod/size/{artifact.id}?project={self.project.slug}" - settings_url = f"http://testserver/settings/projects/{self.project.slug}/builds/?expanded=rule-download-absolute&expanded=rule-install-diff&expanded=rule-download-percent" + settings_url = f"http://testserver/settings/projects/{self.project.slug}/mobile-builds/?expanded=rule-download-absolute&expanded=rule-install-diff&expanded=rule-download-percent" expected = f"""\ ## ❌ 1 App Failed Size Checks @@ -1331,7 +1329,7 @@ def test_multiple_apps_with_triggered_rules(self): artifact1_url = f"http://testserver/organizations/{self.organization.slug}/preprod/size/{artifact1.id}?project={self.project.slug}" artifact2_url = f"http://testserver/organizations/{self.organization.slug}/preprod/size/{artifact2.id}?project={self.project.slug}" - settings_url = f"http://testserver/settings/projects/{self.project.slug}/builds/?expanded=rule-1&expanded=rule-2" + settings_url = f"http://testserver/settings/projects/{self.project.slug}/mobile-builds/?expanded=rule-1&expanded=rule-2" expected = f"""\ ## ❌ 2 Apps Failed Size Checks @@ -1434,9 +1432,7 @@ def test_mixed_pass_fail_with_triggered_rules(self): failed_url = f"http://testserver/organizations/{self.organization.slug}/preprod/size/{failed_artifact.id}?project={self.project.slug}" passed_url = f"http://testserver/organizations/{self.organization.slug}/preprod/size/{passed_artifact.id}?project={self.project.slug}" - settings_url = ( - f"http://testserver/settings/projects/{self.project.slug}/builds/?expanded=rule-1" - ) + settings_url = f"http://testserver/settings/projects/{self.project.slug}/mobile-builds/?expanded=rule-1" expected = f"""\ ## ❌ 1 App Failed Size Checks