ref(fileblob): Change naming convention for file blobs #10748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitsuhiko
suggested changes
Nov 23, 2018
| size = 0 | ||
| checksum = sha1() | ||
| while 1: | ||
| while True: |
Contributor
There was a problem hiding this comment.
not that it matters much but while 1 is optimized in python 2 and while True is not.
Contributor
Author
There was a problem hiding this comment.
autopep8 changed those automatically, so not really sure we want to fight it.
mitsuhiko
approved these changes
Nov 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the change newly generated file names looked like this:
17858/55997/18b0ec4fa3ea43e78502b7d2758e0ab1After the change:
ab/a27f/fe029b475f83b5f30e3da8b164It gives us 256 directories at the top level, with maximum 65536 directories at the second level, and
2**104leaves.The main motivation for the change is to achieve more even name distribution for the GCS storage backend.
This shouldn't affect any existing files on any of the supported backends (filesystem, gcs, s3).
#sync-getsentry