New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(events-stream): Add zoom back to charts (APP-832) #10904
Conversation
a54dc20
to
260fbed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple things from testing the UI
- chart doesn't render at all on initial load
- zooming in on a date range does not update the date picker with hour/minute
src/sentry/static/sentry/app/views/organizationEvents/eventsTable.jsx
Outdated
Show resolved
Hide resolved
@lynnagara Thanks, the last rebase with master broke the initial load (and also uncovered other subtle bugs that have been fixed too). Things to look out for with manual tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be good to hide the icons (1px image hack is totally fine if that's all we can easily do). Since zoom is effectively an alternate method of date selection input it's odd to think about "restoring" - what does that mean and to what state do we consider the "original"?
We'll followup with a design/ux pass on this. Zooming w/ the chart has a nice animation with it and the "original" is the state since the last chart component render. Since users will have no concept of this, it'll lead to some confusing UX. |
This adds zoom back to events chart -- icons are a WIP (I'm hoping we can come back to it in a followup), but behavior has changed so that we can start in "zoom-enabled" state which I think greatly improves the zoom behavior.
There's also a lot of logic so that react does not re-render our chart component (and allows eCharts to handle the zoom). This provides a more seamless experience when zooming on the chart.
The buttons are a distraction but zoom doesn't work unless that toolbar is present. A potential solution is to change their icons to a 1px img so that they are "hidden".