{props.children}
;
- }),
-}));
-
-jest.mock('sentry/components/events/autofix/useAutofix');
-
-const mockButton = jest.mocked(Button);
-
-describe('AutofixChanges', () => {
- const defaultProps = {
- groupId: '123',
- runId: '456',
- step: AutofixStepFixture({
- type: AutofixStepType.CHANGES,
- changes: [AutofixCodebaseChangeData()],
- }) as AutofixChangesStep,
- } satisfies React.ComponentProps
- = 0
- ? previousInsightCount
- : null
- }
- >
-
-
-
- {change.repo_name}
- {change.title}
-
-
-
-
- {tokens.map((lineTokens, i) => (
-
- {lineTokens.map((token, j) => (
-
- {token.children}
-
- ))}
-
- ))}
-
-
- {fileName}
- {actionLabel}
- {hasDuplicateNames && (
- {t("You've successfully configured write access!")}
- -
- {tct(
- 'In order to create pull requests, install and grant write access to the [link:Sentry Seer GitHub App] for the following repositories:',
- {
- link: (
-
- {tct(
- 'In order to create pull requests, install and grant write access to the [link:Sentry Seer GitHub App] for the relevant repositories.',
- {
- link: (
-
-
-
-
-
- );
-}
-
-const DoneWrapper = styled('div')`
- position: relative;
- display: flex;
- align-items: center;
- justify-content: center;
- flex-direction: column;
- padding: 40px;
- font-size: ${p => p.theme.font.size.lg};
-`;
-
-const DoneIcon = styled(IconCheckmark)`
- margin-bottom: ${p => p.theme.space['3xl']};
-`;
-
-const RepoLinkUl = styled('ul')`
- display: flex;
- flex-direction: column;
- gap: ${p => p.theme.space.xs};
- padding: 0;
-`;
-
-const RepoItem = styled('li')<{isOk?: boolean}>`
- display: flex;
- align-items: center;
- justify-content: space-between;
- gap: ${p => p.theme.space.xl};
- padding: ${p => p.theme.space.md};
- margin-bottom: ${p => p.theme.space.xs};
- background-color: ${p => (p.isOk ? p.theme.colors.green100 : 'transparent')};
- border-radius: ${p => p.theme.radius.md};
-`;
diff --git a/static/app/components/events/autofix/autofixSolution.spec.tsx b/static/app/components/events/autofix/autofixSolution.spec.tsx
deleted file mode 100644
index ea94a9847d0777..00000000000000
--- a/static/app/components/events/autofix/autofixSolution.spec.tsx
+++ /dev/null
@@ -1,593 +0,0 @@
-import {
- render,
- screen,
- userEvent,
- waitFor,
- within,
-} from 'sentry-test/reactTestingLibrary';
-
-import {AutofixSolution} from 'sentry/components/events/autofix/autofixSolution';
-import {
- AutofixStatus,
- type AutofixData,
- type AutofixSolutionTimelineEvent,
-} from 'sentry/components/events/autofix/types';
-import {
- useAutofixData,
- useAutofixRepos,
-} from 'sentry/components/events/autofix/useAutofix';
-
-jest.mock('sentry/components/events/autofix/useAutofix');
-
-describe('AutofixSolution', () => {
- const defaultSolution = [
- {
- title: 'Fix the bug',
- code_snippet_and_analysis: 'Some code and analysis',
- timeline_item_type: 'internal_code' as const,
- relevant_code_file: {
- file_path: 'src/file.js',
- repo_name: 'owner/repo',
- url: 'https://github.com/owner/repo/blob/main/src/file.js',
- },
- },
- ];
-
- const defaultProps = {
- solution: defaultSolution,
- groupId: '123',
- runId: 'run-123',
- solutionSelected: false,
- status: AutofixStatus.COMPLETED,
- } satisfies React.ComponentProps{t('Allow Seer to Make Pull Requests')}
-
- {steps.map((step, index) => {
- const previousDefaultStepIndex = steps
- .slice(0, index)
- .findLastIndex(s => s.type === AutofixStepType.DEFAULT);
- const previousDefaultStep =
- previousDefaultStepIndex >= 0 ? steps[previousDefaultStepIndex] : undefined;
- const previousInsightCount =
- previousDefaultStep?.type === AutofixStepType.DEFAULT
- ? previousDefaultStep.insights.length
- : undefined;
-
- const hasSolutionStepBefore = steps
- .slice(0, index)
- .some(s => s.type === AutofixStepType.SOLUTION);
- const hideStep =
- (!enableSeerCoding && hasSolutionStepBefore) ||
- (!enableSeerCoding && step.type === AutofixStepType.CHANGES);
-
- const previousStep = index > 0 ? steps[index - 1] : null;
- const previousStepErrored =
- previousStep !== null &&
- previousStep?.type === step.type &&
- previousStep.status === 'ERROR';
- const nextStep = index + 1 < steps.length ? steps[index + 1] : null;
- const twoInsightStepsInARow =
- nextStep?.type === AutofixStepType.DEFAULT &&
- step.type === AutofixStepType.DEFAULT &&
- step.insights.length > 0 &&
- nextStep.insights.length > 0;
- const stepBelowProcessingAndEmpty =
- nextStep?.type === AutofixStepType.DEFAULT &&
- nextStep?.status === 'PROCESSING' &&
- nextStep?.insights?.length === 0;
-
- if (hideStep) {
- return null;
- }
-
- return (
-
- {errorMessage}
-
- Just hit "Start Over." -
- )}
-
- );
-}
-
-const StepMessage = styled('div')`
- overflow: hidden;
- padding: ${p => p.theme.space.md};
- color: ${p => p.theme.tokens.content.secondary};
- font-size: ${p => p.theme.font.size.sm};
- justify-content: flex-start;
- text-align: left;
-`;
-
-const StepCard = styled('div')`
- overflow: hidden;
-
- :last-child {
- margin-bottom: 0;
- }
-`;
-
-const ContentWrapper = styled(motion.div)`
- display: grid;
- grid-template-rows: 1fr;
- transition: grid-template-rows 300ms;
- will-change: grid-template-rows;
-
- > div {
- /* So that focused element outlines don't get cut off */
- padding: 0 1px;
- overflow: hidden;
- }
-`;
-
-const AnimationWrapper = styled(motion.div)``;
-
-const StandaloneErrorMessage = styled('div')`
- margin: ${p => p.theme.space.md} 0;
- padding: ${p => p.theme.space.xl};
- color: ${p => p.theme.tokens.content.secondary};
-`;
diff --git a/static/app/components/events/autofix/autofixTimeline.tsx b/static/app/components/events/autofix/autofixTimeline.tsx
deleted file mode 100644
index 7352ba905f227e..00000000000000
--- a/static/app/components/events/autofix/autofixTimeline.tsx
+++ /dev/null
@@ -1,62 +0,0 @@
-import {useState} from 'react';
-
-import {AutofixTimelineItem} from 'sentry/components/events/autofix/autofixTimelineItem';
-import {Timeline} from 'sentry/components/timeline';
-
-import type {AutofixTimelineEvent} from './types';
-
-type Props = {
- events: AutofixTimelineEvent[];
- groupId: string;
- runId: string;
- eventCodeUrls?: Array
- = 0 ? previousDefaultStepIndex : undefined
- }
- previousInsightCount={previousInsightCount}
- isRootCauseFirstAppearance={
- step.type === AutofixStepType.ROOT_CAUSE_ANALYSIS && !isInitialMount
- }
- isSolutionFirstAppearance={
- step.type === AutofixStepType.SOLUTION && !isInitialMount
- }
- isChangesFirstAppearance={
- step.type === AutofixStepType.CHANGES && !isInitialMount
- }
- isAutoTriggeredRun={isAutoTriggeredRun}
- event={event}
- codingAgents={data.coding_agents}
- />
-
- );
- })}
- {codingAgentData.map(({codingAgentState, repo}) => (
- - Just hit "Start Over." -
-
- {getStatusText(codingAgentState.status)}
-
-
-
-
-
- {tct('Seer can be turned off in [settingsDocs:Settings].', {
- settingsDocs: (
-
- ),
- })}
-
-
- {isError ?
-
- {insightCards.map(card => {
- if ((!isPending && !card.insight) || (isPending && !card.showWhenLoading)) {
- return null;
- }
- return (
-
-
- {card.icon}
-
- {card.title}
-
-
-
-
-
- {isPending ? (
-
-
- ) : (
-
- {card.insight && (
-
- )}
-
-
- );
- })}
-
-
-
- );
-}
-
-function GroupSummaryCollapsed({
- group,
- project,
- event,
- data,
- isPending,
- setForceEvent,
- isError,
- defaultCollapsed = false,
-}: {
- data: GroupSummaryData | undefined;
- event: Event | null | undefined;
- group: Group;
- isError: boolean;
- isPending: boolean;
- project: Project;
- setForceEvent: (v: boolean) => void;
- defaultCollapsed?: boolean;
-}) {
- const [isExpanded, setIsExpanded] = useState(!defaultCollapsed);
-
- const handleToggle = () => {
- setIsExpanded(!isExpanded);
- };
-
- useLayoutEffect(() => {
- setIsExpanded(!defaultCollapsed);
- }, [defaultCollapsed]);
-
- return (
- {t('Error loading summary')}
: null}
-
- {isError ?
-
-
- {isPending ? (
-
- {data?.headline || t('Issue Summary')}
-
- )}
-
- {isExpanded ? (
-
-
-
-
-
-
-
-
-
- )}
-
- );
-}
-
-function GroupSummaryFull({
- group,
- project,
- data,
- isPending,
- isError,
- setForceEvent,
- preview,
- event,
-}: {
- data: GroupSummaryData | undefined;
- event: Event | null | undefined;
- group: Group;
- isError: boolean;
- isPending: boolean;
- preview: boolean;
- project: Project;
- setForceEvent: (v: boolean) => void;
-}) {
- const config = getConfigForIssueType(group, project);
- const shouldShowResources = config.resources && !preview;
-
- const insightCards = [
- {
- id: 'whats_wrong',
- title: t('What Happened'),
- insight: data?.whatsWrong,
- icon: {t('Error loading summary')}
: null}
- {!isError && (
- {t('Error loading summary')}
: null}
-
-
-
- {insightCards.map(card => {
- if (!card.isLoading && !card.insight) {
- return null;
- }
-
- return (
-
-
-
-
- {card.icon}
- {card.title}
-
-
- {!card.isLoading && card.feedbackType && autofixData?.run_id && (
- e.stopPropagation()}
- />
- )}
- {card.copyText && card.copyTitle && (
- {
- e.stopPropagation();
- }}
- analyticsEventName={card.copyAnalyticsEventName}
- analyticsEventKey={card.copyAnalyticsEventKey}
- />
- )}
-
-
-
- {card.isLoading ? (
-
-
- ) : (
-
- {card.insightElement}
- {card.insight && (
- {
- // Stop propagation if the click is directly on a link
- if ((e.target as HTMLElement).tagName === 'A') {
- e.stopPropagation();
- }
- }}
- text={
- card.isLoading
- ? card.insight.replace(/\*\*/g, '')
- : card.insight
- }
- />
- )}
-
- )}
-
-
-
- );
- })}
-
-
-
- );
-}
-
-const InsightCardButton = styled(motion.div)`
- border-radius: ${p => p.theme.radius.md};
- border: 1px solid ${p => p.theme.tokens.border.primary};
- width: 100%;
- min-height: 0;
- position: relative;
- overflow: hidden;
- cursor: pointer;
- padding: 0;
- box-shadow: ${p => p.theme.shadow.low};
- background-color: ${p => p.theme.tokens.background.primary};
-
- &:hover {
- background-color: ${p =>
- p.theme.tokens.interactive.transparent.neutral.background.hover};
- }
-`;
-
-const InsightGrid = styled('div')`
- display: flex;
- flex-direction: column;
- gap: ${p => p.theme.space.lg};
- position: relative;
-
- &:before {
- content: '';
- position: absolute;
- left: ${p => p.theme.space['2xl']};
- top: ${p => p.theme.space['3xl']};
- bottom: ${p => p.theme.space.xl};
- width: 1px;
- /* eslint-disable-next-line @sentry/scraps/use-semantic-token */
- background: ${p => p.theme.tokens.border.primary};
- z-index: 0;
- }
-`;
-
-const CardTitle = styled('div')<{preview?: boolean}>`
- display: flex;
- align-items: center;
- gap: ${p => p.theme.space.md};
- color: ${p => p.theme.tokens.content.primary};
- padding: ${p => p.theme.space.xs} ${p => p.theme.space.xs} 0 ${p => p.theme.space.md};
- justify-content: space-between;
-`;
-
-const CardTitleText = styled('p')`
- margin: 0;
- font-size: ${p => p.theme.font.size.md};
- font-weight: ${p => p.theme.font.weight.sans.medium};
- margin-top: 1px;
-`;
-
-const CardTitleIcon = styled('div')`
- display: flex;
- align-items: center;
- color: ${p => p.theme.tokens.content.primary};
-`;
-
-const CardContent = styled('div')`
- overflow-wrap: break-word;
- word-break: break-word;
- padding: ${p => p.theme.space.xs} ${p => p.theme.space.md} ${p => p.theme.space.md}
- ${p => p.theme.space.md};
- text-align: left;
- flex: 1;
-
- p {
- margin: 0;
- white-space: pre-wrap;
- }
-
- code {
- word-break: break-all;
- }
-
- a {
- color: ${p => p.theme.tokens.interactive.link.accent.rest};
- text-decoration: none;
-
- &:hover {
- text-decoration: underline;
- }
- }
-`;
diff --git a/static/app/components/modals/dataWidgetViewerModal.tsx b/static/app/components/modals/dataWidgetViewerModal.tsx
index 41079fcb99f423..520f6ab2681198 100644
--- a/static/app/components/modals/dataWidgetViewerModal.tsx
+++ b/static/app/components/modals/dataWidgetViewerModal.tsx
@@ -11,7 +11,7 @@ import moment from 'moment-timezone';
import {Alert} from '@sentry/scraps/alert';
import {Button, LinkButton} from '@sentry/scraps/button';
-import {Flex, Grid, Stack, Container} from '@sentry/scraps/layout';
+import {Container, Flex, Grid, Stack} from '@sentry/scraps/layout';
import {Pagination} from '@sentry/scraps/pagination';
import {Select, SelectOption} from '@sentry/scraps/select';
import {Tooltip} from '@sentry/scraps/tooltip';
@@ -79,7 +79,6 @@ import {
dashboardFiltersToString,
eventViewFromWidget,
getFieldsFromEquations,
- getNumEquations,
getWidgetDiscoverUrl,
getWidgetIssueUrl,
getWidgetReleasesUrl,
@@ -306,7 +305,6 @@ function DataWidgetViewerModal(props: Props) {
};
const {aggregates, columns} = tableWidget.queries[0]!;
const {orderby} = widget.queries[0]!;
- const order = orderby.startsWith('-');
const rawOrderby = trimStart(orderby, '-');
const fields =
@@ -342,14 +340,6 @@ function DataWidgetViewerModal(props: Props) {
}
}
- // Need to set the orderby of the eventsv2 query to equation[index] format
- // since eventsv2 does not accept the raw equation as a valid sort payload
- if (isEquation(rawOrderby) && tableWidget.queries[0]!.orderby === orderby) {
- tableWidget.queries[0]!.orderby = `${order ? '-' : ''}equation[${
- getNumEquations(fields) - 1
- }]`;
- }
-
// Default table columns for visualizations that don't have a group by set
const hasGroupBy = (widget.queries[0]?.columns.length ?? 0) > 0;
const shouldReplaceTableColumns =
@@ -1075,8 +1065,8 @@ function ViewerTableV2({
datasetConfig?.getFieldHeaderMap?.(tableWidget.queries[selectedQueryIndex]) ?? {}
);
- // Inject any prettified function names that aren't currently aliased into the aliases
for (const column of tableColumns) {
+ // Inject any prettified function names that aren't currently aliased into the aliases
const parsedFunction = parseFunction(column.key);
if (!aliases[column.key] && parsedFunction) {
aliases[column.key] = prettifyParsedFunction(parsedFunction);
diff --git a/static/app/components/pageFilters/actions.tsx b/static/app/components/pageFilters/actions.tsx
index a9e1f369f6409c..efb3d77fdc482c 100644
--- a/static/app/components/pageFilters/actions.tsx
+++ b/static/app/components/pageFilters/actions.tsx
@@ -110,6 +110,10 @@ export type InitializeUrlStateParams = {
organization: Organization;
defaultSelection?: Partialbold
\n'); - expect(sanitizedMarkedNoHeadings('`code`')).toBe('code
foo
\n'); diff --git a/static/app/utils/marked/marked.tsx b/static/app/utils/marked/marked.tsx index 218d447046198b..00f3522dcd4de1 100644 --- a/static/app/utils/marked/marked.tsx +++ b/static/app/utils/marked/marked.tsx @@ -43,13 +43,6 @@ class SafeRenderer extends marked.Renderer { } } -class NoHeadingRenderer extends SafeRenderer { - heading(tokens: Tokens.Heading) { - // Render headings as bold text instead of h1-h6 elements - return super.strong({...tokens, type: 'strong'}); - } -} - class NoParagraphRenderer extends SafeRenderer { paragraph(tokens: Tokens.Paragraph) { // Do not render the paragraph but still render sub-tokens @@ -178,17 +171,6 @@ export const sanitizedMarked = (src: string): string => { return noHighlightingMarked.parse(src, {async: false}); }; -/** - * Renders markdown without any heading tags applied. - * WARNING: Does not apply any syntax highlighting. - */ -export const sanitizedMarkedNoHeadings = (src: string): string => { - return noHighlightingMarked.parse(src, { - async: false, - renderer: new NoHeadingRenderer(), - }); -}; - /** * Renders a single line of markdown not wrapped in a paragraph tag. * WARNING: Does not apply any syntax highlighting. diff --git a/static/app/utils/theme/theme.tsx b/static/app/utils/theme/theme.tsx index 936707fe074d86..960548ef21a727 100644 --- a/static/app/utils/theme/theme.tsx +++ b/static/app/utils/theme/theme.tsx @@ -196,7 +196,6 @@ const commonTheme = { truncationFullValue: 10, header: 1000, - dropdown: 1001, // dashboard widget builder backdrop sits behind the sidebar // because it renders on the right next to the sidebar @@ -204,6 +203,7 @@ const commonTheme = { widgetBuilderDrawer: 1016, sidebarPanel: 1019, + dropdown: 1020, sidebar: 1020, // Sentry user feedback modal diff --git a/static/app/utils/useChartInterval.spec.tsx b/static/app/utils/useChartInterval.spec.tsx index 4d84c6de26f188..2849ac53aa2268 100644 --- a/static/app/utils/useChartInterval.spec.tsx +++ b/static/app/utils/useChartInterval.spec.tsx @@ -3,7 +3,11 @@ import {act, render} from 'sentry-test/reactTestingLibrary'; import {PageFiltersStore} from 'sentry/components/pageFilters/store'; import {parsePeriodToHours} from 'sentry/utils/duration/parsePeriodToHours'; -import {getIntervalOptionsForPageFilter, useChartInterval} from './useChartInterval'; +import { + ChartIntervalUnspecifiedStrategy, + getIntervalOptionsForPageFilter, + useChartInterval, +} from './useChartInterval'; describe('useChartInterval', () => { beforeEach(() => { @@ -53,6 +57,83 @@ describe('useChartInterval', () => { }); expect(chartInterval).toBe('5m'); }); + + it('defaults to the smallest interval with USE_SMALLEST strategy', () => { + // Default 14d period produces ladder-derived options ['1h', '3h', '6h'] + let chartInterval!: ReturnType
+ {filteredParams.map(param => {
+ let rawXValue: number | undefined;
+ let rawYValue: number | undefined;
+
+ let formattedYValue = ECHARTS_MISSING_DATA_VALUE;
+ let formattedZValue = ECHARTS_MISSING_DATA_VALUE;
+ if (Array.isArray(param.value) && param.value.length === 3) {
+ const [xValue, yValue, zValue] = param.value;
+
+ if (defined(xValue) && typeof xValue === 'number') {
+ rawXValue = xValue;
+ // bucket size seems to be in seconds but we need to convert to milliseconds
+ formattedXValue = defaultFormatAxisLabel(
+ xValue,
+ true,
+ utc ?? false,
+ true,
+ false,
+ xAxisBucketSize * 1000
+ ).toString();
+ }
+
+ if (defined(yValue) && typeof yValue === 'number') {
+ rawYValue = yValue;
+ const yAxisMinValueFormatted = formatTooltipValue(
+ yValue,
+ yAxisValueType,
+ yAxisUnit ?? undefined
+ );
+
+ if (yAxisBucketSize === 0) {
+ formattedYValue = yAxisMinValueFormatted;
+ } else {
+ const yAxisMaxValueFormatted = formatTooltipValue(
+ yValue + yAxisBucketSize,
+ yAxisValueType,
+ yAxisUnit ?? undefined
+ );
+
+ formattedYValue = `${yAxisMinValueFormatted} – ${yAxisMaxValueFormatted}`;
+ }
+ }
+
+ if (defined(zValue) && typeof zValue === 'number') {
+ formattedZValue = formatAbbreviatedNumber(zValue, 4, false);
+ }
+ }
+
+ let exploreLink: ReactNode;
+
+ if (defined(rawXValue) && defined(rawYValue) && props.tooltipExploreUrlArgs) {
+ const xAxisMaxValue = rawXValue + xAxisBucketSize * 1000;
+ const yAxisMaxValue = rawYValue + yAxisBucketSize;
+
+ const exploreUrlProps: GetExploreUrlArgs = {
+ organization,
+ ...props.tooltipExploreUrlArgs,
+ selection: {
+ ...pageFilters.selection,
+ datetime: {
+ ...pageFilters.selection.datetime,
+ start: new Date(rawXValue),
+ end: new Date(xAxisMaxValue),
+ period: null,
+ },
+ },
+ // TODO(nikki): we're only handling metrics for now but if we're looking to support other explore
+ // surfaces then we'll need to add more logic here
+ crossEvents: props.tooltipExploreUrlArgs?.crossEvents?.map(crossEvent => {
+ if (crossEvent.type === 'metrics') {
+ return {
+ ...crossEvent,
+ query:
+ yAxisBucketSize === 0
+ ? `value:<=${rawYValue}`
+ : `value:>=${rawYValue} value:<${yAxisMaxValue}`,
+ };
+ }
+ return crossEvent;
+ }),
+ };
+
+ const tracesLink = getExploreUrl(exploreUrlProps);
+ exploreLink = {t('View related traces')};
+ }
+
+ return (
+
+
+ );
+ })}
+
+
+
+ {formattedYValue}
+ {' '}
+ {formattedZValue}
+
+ {exploreLink && (
+
+
+ {exploreLink}
+
+
+ )}
+ {formattedXValue}
+
+
-
-
-
-
+
+
+
+
+ {hasCrossEvents && hasAbsoluteDateSelection ? (
+
{hasCrossEvents ? null : (
diff --git a/static/app/views/issueDetails/actions/seerCommandPaletteActions.tsx b/static/app/views/issueDetails/actions/seerCommandPaletteActions.tsx
index 6f7e750086b0f2..042fc46e6973f0 100644
--- a/static/app/views/issueDetails/actions/seerCommandPaletteActions.tsx
+++ b/static/app/views/issueDetails/actions/seerCommandPaletteActions.tsx
@@ -29,12 +29,11 @@ import {useOpenSeerDrawer} from 'sentry/views/issueDetails/streamline/sidebar/se
function useSeerState(group: Group, project: Project) {
const organization = useOrganization();
const aiConfig = useAiConfig(group, project);
- const isExplorer = organization.features.includes('autofix-on-explorer');
const issueTypeConfig = getConfigForIssueType(group, project);
const issueTypeSupportsSeer = issueTypeConfig.autofix || issueTypeConfig.issueSummary;
const autofix = useExplorerAutofix(group.id, {
- enabled: aiConfig.areAiFeaturesAllowed && isExplorer,
+ enabled: aiConfig.areAiFeaturesAllowed,
});
const sections = useMemo(
@@ -56,7 +55,6 @@ function useSeerState(group: Group, project: Project) {
return {
organization,
aiConfig,
- isExplorer,
issueTypeSupportsSeer,
autofix,
completedRootCause,
@@ -80,7 +78,6 @@ export function SeerCommandPaletteActions({
const {
organization,
aiConfig,
- isExplorer,
issueTypeSupportsSeer,
autofix,
completedRootCause,
@@ -96,7 +93,7 @@ export function SeerCommandPaletteActions({
);
const codingAgentIntegrations = codingAgentResponse?.integrations;
- if (!aiConfig.areAiFeaturesAllowed || !isExplorer || !issueTypeSupportsSeer || !event) {
+ if (!aiConfig.areAiFeaturesAllowed || !issueTypeSupportsSeer || !event) {
return null;
}
diff --git a/static/app/views/issueDetails/streamline/eventNavigation.tsx b/static/app/views/issueDetails/streamline/eventNavigation.tsx
index cd49eb2447cdf1..601e6e159ff7b3 100644
--- a/static/app/views/issueDetails/streamline/eventNavigation.tsx
+++ b/static/app/views/issueDetails/streamline/eventNavigation.tsx
@@ -12,7 +12,7 @@ import {CopyAsDropdown} from 'sentry/components/copyAsDropdown';
import {Count} from 'sentry/components/count';
import {DropdownButton} from 'sentry/components/dropdownButton';
import {DropdownMenu} from 'sentry/components/dropdownMenu';
-import {useAutofixData} from 'sentry/components/events/autofix/useAutofix';
+import {useExplorerAutofix} from 'sentry/components/events/autofix/useExplorerAutofix';
import {useGroupSummaryData} from 'sentry/components/group/groupSummary';
import {TourElement} from 'sentry/components/tours/components';
import {IconTelescope} from 'sentry/icons';
@@ -117,7 +117,7 @@ export function IssueEventNavigation({event, group}: IssueEventNavigationProps)
// Get data for markdown copy functionality
const {data: groupSummaryData} = useGroupSummaryData(group);
- const {data: autofixData} = useAutofixData({groupId: group.id});
+ const {runState: autofixData} = useExplorerAutofix(group.id, {enabled: false});
const handleCopyMarkdown = useCallback(() => {
const markdownText = issueAndEventToMarkdown(
diff --git a/static/app/views/issueDetails/streamline/hooks/useCopyIssueDetails.spec.tsx b/static/app/views/issueDetails/streamline/hooks/useCopyIssueDetails.spec.tsx
index 2bd3d13b7a0a16..dc7e69d152585a 100644
--- a/static/app/views/issueDetails/streamline/hooks/useCopyIssueDetails.spec.tsx
+++ b/static/app/views/issueDetails/streamline/hooks/useCopyIssueDetails.spec.tsx
@@ -5,12 +5,8 @@ import {OrganizationFixture} from 'sentry-fixture/organization';
import {renderHook, userEvent} from 'sentry-test/reactTestingLibrary';
import * as indicators from 'sentry/actionCreators/indicator';
-import {
- AutofixStatus,
- AutofixStepType,
- type AutofixData,
-} from 'sentry/components/events/autofix/types';
-import * as autofixHooks from 'sentry/components/events/autofix/useAutofix';
+import type {ExplorerAutofixState} from 'sentry/components/events/autofix/useExplorerAutofix';
+import * as explorerAutofixHooks from 'sentry/components/events/autofix/useExplorerAutofix';
import type {GroupSummaryData} from 'sentry/components/group/groupSummary';
import * as groupSummaryHooks from 'sentry/components/group/groupSummary';
import {EntryType} from 'sentry/types/event';
@@ -39,46 +35,50 @@ describe('useCopyIssueDetails', () => {
possibleCause: 'Missing parameter',
};
- // Create a mock AutofixData with steps that includes root cause and solution steps
- const mockAutofixData: AutofixData = {
- last_triggered_at: '2023-01-01T00:00:00Z',
- request: {
- repos: [],
- },
- codebases: {},
- run_id: '123',
- status: AutofixStatus.COMPLETED,
- steps: [
+ const mockAutofixData: ExplorerAutofixState = {
+ run_id: 123,
+ status: 'completed',
+ updated_at: '2023-01-01T00:00:00Z',
+ blocks: [
{
- id: 'root-cause-step',
- index: 0,
- progress: [],
- status: AutofixStatus.COMPLETED,
- title: 'Root Cause',
- type: AutofixStepType.ROOT_CAUSE_ANALYSIS,
- causes: [
+ id: 'root-cause-block',
+ message: {
+ role: 'assistant' as const,
+ content: 'Found the root cause',
+ metadata: {step: 'root_cause'},
+ },
+ timestamp: '2023-01-01T00:00:00Z',
+ loading: false,
+ artifacts: [
{
- id: 'cause-1',
- description: 'Root cause text',
+ key: 'root_cause',
+ reason: 'Root cause analysis',
+ data: {
+ one_line_description: 'Root cause text',
+ five_whys: ['Why 1'],
+ },
},
],
- selection: null,
},
{
- id: 'solution-step',
- index: 1,
- progress: [],
- status: AutofixStatus.COMPLETED,
- title: 'Solution',
- type: AutofixStepType.SOLUTION,
- solution: [
+ id: 'solution-block',
+ message: {
+ role: 'assistant' as const,
+ content: 'Here is the solution',
+ metadata: {step: 'solution'},
+ },
+ timestamp: '2023-01-01T00:00:01Z',
+ loading: false,
+ artifacts: [
{
- timeline_item_type: 'internal_code',
- title: 'Solution title',
- code_snippet_and_analysis: 'Solution text',
+ key: 'solution',
+ reason: 'Solution plan',
+ data: {
+ one_line_summary: 'Solution title',
+ steps: [{title: 'Fix it', description: 'Solution text'}],
+ },
},
],
- solution_selected: true,
},
],
};
@@ -124,7 +124,7 @@ describe('useCopyIssueDetails', () => {
);
expect(result).toContain('## Root Cause');
- expect(result).toContain('## Solution');
+ expect(result).toContain('## Plan');
});
it('includes tags when present in event', () => {
@@ -379,10 +379,17 @@ describe('useCopyIssueDetails', () => {
isPending: false,
});
- jest.spyOn(autofixHooks, 'useAutofixData').mockReturnValue({
- data: mockAutofixData,
- isPending: false,
- });
+ jest.spyOn(explorerAutofixHooks, 'useExplorerAutofix').mockReturnValue({
+ runState: mockAutofixData,
+ isLoading: false,
+ isPolling: false,
+ startStep: jest.fn(),
+ createPR: jest.fn(),
+ reset: jest.fn(),
+ triggerCodingAgentHandoff: jest.fn(),
+ codingAgentErrors: [],
+ dismissCodingAgentError: jest.fn(),
+ } as any);
jest.spyOn(indicators, 'addSuccessMessage').mockImplementation(() => {});
jest.spyOn(indicators, 'addErrorMessage').mockImplementation(() => {});
@@ -430,7 +437,7 @@ describe('useCopyIssueDetails', () => {
expect(capturedText).toContain(`**Project:** ${group.project?.slug}`);
expect(capturedText).toContain('## Issue Summary');
expect(capturedText).toContain('## Root Cause');
- expect(capturedText).toContain('## Solution');
+ expect(capturedText).toContain('## Plan');
expect(capturedText).not.toContain('## Exception');
});
diff --git a/static/app/views/issueDetails/streamline/hooks/useCopyIssueDetails.tsx b/static/app/views/issueDetails/streamline/hooks/useCopyIssueDetails.tsx
index b2f42716b88ab6..bb636df57906cc 100644
--- a/static/app/views/issueDetails/streamline/hooks/useCopyIssueDetails.tsx
+++ b/static/app/views/issueDetails/streamline/hooks/useCopyIssueDetails.tsx
@@ -2,12 +2,15 @@ import {useCallback, useMemo, useSyncExternalStore} from 'react';
import {useHotkeys} from '@sentry/scraps/hotkey';
-import type {AutofixData} from 'sentry/components/events/autofix/types';
-import {useAutofixData} from 'sentry/components/events/autofix/useAutofix';
import {
- getRootCauseCopyText,
- getSolutionCopyText,
-} from 'sentry/components/events/autofix/utils';
+ type ExplorerAutofixState,
+ getAutofixArtifactFromSection,
+ getOrderedAutofixSections,
+ isRootCauseSection,
+ isSolutionSection,
+ useExplorerAutofix,
+} from 'sentry/components/events/autofix/useExplorerAutofix';
+import {artifactToMarkdown} from 'sentry/components/events/autofix/v3/utils';
import {
useGroupSummaryData,
type GroupSummaryData,
@@ -79,10 +82,7 @@ function formatStacktraceToMarkdown(stacktrace: StacktraceType): string {
return markdownText;
}
-export function formatEventToMarkdown(
- event: Event,
- activeThreadId: number | undefined
-): string {
+function formatEventToMarkdown(event: Event, activeThreadId: number | undefined): string {
let markdownText = '';
// Add tags
@@ -145,7 +145,7 @@ export const issueAndEventToMarkdown = (
group: Group,
event: Event | null | undefined,
groupSummaryData: GroupSummaryData | null | undefined,
- autofixData: AutofixData | null | undefined,
+ autofixData: ExplorerAutofixState | null | undefined,
activeThreadId: number | undefined
): string => {
// Format the basic issue information
@@ -172,14 +172,29 @@ export const issueAndEventToMarkdown = (
}
if (autofixData) {
- const rootCauseCopyText = getRootCauseCopyText(autofixData);
- const solutionCopyText = getSolutionCopyText(autofixData);
+ const sections = getOrderedAutofixSections(autofixData);
+ const rootCauseSection = sections.find(isRootCauseSection);
+ const solutionSection = sections.find(isSolutionSection);
+
+ const rootCauseArtifact = rootCauseSection
+ ? getAutofixArtifactFromSection(rootCauseSection)
+ : null;
+ const solutionArtifact = solutionSection
+ ? getAutofixArtifactFromSection(solutionSection)
+ : null;
+
+ const rootCauseCopyText = rootCauseArtifact
+ ? artifactToMarkdown(rootCauseArtifact, 2)
+ : null;
+ const solutionCopyText = solutionArtifact
+ ? artifactToMarkdown(solutionArtifact, 2)
+ : null;
if (rootCauseCopyText) {
- markdownText += `\n## Root Cause\n\`\`\`\n${rootCauseCopyText}\n\`\`\`\n`;
+ markdownText += `\n${rootCauseCopyText}\n`;
}
if (solutionCopyText) {
- markdownText += `\n## Solution\n\`\`\`\n${solutionCopyText}\n\`\`\`\n`;
+ markdownText += `\n${solutionCopyText}\n`;
}
}
@@ -193,9 +208,8 @@ export const issueAndEventToMarkdown = (
export const useCopyIssueDetails = (group: Group, event?: Event) => {
const organization = useOrganization();
- // These aren't guarded by useAiConfig because they are both non fetching, and should only return data when it's fetched elsewhere.
const {data: groupSummaryData} = useGroupSummaryData(group);
- const {data: autofixData} = useAutofixData({groupId: group.id});
+ const {runState: autofixData} = useExplorerAutofix(group.id, {enabled: false});
const activeThreadId = useActiveThreadId();
const text = useMemo(() => {
diff --git a/static/app/views/issueDetails/streamline/sidebar/seerDrawer.spec.tsx b/static/app/views/issueDetails/streamline/sidebar/seerDrawer.spec.tsx
index f1fc39993bf4d6..ba934a29da9bbe 100644
--- a/static/app/views/issueDetails/streamline/sidebar/seerDrawer.spec.tsx
+++ b/static/app/views/issueDetails/streamline/sidebar/seerDrawer.spec.tsx
@@ -1,8 +1,4 @@
-import {AutofixDataFixture} from 'sentry-fixture/autofixData';
import {AutofixSetupFixture} from 'sentry-fixture/autofixSetupFixture';
-import {AutofixStepFixture} from 'sentry-fixture/autofixStep';
-import {EventFixture} from 'sentry-fixture/event';
-import {FrameFixture} from 'sentry-fixture/frame';
import {GroupFixture} from 'sentry-fixture/group';
import {OrganizationFixture} from 'sentry-fixture/organization';
import {DetailedProjectFixture} from 'sentry-fixture/project';
@@ -15,92 +11,60 @@ import {
waitForElementToBeRemoved,
} from 'sentry-test/reactTestingLibrary';
-import {EntryType} from 'sentry/types/event';
import {SeerDrawer} from 'sentry/views/issueDetails/streamline/sidebar/seerDrawer';
+function makeExplorerBlock({
+ id = 'block-1',
+ content = 'Analysis content',
+ step,
+ loading = false,
+ artifacts,
+}: {
+ artifacts?: Array<{data: Record; key: string; reason: string}>;
+ content?: string;
+ id?: string;
+ loading?: boolean;
+ step?: string;
+} = {}) {
+ return {
+ id,
+ message: {
+ role: 'assistant' as const,
+ content,
+ metadata: step ? {step} : null,
+ },
+ timestamp: '2024-01-01T00:00:00Z',
+ loading,
+ artifacts: artifacts ?? [],
+ };
+}
+
+function makeExplorerAutofixData({
+ blocks = [makeExplorerBlock()],
+ status = 'completed' as const,
+ run_id = 1,
+}: {
+ blocks?: Array>;
+ run_id?: number;
+ status?: 'processing' | 'completed' | 'error' | 'awaiting_user_input';
+} = {}) {
+ return {
+ run_id,
+ blocks,
+ status,
+ updated_at: '2024-01-01T00:00:00Z',
+ };
+}
+
describe('SeerDrawer', () => {
const organization = OrganizationFixture({
hideAiFeatures: false,
features: ['gen-ai-features'],
});
- const mockEvent = EventFixture({
- entries: [
- {
- type: EntryType.EXCEPTION,
- data: {values: [{stacktrace: {frames: [FrameFixture()]}}]},
- },
- ],
- });
const mockGroup = GroupFixture();
const mockProject = DetailedProjectFixture();
- const mockAutofixData = AutofixDataFixture({steps: [AutofixStepFixture()]});
-
- // Create autofix data with various repository configurations for testing notices
- const mockAutofixWithReadableRepos = AutofixDataFixture({
- steps: [AutofixStepFixture()],
- request: {
- repos: [
- {
- name: 'org/repo',
- provider: 'github',
- owner: 'org',
- external_id: 'repo-123',
- },
- ],
- },
- codebases: {
- 'repo-123': {
- repo_external_id: 'repo-123',
- is_readable: true,
- is_writeable: true,
- },
- },
- });
-
- const mockAutofixWithUnreadableGithubRepos = AutofixDataFixture({
- steps: [AutofixStepFixture()],
- request: {
- repos: [
- {
- name: 'org/repo',
- provider: 'github',
- owner: 'org',
- external_id: 'repo-123',
- },
- ],
- },
- codebases: {
- 'repo-123': {
- repo_external_id: 'repo-123',
- is_readable: false,
- is_writeable: false,
- },
- },
- });
-
- const mockAutofixWithUnreadableNonGithubRepos = AutofixDataFixture({
- steps: [AutofixStepFixture()],
- request: {
- repos: [
- {
- name: 'org/gitlab-repo',
- provider: 'gitlab',
- owner: 'org',
- external_id: 'repo-123',
- },
- ],
- },
- codebases: {
- 'repo-123': {
- repo_external_id: 'repo-123',
- is_readable: false,
- is_writeable: false,
- },
- },
- });
-
beforeEach(() => {
MockApiClient.clearMockResponses();
localStorage.clear();
@@ -112,16 +76,6 @@ describe('SeerDrawer', () => {
githubWriteIntegration: {ok: true, repos: []},
}),
});
- MockApiClient.addMockResponse({
- url: `/organizations/${mockProject.organization.slug}/issues/${mockGroup.id}/summarize/`,
- method: 'POST',
- body: {
- whatsWrong: 'Test whats wrong',
- trace: 'Test trace',
- possibleCause: 'Test possible cause',
- headline: 'Test headline',
- },
- });
MockApiClient.addMockResponse({
url: `/projects/${mockProject.organization.slug}/${mockProject.slug}/seer/preferences/`,
body: {
@@ -164,51 +118,13 @@ describe('SeerDrawer', () => {
});
});
- it('renders issue summary if consent flow is removed and there is no autofix quota', async () => {
- const orgWithConsentFlowRemoved = OrganizationFixture({
- hideAiFeatures: false,
- features: ['seer-billing', 'gen-ai-features'],
- });
- MockApiClient.addMockResponse({
- url: `/organizations/${mockProject.organization.slug}/issues/${mockGroup.id}/autofix/setup/`,
- body: AutofixSetupFixture({
- integration: {ok: false, reason: null},
- githubWriteIntegration: {ok: false, repos: []},
- billing: {hasAutofixQuota: false},
- }),
- });
+ it('renders loading state while autofix setup is pending', async () => {
MockApiClient.addMockResponse({
url: `/organizations/${mockProject.organization.slug}/issues/${mockGroup.id}/autofix/`,
body: {autofix: null},
});
- render(>) {
- const {currentStep, setCurrentStep, totalSteps} = useGuidedStepsContext();
-
- if (currentStep >= totalSteps) {
- return null;
- }
-
- const handleSkip = () => {
- setCurrentStep(currentStep + 1);
- };
-
- return (
-
- );
-}
-
-function CustomStepButtons({
- showBack,
- showNext,
- showSkip,
- onSkip,
- children,
-}: {
- showBack: boolean;
- showNext: boolean;
- showSkip: boolean;
- children?: React.ReactNode;
- onSkip?: () => void;
-}) {
- return (
-
- {showBack &&
- );
-}
-
-export function SeerNotices({groupId, hasGithubIntegration, project}: SeerNoticesProps) {
- const organization = useOrganization();
- const {repos} = useAutofixRepos(groupId);
- const {data, isLoading: isLoadingPreferences} = useProjectSeerPreferences(project);
- const {preference, code_mapping_repos: codeMappingRepos} = data ?? {};
- const {mutate: updateProjectSeerPreferences} = useUpdateProjectSeerPreferences(project);
- const {mutateAsync: updateProjectAutomation} = useUpdateProject(project);
- const {data: codingAgentIntegrations} = useQuery(
- organizationIntegrationsCodingAgents(organization)
- );
- const {starredViews: views} = useStarredIssueViews();
-
- const {data: projectDetails, isPending: isLoadingProject} = useDetailedProject({
- orgSlug: organization.slug,
- projectSlug: project.slug,
- });
-
- const hasIssueViews = useHasIssueViews();
- const isStarredViewAllowed = hasIssueViews;
-
- const cursorIntegration = codingAgentIntegrations?.integrations.find(
- integration => integration.provider === 'cursor'
- );
- const isCursorHandoffConfigured = Boolean(preference?.automation_handoff);
-
- const unreadableRepos = repos.filter(repo => repo.is_readable === false);
- const githubRepos = unreadableRepos.filter(repo => repo.provider.includes('github'));
- const nonGithubRepos = unreadableRepos.filter(
- repo => !repo.provider.includes('github')
- );
-
- // Onboarding conditions
- const needsGithubIntegration = !hasGithubIntegration;
- const needsRepoSelection =
- repos.length === 0 && !preference?.repositories?.length && !codeMappingRepos?.length;
- const needsAutomation =
- projectDetails !== undefined &&
- (projectDetails.autofixAutomationTuning === 'off' ||
- projectDetails.autofixAutomationTuning === undefined ||
- projectDetails.seerScannerAutomation === false);
- const needsFixabilityView =
- !views.some(view => view.query.includes(FieldKey.ISSUE_SEER_ACTIONABILITY)) &&
- isStarredViewAllowed;
-
- // Warning conditions
- const hasMultipleUnreadableRepos = unreadableRepos.length > 1;
- const hasSingleUnreadableRepo = unreadableRepos.length === 1;
-
- // Use localStorage for collapsed state and cursor step skip
- const [stepsCollapsed, setStepsCollapsed] = useLocalStorageState(
- `seer-onboarding-collapsed:${project.id}`,
- false
- );
- const [cursorStepSkipped, setCursorStepSkipped] = useLocalStorageState(
- `seer-onboarding-cursor-skipped:${project.id}`,
- false
- );
-
- const needsCursorIntegration =
- (!isCursorHandoffConfigured || !cursorIntegration) && !cursorStepSkipped;
-
- // Calculate incomplete steps
- const stepConditions = [
- needsGithubIntegration,
- needsRepoSelection,
- needsAutomation,
- needsFixabilityView,
- needsCursorIntegration,
- ];
-
- const handleSetupCursorHandoff = async () => {
- if (!cursorIntegration?.id || !projectDetails) {
- return;
- }
-
- const isAutomationDisabled =
- projectDetails.seerScannerAutomation === false ||
- projectDetails.autofixAutomationTuning === 'off';
-
- if (isAutomationDisabled) {
- await updateProjectAutomation({
- autofixAutomationTuning: 'low',
- seerScannerAutomation: true,
- });
- }
-
- updateProjectSeerPreferences({
- repositories: preference?.repositories || [],
- automated_run_stopping_point: 'root_cause',
- automation_handoff: {
- handoff_point: 'root_cause',
- target: CodingAgentProvider.CURSOR_BACKGROUND_AGENT,
- integration_id: parseInt(cursorIntegration.id, 10),
- },
- });
- };
-
- const handleSkipCursorStep = useCallback(() => {
- setCursorStepSkipped(true);
- setStepsCollapsed(true);
- }, [setCursorStepSkipped, setStepsCollapsed]);
- const incompleteStepIndices = stepConditions
- .map((needed, idx) => (needed ? idx : null))
- .filter(idx => idx !== null);
- const firstIncompleteIdx = incompleteStepIndices[0];
- const lastIncompleteIdx = incompleteStepIndices[incompleteStepIndices.length - 1];
- const anyStepIncomplete = incompleteStepIndices.length > 0;
- const showOnboardingSteps =
- !isLoadingPreferences && !isLoadingProject && anyStepIncomplete;
- const showCollapsedSummary = showOnboardingSteps && stepsCollapsed;
- const showFullGuidedSteps = showOnboardingSteps && !stepsCollapsed;
-
- return (
-
- {/* Collapsed summary */}
- {showCollapsedSummary && (
- setStepsCollapsed(false)}>
-
- )}
- {/* Full guided steps */}
- {showFullGuidedSteps && (
-
-
-
-
-
- {/* Step 1: GitHub Integration */}
-
-
-
-
-
- {tct(
- 'Seer is [bold:a lot better] when it has your codebase as context.',
- {
- bold: ,
- }
- )}
-
-
- {tct(
- 'Set up the [integrationLink:GitHub Integration] to allow Seer to find the most accurate root causes, solutions, and code changes for your issues.',
- {
- integrationLink: (
-
-
-
-
-
-
-
- {t('Set Up Integration')}
-
-
-
-
- {/* Step 2: Repo Selection */}
-
-
-
-
-
- {t('Select the repos Seer can explore in this project.')}
-
-
- {t(
- 'You can also configure working branches and custom instructions so Seer fits your unique workflow.'
- )}
-
-
-
-
-
-
- setStepsCollapsed(true)}
- >
-
- {t('Configure Repos')}
-
-
-
-
- {/* Step 3: Unleash Automation */}
-
-
-
-
-
- {t(
- 'Let Seer automatically deep dive into incoming issues, so you wake up to solutions, not headaches.'
- )}
-
-
-
-
-
-
- setStepsCollapsed(true)}
- >
-
- {t('Enable Automation')}
-
-
-
-
- {/* Step 4: Fixability View */}
- {isStarredViewAllowed && (
-
-
-
-
-
- {t(
- 'Seer scans all your issues and highlights the ones that are likely quick to fix.'
- )}
-
-
- {t(
- 'Star the recommended issue view to keep an eye on quick debugging opportunities. You can customize the view later.'
- )}
-
-
-
-
-
-
- setStepsCollapsed(true)}
- >
-
-
- )}
-
- {/* Step 5: Cursor Integration */}
-
-
-
- {t('Hand Off to Cursor Cloud Agents')}
-
- }
- isCompleted={!needsCursorIntegration}
- >
-
-
-
- {cursorIntegration ? (
-
-
- {t(
- 'Enable Seer automation and set up handoff to Cursor Cloud Agents when Seer identifies a root cause.'
- )}
-
-
- {tct(
- 'During automation, Seer will trigger Cursor Cloud Agents to generate and submit pull requests directly to your repos. Configure in [seerProjectSettings:Seer project settings] or [docsLink:read the docs] to learn more.',
- {
- seerProjectSettings: (
-
- ),
- docsLink: (
-
- ) : (
-
-
- {t(
- 'Connect Cursor to automatically hand off Seer root cause analysis to Cursor Cloud Agents for seamless code fixes.'
- )}
-
-
- {tct(
- 'Set up the [integrationLink:Cursor Integration] to enable automatic handoff. [docsLink:Read the docs] to learn more.',
- {
- integrationLink: (
-
- ),
- docsLink: (
-
- )}
-
-
-
-
-
-
- {cursorIntegration ? (
-
- ) : (
-
- {t('Install Cursor Integration')}
-
- )}
-
-
-
-
-
- )}
- {/* Banners for unreadable repos */}
- {hasMultipleUnreadableRepos && (
-
- {tct("Seer can't access these repositories: [repoList].", {
- repoList: {unreadableRepos.map(repo => repo.name).join(', ')},
- })}
- {githubRepos.length > 0 && (
-
- {' '}
- {tct(
- 'For best performance, enable the [integrationLink:GitHub integration].',
- {
- integrationLink: (
-
- )}
- {nonGithubRepos.length > 0 && (
- {t('Seer currently only supports GitHub repositories.')}
- )}
-
- )}
- {hasSingleUnreadableRepo && (
-
- {unreadableRepos[0]?.provider.includes('github')
- ? tct(
- "Seer can't access the [repo] repository, make sure the [integrationLink:GitHub integration] is correctly set up.",
- {
- repo: {unreadableRepos[0]?.name},
- integrationLink: (
-
- )}
-
- );
-}
-
-const StyledGuidedSteps = styled(GuidedSteps)`
- background: transparent;
-`;
-
-const StyledAlert = styled(Alert)`
- margin-bottom: ${p => p.theme.space.xl};
-`;
-
-function CardDescription(props: StackProps) {
- return (
-
- {props.children}
-
- );
-}
-
-const CardIllustration = styled('img')`
- width: 100%;
- max-width: 200px;
- min-width: 100px;
- height: auto;
- object-fit: contain;
- margin-bottom: -6px;
- margin-right: 10px;
-`;
-
-const CursorCardIllustration = styled(CardIllustration)`
- max-width: 160px;
-`;
-
-const CursorPluginIcon = styled('div')`
- transform: translateY(3px);
-`;
-
-function StepContentRow(props: FlexProps) {
- return (
-
- {props.children}
-
- );
-}
-
-function StepTextCol(props: StackProps) {
- return (
-
- {props.children}
-
- );
-}
-
-function StepImageCol(props: FlexProps) {
- return (
-
- {props.children}
-
- );
-}
-
-const StepsHeader = styled('h3')`
- display: flex;
- align-items: center;
- gap: ${p => p.theme.space.md};
- font-size: ${p => p.theme.font.size.xl};
- margin-bottom: ${p => p.theme.space.xs};
- margin-left: 1px;
-`;
-
-const StepsDivider = styled('hr')`
- border: none;
- border-top: 1px solid ${p => p.theme.tokens.border.primary};
- margin: ${p => p.theme.space['2xl']} 0;
-`;
-
-const CollapsedSummaryCard = styled('div')`
- display: flex;
- align-items: center;
- gap: ${p => p.theme.space.md};
- background: ${p => p.theme.colors.pink500}10;
- border: 1px solid ${p => p.theme.tokens.border.primary};
- border-radius: 6px;
- padding: ${p => p.theme.space.md};
- margin-bottom: ${p => p.theme.space.xl};
- cursor: pointer;
- font-size: ${p => p.theme.font.size.md};
- font-weight: 500;
- color: ${p => p.theme.tokens.content.primary};
- transition: box-shadow 0.2s;
- box-shadow: 0 1px 2px rgba(0, 0, 0, 0.03);
- &:hover {
- background: ${p => p.theme.colors.pink500}20;
- }
-`;
diff --git a/static/app/views/issueDetails/streamline/sidebar/seerSection.spec.tsx b/static/app/views/issueDetails/streamline/sidebar/seerSection.spec.tsx
deleted file mode 100644
index a6478e0163e1e2..00000000000000
--- a/static/app/views/issueDetails/streamline/sidebar/seerSection.spec.tsx
+++ /dev/null
@@ -1,221 +0,0 @@
-import {AutofixSetupFixture} from 'sentry-fixture/autofixSetupFixture';
-import {EventFixture} from 'sentry-fixture/event';
-import {FrameFixture} from 'sentry-fixture/frame';
-import {GroupFixture} from 'sentry-fixture/group';
-import {OrganizationFixture} from 'sentry-fixture/organization';
-import {DetailedProjectFixture} from 'sentry-fixture/project';
-
-import {render, screen, waitFor} from 'sentry-test/reactTestingLibrary';
-
-import {EntryType} from 'sentry/types/event';
-import {IssueCategory, type Group} from 'sentry/types/group';
-import type {Project} from 'sentry/types/project';
-import {SeerSection} from 'sentry/views/issueDetails/streamline/sidebar/seerSection';
-
-jest.mock('sentry/utils/regions');
-
-describe('SeerSection', () => {
- const mockEvent = EventFixture({
- entries: [
- {
- type: EntryType.EXCEPTION,
- data: {values: [{stacktrace: {frames: [FrameFixture()]}}]},
- },
- ],
- });
- let mockGroup!: ReturnType;
- const mockProject = DetailedProjectFixture();
- const organization = OrganizationFixture({
- hideAiFeatures: false,
- features: ['gen-ai-features'],
- });
-
- beforeEach(() => {
- mockGroup = GroupFixture();
- MockApiClient.clearMockResponses();
-
- MockApiClient.addMockResponse({
- url: `/organizations/${mockProject.organization.slug}/issues/${mockGroup.id}/autofix/setup/`,
- body: AutofixSetupFixture({
- integration: {ok: true, reason: null},
- githubWriteIntegration: {ok: true, repos: []},
- }),
- });
-
- MockApiClient.addMockResponse({
- url: `/organizations/${mockProject.organization.slug}/issues/${mockGroup.id}/autofix/`,
- body: {steps: []},
- });
- });
-
- it('renders summary when AI features are enabled and data is available', async () => {
- const mockWhatHappened = 'This is a test what happened';
- const mockTrace = 'This is a test trace';
- const mockCause = 'This is a test cause';
- MockApiClient.addMockResponse({
- url: `/organizations/${mockProject.organization.slug}/issues/${mockGroup.id}/summarize/`,
- method: 'POST',
- body: {possibleCause: mockCause, whatsWrong: mockWhatHappened, trace: mockTrace},
- });
-
- render(
-
- {t('Meet Seer, the AI debugging agent.')}
-
-
- 
-
-
-
- {t(
- 'Find the root cause of the issue, and even open a PR to fix it, in minutes.'
- )}
-
-
-
- );
-}
-
-function SeerSectionContent({
- group,
- project,
- event,
-}: {
- event: Event | undefined;
- group: Group;
- project: Project;
-}) {
- const aiConfig = useAiConfig(group, project);
-
- if (!event && !aiConfig.isAutofixSetupLoading) {
- return {t('No event to analyze.')} ;
- }
- if (!event || aiConfig.isAutofixSetupLoading) {
- return
-
- );
- }
-
- return (
-
-
- );
- }
-
- return null;
-}
-
-export function SeerSection({
- group,
- project,
- event,
-}: {
- event: Event | undefined;
- group: Group;
- project: Project;
-}) {
- const aiConfig = useAiConfig(group, project);
- const issueTypeConfig = getConfigForIssueType(group, project);
-
- const issueTypeDoesntHaveSeer =
- !issueTypeConfig.autofix && !issueTypeConfig.issueSummary;
-
- if (
- (!aiConfig.areAiFeaturesAllowed || issueTypeDoesntHaveSeer) &&
- !aiConfig.hasResources
- ) {
- return null;
- }
-
- const showCtaButton =
- aiConfig.orgNeedsGenAiAcknowledgement ||
- aiConfig.hasAutofix ||
- (aiConfig.hasSummary && aiConfig.hasResources);
-
- const onlyHasResources =
- issueTypeDoesntHaveSeer ||
- (!aiConfig.orgNeedsGenAiAcknowledgement &&
- !aiConfig.hasSummary &&
- !aiConfig.hasAutofix &&
- aiConfig.hasResources);
-
- const titleComponent = onlyHasResources ? (
- {t('Resources')}
- ) : (
-
- {t('Seer Autofix')}
-
- );
-
- // Determine what content to show in the section body
- const renderSectionContent = () => {
- // Welcome entrypoint for orgs that need consent
- if (aiConfig.orgNeedsGenAiAcknowledgement && !aiConfig.isAutofixSetupLoading) {
- return
-
-
-
- );
- }
-
- return null;
- };
-
- return (
-
-
- {renderSectionContent()}
- {event && showCtaButton && (
-
-
- );
-}
-
-const Summary = styled('div')`
- margin-bottom: ${p => p.theme.space.xs};
- position: relative;
-`;
-
-const ResourcesWrapper = styled('div')`
- position: relative;
- margin-bottom: ${p => p.theme.space.md};
-`;
-
-const ResourcesContent = styled('div')`
- position: relative;
- padding-bottom: ${p => p.theme.space.xl};
-`;
-
-const HeaderContainer = styled('div')`
- font-size: ${p => p.theme.font.size.md};
- display: flex;
- align-items: center;
- gap: ${p => p.theme.space.xs};
-`;
-
-const StyledP = styled('p')`
- margin-bottom: ${p => p.theme.space.md};
-`;
-
-const WelcomeContainer = styled('div')`
- margin-bottom: ${p => p.theme.space.lg};
-`;
-
-const WelcomeImageContainer = styled('div')`
- margin-bottom: ${p => p.theme.space.lg};
- margin-top: ${p => p.theme.space.lg};
-
- img {
- max-width: 100%;
- height: auto;
- }
-`;
diff --git a/static/app/views/issueDetails/streamline/sidebar/seerSectionCtaButton.tsx b/static/app/views/issueDetails/streamline/sidebar/seerSectionCtaButton.tsx
deleted file mode 100644
index 1b46d40de942a1..00000000000000
--- a/static/app/views/issueDetails/streamline/sidebar/seerSectionCtaButton.tsx
+++ /dev/null
@@ -1,267 +0,0 @@
-import {useEffect, useRef} from 'react';
-import styled from '@emotion/styled';
-// eslint-disable-next-line no-restricted-imports
-import color from 'color';
-
-import {LinkButton} from '@sentry/scraps/button';
-import {Flex} from '@sentry/scraps/layout';
-
-import {addSuccessMessage} from 'sentry/actionCreators/indicator';
-import {
- AutofixStatus,
- AutofixStepType,
- type AutofixStep,
-} from 'sentry/components/events/autofix/types';
-import {useAiAutofix, useAutofixData} from 'sentry/components/events/autofix/useAutofix';
-import {
- getAutofixRunExists,
- getCodeChangesDescription,
- getRootCauseDescription,
- getSolutionDescription,
- hasPullRequest,
-} from 'sentry/components/events/autofix/utils';
-import {useGroupSummaryData} from 'sentry/components/group/groupSummary';
-import {LoadingIndicator} from 'sentry/components/loadingIndicator';
-import {Placeholder} from 'sentry/components/placeholder';
-import {IconChevron} from 'sentry/icons';
-import {t} from 'sentry/locale';
-import type {Event} from 'sentry/types/event';
-import type {Group} from 'sentry/types/group';
-import type {Project} from 'sentry/types/project';
-import {useLocation} from 'sentry/utils/useLocation';
-import type {useAiConfig} from 'sentry/views/issueDetails/streamline/hooks/useAiConfig';
-import {useOpenSeerDrawer} from 'sentry/views/issueDetails/streamline/sidebar/seerDrawer';
-
-interface Props {
- aiConfig: ReturnType;
- event: Event;
- group: Group;
- hasStreamlinedUI: boolean;
- project: Project;
-}
-
-export function SeerSectionCtaButton({
- aiConfig,
- event,
- group,
- project,
- hasStreamlinedUI,
-}: Props) {
- const location = useLocation();
- const seerLink = {
- pathname: location.pathname,
- query: {
- ...location.query,
- seerDrawer: true,
- },
- };
-
- const openButtonRef = useRef(null);
- const isDrawerOpenRef = useRef(false);
-
- const {isPending: isAutofixPending} = useAutofixData({groupId: group.id});
- const {autofixData} = useAiAutofix(group, event, {
- isSidebar: !isDrawerOpenRef.current,
- pollInterval: 1500,
- });
-
- const {data: summaryData, isPending: isSummaryPending} = useGroupSummaryData(group);
-
- const {openSeerDrawer} = useOpenSeerDrawer({
- group,
- project,
- event,
- buttonRef: openButtonRef,
- });
-
- // Keep isDrawerOpenRef in sync with the Seer drawer state (based on URL query)
- useEffect(() => {
- isDrawerOpenRef.current = !!location.query.seerDrawer;
- }, [location.query.seerDrawer]);
-
- // Keep track of previous steps to detect state transitions and notify the user
- const prevStepsRef = useRef(null);
- const prevRunIdRef = useRef(null);
- useEffect(() => {
- if (isDrawerOpenRef.current) {
- return;
- }
-
- if (!autofixData?.steps || !prevStepsRef.current) {
- prevStepsRef.current = autofixData?.steps ?? null;
- prevRunIdRef.current = autofixData?.run_id ?? null;
- return;
- }
-
- const prevSteps = prevStepsRef.current;
- const currentSteps = autofixData.steps;
-
- // Don't show notifications if the run_id has changed
- if (
- prevStepsRef.current !== currentSteps &&
- autofixData?.run_id !== prevRunIdRef.current
- ) {
- prevStepsRef.current = currentSteps;
- prevRunIdRef.current = autofixData?.run_id;
- return;
- }
-
- // Find the most recent step
- const processingStep = currentSteps.findLast(
- step => step.type === AutofixStepType.DEFAULT
- );
-
- if (processingStep?.status === AutofixStatus.COMPLETED) {
- // Check if this is a new completion (wasn't completed in previous state)
- const prevProcessingStep = prevSteps.findLast(
- step => step.type === AutofixStepType.DEFAULT
- );
- if (prevProcessingStep && prevProcessingStep.status !== AutofixStatus.COMPLETED) {
- if (currentSteps.some(step => step.type === AutofixStepType.CHANGES)) {
- addSuccessMessage(t('Seer has finished coding.'));
- } else if (currentSteps.some(step => step.type === AutofixStepType.SOLUTION)) {
- addSuccessMessage(t('Seer has found a solution.'));
- } else if (
- currentSteps.some(step => step.type === AutofixStepType.ROOT_CAUSE_ANALYSIS)
- ) {
- addSuccessMessage(t('Seer has found the root cause.'));
- }
- }
- }
-
- prevStepsRef.current = autofixData?.steps ?? null;
- prevRunIdRef.current = autofixData?.run_id ?? null;
- }, [autofixData?.steps, autofixData?.run_id]);
-
- // Update drawer state when opening
- const handleOpenDrawer = () => {
- openSeerDrawer();
- };
-
- const showCtaButton =
- aiConfig.orgNeedsGenAiAcknowledgement ||
- aiConfig.hasAutofix ||
- (aiConfig.hasSummary && aiConfig.hasResources);
- const isButtonLoading =
- aiConfig.isAutofixSetupLoading || (isAutofixPending && getAutofixRunExists(group));
-
- const lastStep = autofixData?.steps?.[autofixData.steps.length - 1];
- const isAutofixInProgress = lastStep?.status === AutofixStatus.PROCESSING;
- const isAutofixCompleted = lastStep?.status === AutofixStatus.COMPLETED;
- const isAutofixWaitingForUser =
- autofixData?.status === AutofixStatus.WAITING_FOR_USER_RESPONSE;
-
- const hasStepType = (type: AutofixStepType) =>
- autofixData?.steps?.some(step => step.type === type);
-
- const rootCauseDescription = autofixData ? getRootCauseDescription(autofixData) : null;
- const solutionDescription = autofixData ? getSolutionDescription(autofixData) : null;
- const codeChangesDescription = autofixData
- ? getCodeChangesDescription(autofixData)
- : null;
- const hasPr = hasPullRequest(autofixData);
-
- const getButtonText = () => {
- if (!aiConfig.hasAutofix) {
- return t('Open Resources');
- }
-
- if (
- (aiConfig.orgNeedsGenAiAcknowledgement || !aiConfig.hasAutofixQuota) &&
- !aiConfig.isAutofixSetupLoading
- ) {
- return t('Fix with Seer');
- }
-
- if (!lastStep) {
- return t('Find Root Cause');
- }
-
- if (isAutofixWaitingForUser) {
- return t('Waiting for Your Input');
- }
-
- if (isAutofixInProgress) {
- if (!hasStepType(AutofixStepType.ROOT_CAUSE_ANALYSIS)) {
- return t('Finding Root Cause');
- }
- if (!hasStepType(AutofixStepType.SOLUTION)) {
- return t('Finding Solution');
- }
- if (!hasStepType(AutofixStepType.CHANGES)) {
- return t('Writing Code');
- }
- }
-
- if (isAutofixCompleted) {
- if (lastStep.type === AutofixStepType.SOLUTION) {
- return t('Fix with Seer');
- }
- return t('Open Autofix');
- }
-
- return t('Fix with Seer');
- };
-
- if (isButtonLoading) {
- return
- {getButtonText()}
-
- {isAutofixInProgress ? (
-
-
- );
-}
-
-const StyledButton = styled(LinkButton)`
- margin-top: ${p => p.theme.space.md};
- width: 100%;
-`;
-
-const StyledLoadingIndicator = styled(LoadingIndicator)`
- position: relative;
- margin-left: ${p => p.theme.space.md};
-
- .loading-indicator {
- border-color: ${p => color(p.theme.colors.white).alpha(0.35).string()};
- border-left-color: ${p => p.theme.colors.white};
- }
-`;
-
-const ButtonPlaceholder = styled(Placeholder)`
- width: 100%;
- height: 38px;
- border-radius: ${p => p.theme.radius.md};
- margin-top: ${p => p.theme.space.md};
-`;
diff --git a/static/app/views/issueDetails/streamline/sidebar/sidebar.spec.tsx b/static/app/views/issueDetails/streamline/sidebar/sidebar.spec.tsx
index 98754fa1faef92..5c150d059959fe 100644
--- a/static/app/views/issueDetails/streamline/sidebar/sidebar.spec.tsx
+++ b/static/app/views/issueDetails/streamline/sidebar/sidebar.spec.tsx
@@ -67,6 +67,16 @@ describe('StreamlinedSidebar', () => {
body: {steps: []},
});
+ MockApiClient.addMockResponse({
+ url: `/organizations/${organization.slug}/seer/onboarding-check/`,
+ body: {
+ hasSupportedScmIntegration: true,
+ isAutofixEnabled: true,
+ isCodeReviewEnabled: true,
+ isSeerConfigured: true,
+ },
+ });
+
mockFirstLastRelease = MockApiClient.addMockResponse({
url: `/organizations/${organization.slug}/issues/${group.id}/first-last-release/`,
method: 'GET',
diff --git a/static/app/views/issueDetails/streamline/sidebar/sidebar.tsx b/static/app/views/issueDetails/streamline/sidebar/sidebar.tsx
index 75b4a7aef1e3b6..63e08407f08588 100644
--- a/static/app/views/issueDetails/streamline/sidebar/sidebar.tsx
+++ b/static/app/views/issueDetails/streamline/sidebar/sidebar.tsx
@@ -28,7 +28,6 @@ import {ExternalIssueSidebarList} from 'sentry/views/issueDetails/streamline/sid
import {FirstLastSeenSection} from 'sentry/views/issueDetails/streamline/sidebar/firstLastSeenSection';
import {MergedIssuesSidebarSection} from 'sentry/views/issueDetails/streamline/sidebar/mergedSidebarSection';
import {PeopleSection} from 'sentry/views/issueDetails/streamline/sidebar/peopleSection';
-import {SeerSection} from 'sentry/views/issueDetails/streamline/sidebar/seerSection';
import {SimilarIssuesSidebarSection} from 'sentry/views/issueDetails/streamline/sidebar/similarIssuesSidebarSection';
import {SupergroupSection} from 'sentry/views/issueDetails/streamline/sidebar/supergroupSection';
@@ -96,11 +95,7 @@ export function StreamlinedSidebar({group, event, project}: Props) {
- {organization.features.includes('autofix-on-explorer') ? (
-
)}
{event && (
diff --git a/static/app/views/issueList/pages/autofix/recentlyRun.tsx b/static/app/views/issueList/pages/autofix/recentlyRun.tsx
index 1f538bacf8f303..e6f9e31d9db119 100644
--- a/static/app/views/issueList/pages/autofix/recentlyRun.tsx
+++ b/static/app/views/issueList/pages/autofix/recentlyRun.tsx
@@ -1,4 +1,3 @@
-import Feature from 'sentry/components/acl/feature';
import {NoProjectMessage} from 'sentry/components/noProjectMessage';
import {PageFiltersContainer} from 'sentry/components/pageFilters/container';
import {t} from 'sentry/locale';
@@ -13,18 +12,16 @@ export default function AutofixRecentlyRunPage() {
const organization = useOrganization();
return (
-
-
-
-
-
-
-
-
+
+
+
+
+
+
);
}
diff --git a/static/app/views/navigation/secondary/sections/issues/issuesSecondaryNavigation.tsx b/static/app/views/navigation/secondary/sections/issues/issuesSecondaryNavigation.tsx
index b232114def5e9a..881c86cb3fef15 100644
--- a/static/app/views/navigation/secondary/sections/issues/issuesSecondaryNavigation.tsx
+++ b/static/app/views/navigation/secondary/sections/issues/issuesSecondaryNavigation.tsx
@@ -65,24 +65,20 @@ export function IssuesSecondaryNavigation() {
- {organization.features.includes('autofix-on-explorer') && (
-
-
-
-
-
- {t('Recently Run')}
-
-
-
-
-
- )}
+
+
+
+
+ {t('Recently Run')}
+
+
+
+
diff --git a/static/app/views/performance/newTraceDetails/traceDrawer/details/styles.tsx b/static/app/views/performance/newTraceDetails/traceDrawer/details/styles.tsx
index cb570b706bbfff..023e14a6aba1f2 100644
--- a/static/app/views/performance/newTraceDetails/traceDrawer/details/styles.tsx
+++ b/static/app/views/performance/newTraceDetails/traceDrawer/details/styles.tsx
@@ -43,6 +43,7 @@ import {
IconJson,
IconPanel,
IconProfiling,
+ IconTerminal,
} from 'sentry/icons';
import {t, tct} from 'sentry/locale';
import type {Event, EventTransaction} from 'sentry/types/event';
@@ -51,6 +52,7 @@ import type {Organization} from 'sentry/types/organization';
import type {Project} from 'sentry/types/project';
import {trackAnalytics} from 'sentry/utils/analytics';
import {getDuration} from 'sentry/utils/duration/getDuration';
+import {isActiveSuperuser} from 'sentry/utils/isActiveSuperuser';
import {MarkedText} from 'sentry/utils/marked/markedText';
import {useLocation} from 'sentry/utils/useLocation';
import {useOrganization} from 'sentry/utils/useOrganization';
@@ -64,6 +66,7 @@ import {
makeTraceContinuousProfilingLink,
makeTransactionProfilingLink,
} from 'sentry/views/performance/newTraceDetails/traceDrawer/traceProfilingLink';
+import {isEAPSpanNode} from 'sentry/views/performance/newTraceDetails/traceGuards';
import type {BaseNode} from 'sentry/views/performance/newTraceDetails/traceModels/traceTreeNode/baseNode';
import type {EapSpanNode} from 'sentry/views/performance/newTraceDetails/traceModels/traceTreeNode/eapSpanNode';
import {
@@ -1013,6 +1016,16 @@ function NodeActions(props: {
/>
) : null}
+ {isActiveSuperuser() && isEAPSpanNode(props.node) && params.traceSlug ? (
+
+
+ ) : null}
{continuousProfileTarget ? (
-
-
-
-
- {t('Meet Seer')}
-
-
- {t(
- 'Debug faster with Seer. It will connect to your repositories, scan all of your issues, highlight the ones that are quick to fix, and propose solutions. You can even integrate with your favorite coding agent to implement changes in code. '
- )}
-
-
- {hasAccessToSubscriptionOverview(subscription, organization) ? (
-
- {t(
- 'You need to be a billing member to try out Seer. Please contact your organization owner to upgrade your plan.'
- )}
-
- )}
-
-
-
-
-
-
-
-
-
-
-
- {t('Root Cause Analysis & Code Fixes')}
-
- {t(
- 'Seer analyzes the root cause of an issue and propose fixes ready to merge as draft PRs.'
- )}
-
-
-
-
-
-
-
-
-
- {t('AI Code Review')}
- {t('Seer catches bugs in your PRs before you ship them.')}
-
-
-
-
-
-
- );
-}
-
-const HeroImage = styled(ImageBase)`
- position: absolute;
- z-index: ${p => p.theme.zIndex.initial};
- min-width: 150%;
- left: 50%;
- transform: translateX(-47%) translateY(-35%);
-`;
-
-const Image = styled(ImageBase)<{alignSelf?: CSSProperties['alignSelf']}>`
- align-self: ${p => p.alignSelf ?? 'center'};
-`;
-
-const MeetSeerPanel = styled(Panel)`
- margin-top: 32%;
-`;
diff --git a/static/gsApp/registerOverrides.tsx b/static/gsApp/registerOverrides.tsx
index 431cc1cd48818a..e746420eac73c5 100644
--- a/static/gsApp/registerOverrides.tsx
+++ b/static/gsApp/registerOverrides.tsx
@@ -7,7 +7,6 @@ import type {Overrides} from 'sentry/types/overrides';
import type {OrganizationStatsProps} from 'sentry/views/organizationStats';
import {AiConfigureSeerQuotaSidebar} from 'getsentry/components/ai/aiConfigureSeerQuotaSidebar';
-import {AiSetupConfiguration} from 'getsentry/components/ai/aiSetupConfiguration';
import {AiSetupDataConsent} from 'getsentry/components/ai/AiSetupDataConsent';
import CronsBillingBanner from 'getsentry/components/crons/cronsBillingBanner';
import {DashboardBanner} from 'getsentry/components/dashboardBanner';
@@ -236,7 +235,6 @@ const GETSENTRY_OVERRIDES: Partial = {
'component:insights-date-range-query-limit-footer': () =>
InsightsDateRangeQueryLimitFooter,
'component:ai-configure-seer-quota-sidebar': () => AiConfigureSeerQuotaSidebar,
- 'component:ai-setup-configuration': () => AiSetupConfiguration,
'component:ai-setup-data-consent': () => AiSetupDataConsent,
'component:codecov-integration-settings-link': () => CodecovSettingsLink,
'component:continuous-profiling-billing-requirement-banner': () =>
diff --git a/tests/js/fixtures/autofixCodebaseChangeData.ts b/tests/js/fixtures/autofixCodebaseChangeData.ts
deleted file mode 100644
index c37cce7dd29c13..00000000000000
--- a/tests/js/fixtures/autofixCodebaseChangeData.ts
+++ /dev/null
@@ -1,20 +0,0 @@
-import {AutofixDiffFilePatch} from 'sentry-fixture/autofixDiffFilePatch';
-
-import type {AutofixCodebaseChange} from 'sentry/components/events/autofix/types';
-
-export function AutofixCodebaseChangeData(
- params: Partial = {}
-): AutofixCodebaseChange {
- return {
- description: '',
- diff: [AutofixDiffFilePatch()],
- repo_external_id: '100',
- repo_name: 'owner/hello-world',
- title: 'Add error handling',
- pull_request: {
- pr_number: 200,
- pr_url: 'https://github.com/owner/hello-world/pull/200',
- },
- ...params,
- };
-}
diff --git a/tests/js/fixtures/autofixData.ts b/tests/js/fixtures/autofixData.ts
deleted file mode 100644
index aab7f33610ceb4..00000000000000
--- a/tests/js/fixtures/autofixData.ts
+++ /dev/null
@@ -1,17 +0,0 @@
-import type {AutofixData} from 'sentry/components/events/autofix/types';
-import {AutofixStatus} from 'sentry/components/events/autofix/types';
-
-export function AutofixDataFixture(params: Partial): AutofixData {
- return {
- run_id: '1',
- status: AutofixStatus.PROCESSING,
- completed_at: '',
- last_triggered_at: '',
- steps: [],
- request: {
- repos: [],
- },
- codebases: {},
- ...params,
- };
-}
diff --git a/tests/js/fixtures/autofixDiffFilePatch.ts b/tests/js/fixtures/autofixDiffFilePatch.ts
deleted file mode 100644
index 71b92ed516c9e7..00000000000000
--- a/tests/js/fixtures/autofixDiffFilePatch.ts
+++ /dev/null
@@ -1,84 +0,0 @@
-import type {FilePatch} from 'sentry/components/events/autofix/types';
-import {DiffFileType, DiffLineType} from 'sentry/components/events/autofix/types';
-
-export function AutofixDiffFilePatch(params: Partial = {}): FilePatch {
- return {
- added: 1,
- path: 'src/sentry/processing/backpressure/memory.py',
- removed: 1,
- source_file: 'src/sentry/processing/backpressure/memory.py',
- target_file: 'src/sentry/processing/backpressure/memory.py',
- type: DiffFileType.MODIFIED,
- hunks: [
- {
- lines: [
- {
- line_type: DiffLineType.CONTEXT,
- diff_line_no: 6,
- source_line_no: 47,
- target_line_no: 47,
- value: ' # or alternatively: `used_memory_rss`?\n',
- },
- {
- line_type: DiffLineType.CONTEXT,
- diff_line_no: 7,
- source_line_no: 48,
- target_line_no: 48,
- value: ' memory_used = info.get("used_memory", 0)\n',
- },
- {
- line_type: DiffLineType.CONTEXT,
- diff_line_no: 8,
- source_line_no: 49,
- target_line_no: 49,
- value: ' # `maxmemory` might be 0 in development\n',
- },
- {
- line_type: DiffLineType.REMOVED,
- diff_line_no: 9,
- source_line_no: 50,
- target_line_no: null,
- value:
- ' memory_available = info.get("maxmemory", 0) or info["total_system_memory"]\n',
- },
- {
- line_type: DiffLineType.ADDED,
- diff_line_no: 10,
- source_line_no: null,
- target_line_no: 50,
- value:
- ' memory_available = info.get("maxmemory", 0) or info.get("total_system_memory", 0)\n',
- },
- {
- line_type: DiffLineType.CONTEXT,
- diff_line_no: 11,
- source_line_no: 51,
- target_line_no: 51,
- value: '\n',
- },
- {
- line_type: DiffLineType.CONTEXT,
- diff_line_no: 12,
- source_line_no: 52,
- target_line_no: 52,
- value: ' return ServiceMemory(node_id, memory_used, memory_available)\n',
- },
- {
- line_type: DiffLineType.CONTEXT,
- diff_line_no: 13,
- source_line_no: 53,
- target_line_no: 53,
- value: '\n',
- },
- ],
- section_header:
- 'def get_memory_usage(node_id: str, info: Mapping[str, Any]) -> ServiceMemory:',
- source_length: 7,
- source_start: 47,
- target_length: 7,
- target_start: 47,
- },
- ],
- ...params,
- };
-}
diff --git a/tests/js/fixtures/autofixProgressItem.ts b/tests/js/fixtures/autofixProgressItem.ts
deleted file mode 100644
index 8544ae9c04ed85..00000000000000
--- a/tests/js/fixtures/autofixProgressItem.ts
+++ /dev/null
@@ -1,13 +0,0 @@
-import type {AutofixProgressItem} from 'sentry/components/events/autofix/types';
-
-export function AutofixProgressItemFixture(
- params: Partial
-): AutofixProgressItem {
- return {
- message: 'Example log message',
- timestamp: '2024-01-01T00:00:00',
- type: 'INFO',
- data: null,
- ...params,
- };
-}
diff --git a/tests/js/fixtures/autofixRootCauseData.ts b/tests/js/fixtures/autofixRootCauseData.ts
deleted file mode 100644
index bacaec4a95176e..00000000000000
--- a/tests/js/fixtures/autofixRootCauseData.ts
+++ /dev/null
@@ -1,23 +0,0 @@
-import type {AutofixRootCauseData} from 'sentry/components/events/autofix/types';
-
-export function AutofixRootCauseData(
- params: Partial = {}
-): AutofixRootCauseData {
- return {
- id: '100',
- root_cause_reproduction: [
- {
- code_snippet_and_analysis:
- 'This is the code snippet and analysis of a root cause.',
- relevant_code_file: {
- file_path: 'src/file.py',
- repo_name: 'owner/repo',
- },
- timeline_item_type: 'internal_code',
- title: 'This is the title of a root cause.',
- is_most_important_event: true,
- },
- ],
- ...params,
- };
-}
diff --git a/tests/js/fixtures/autofixStep.ts b/tests/js/fixtures/autofixStep.ts
deleted file mode 100644
index 5b0b4545dcc1f3..00000000000000
--- a/tests/js/fixtures/autofixStep.ts
+++ /dev/null
@@ -1,18 +0,0 @@
-import type {
- AutofixDefaultStep,
- AutofixStep,
-} from 'sentry/components/events/autofix/types';
-import {AutofixStepType} from 'sentry/components/events/autofix/types';
-
-export function AutofixStepFixture(params: Partial = {}): AutofixStep {
- return {
- type: AutofixStepType.DEFAULT,
- id: '1',
- index: 1,
- title: 'I am processing',
- status: 'PROCESSING',
- progress: [],
- insights: [],
- ...params,
- } as AutofixDefaultStep;
-}
diff --git a/tests/sentry/dashboards/endpoints/test_organization_dashboard_widget_details.py b/tests/sentry/dashboards/endpoints/test_organization_dashboard_widget_details.py
index 75ec4434eacb62..3a11f45f97f09a 100644
--- a/tests/sentry/dashboards/endpoints/test_organization_dashboard_widget_details.py
+++ b/tests/sentry/dashboards/endpoints/test_organization_dashboard_widget_details.py
@@ -176,6 +176,30 @@ def test_invalid_display_type(self) -> None:
assert response.status_code == 400, response.data
assert "displayType" in response.data, response.data
+ def test_unsupported_display_type_for_widget_type(self) -> None:
+ data = {
+ "title": "Table on preprod-app-size",
+ "displayType": "table",
+ "widgetType": "preprod-app-size",
+ "queries": [
+ {
+ "name": "",
+ "conditions": "",
+ "fields": ["count()"],
+ "columns": [],
+ "aggregates": ["count()"],
+ }
+ ],
+ }
+ response = self.do_request(
+ "post",
+ self.url(),
+ data=data,
+ )
+ assert response.status_code == 400, response.data
+ assert "displayType" in response.data, response.data
+ assert "preprod-app-size" in str(response.data["displayType"])
+
def test_invalid_equation(self) -> None:
data = {
"title": "Invalid query",
@@ -1442,7 +1466,7 @@ def test_widget_type_tracemetrics(self) -> None:
data = {
"title": "Test Metrics Query",
"widgetType": "tracemetrics",
- "displayType": "table",
+ "displayType": "line",
"queries": [
{
"name": "",
@@ -1461,6 +1485,30 @@ def test_widget_type_tracemetrics(self) -> None:
)
assert response.status_code == 200, response.data
+ def test_widget_type_tracemetrics_rejects_table(self) -> None:
+ data = {
+ "title": "Test Metrics Query",
+ "widgetType": "tracemetrics",
+ "displayType": "table",
+ "queries": [
+ {
+ "name": "",
+ "conditions": "metric.name:foo",
+ "fields": ["sum(value)"],
+ "columns": [],
+ "aggregates": ["sum(value)"],
+ },
+ ],
+ }
+
+ response = self.do_request(
+ "post",
+ self.url(),
+ data=data,
+ )
+ assert response.status_code == 400, response.data
+ assert "displayType" in response.data, response.data
+
def test_text_widget_without_feature_flag(self) -> None:
data = {
"title": "Text Widget Title",
diff --git a/tests/sentry/dashboards/endpoints/test_organization_dashboards.py b/tests/sentry/dashboards/endpoints/test_organization_dashboards.py
index d5c51ef1449870..459d9096cdd162 100644
--- a/tests/sentry/dashboards/endpoints/test_organization_dashboards.py
+++ b/tests/sentry/dashboards/endpoints/test_organization_dashboards.py
@@ -2169,6 +2169,92 @@ def test_post_with_text_widget(self) -> None:
assert DashboardWidgetQuery.objects.filter(widget=text_widget).count() == 0
+ def test_agents_traces_table_dashboard_save_and_update(self) -> None:
+ # Regression: the AI Agents Overview prebuilt config has an
+ # agents_traces_table widget without a widget_type. The backend defaults
+ # it to error-events on create. On the next PUT the frontend round-trips
+ # widget_type=error-events, which would otherwise fail validation.
+ data = {
+ "title": "AI Agents Overview",
+ "widgets": [
+ {
+ "title": "Traces",
+ "displayType": "agents_traces_table",
+ "queries": [
+ {
+ "name": "",
+ "fields": [],
+ "columns": [],
+ "aggregates": [],
+ "conditions": "",
+ }
+ ],
+ },
+ ],
+ }
+ create = self.do_request("post", self.url, data=data)
+ assert create.status_code == 201, create.data
+ dashboard_id = create.data["id"]
+ widget_id = create.data["widgets"][0]["id"]
+ widget_type = create.data["widgets"][0].get("widgetType")
+
+ put_url = f"/api/0/organizations/{self.organization.slug}/dashboards/{dashboard_id}/"
+ put_data = {
+ "title": "AI Agents Overview",
+ "widgets": [
+ {
+ "id": widget_id,
+ "title": "Traces",
+ "displayType": "agents_traces_table",
+ "widgetType": widget_type,
+ "queries": [
+ {
+ "name": "",
+ "fields": [],
+ "columns": [],
+ "aggregates": [],
+ "conditions": "",
+ }
+ ],
+ },
+ ],
+ }
+ update = self.do_request("put", put_url, data=put_data)
+ assert update.status_code == 200, update.data
+
+ def test_post_text_widget_after_restrictive_dataset_widget(self) -> None:
+ # Regression: DRF reuses a single child serializer for ``many=True``,
+ # so a previous widget's widget_type can leak via serializer context
+ # and incorrectly fail validation for a later TEXT widget.
+ with self.feature("organizations:dashboards-text-widgets"):
+ data = {
+ "title": "Dashboard from Post",
+ "widgets": [
+ {
+ "title": "Mobile Size",
+ "displayType": "line",
+ "widgetType": "preprod-app-size",
+ "interval": "5m",
+ "queries": [
+ {
+ "name": "",
+ "fields": ["count()"],
+ "columns": [],
+ "aggregates": ["count()"],
+ "conditions": "",
+ }
+ ],
+ },
+ {
+ "title": "Text Widget",
+ "displayType": "text",
+ "description": "Notes",
+ },
+ ],
+ }
+ response = self.do_request("post", self.url, data=data)
+ assert response.status_code == 201, response.data
+
def test_post_with_text_widget_without_feature_flag(self) -> None:
data = {
"title": "Dashboard from Post",
diff --git a/tests/sentry/integrations/slack/test_unfurl.py b/tests/sentry/integrations/slack/test_unfurl.py
index 04e85bac98f674..5ce347cd4cc9b7 100644
--- a/tests/sentry/integrations/slack/test_unfurl.py
+++ b/tests/sentry/integrations/slack/test_unfurl.py
@@ -23,6 +23,7 @@
from sentry.testutils.cases import TestCase
from sentry.testutils.helpers import install_slack
from sentry.testutils.helpers.datetime import before_now, freeze_time
+from sentry.testutils.helpers.features import with_feature
from sentry.testutils.skips import requires_snuba
from sentry.types.group import PriorityLevel
from sentry.workflow_engine.migration_helpers.alert_rule import migrate_alert_rule
@@ -196,6 +197,7 @@ def test_match_link(url, expected) -> None:
assert match_link(url) == expected
+@with_feature("organizations:visibility-explore-view")
class UnfurlTest(TestCase):
def setUp(self) -> None:
super().setUp()
@@ -1135,8 +1137,7 @@ def test_unfurl_explore(
UnfurlableUrl(url=url, args=args),
]
- with self.feature(["organizations:data-browsing-widget-unfurl"]):
- unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
+ unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
assert (
unfurls[url]
@@ -1149,28 +1150,6 @@ def test_unfurl_explore(
chart_data = mock_generate_chart.call_args[0][1]
assert "timeSeries" in chart_data
- @patch(
- "sentry.integrations.slack.unfurl.explore.client.get",
- )
- @patch("sentry.charts.backend.generate_chart", return_value="chart-url")
- def test_unfurl_explore_no_feature_flag(
- self, mock_generate_chart: MagicMock, mock_client_get: MagicMock
- ) -> None:
- mock_client_get.return_value = MagicMock(data=self._build_mock_timeseries_response())
- url = f"https://sentry.io/organizations/{self.organization.slug}/explore/traces/?aggregateField=%7B%22yAxes%22%3A%5B%22avg(span.duration)%22%5D%7D&project={self.project.id}&statsPeriod=24h"
- link_type, args = match_link(url)
-
- if not args or not link_type:
- raise AssertionError("Missing link_type/args")
-
- links = [
- UnfurlableUrl(url=url, args=args),
- ]
-
- unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
- assert len(unfurls) == 0
- assert len(mock_generate_chart.mock_calls) == 0
-
@patch(
"sentry.integrations.slack.unfurl.explore.client.get",
)
@@ -1189,8 +1168,7 @@ def test_unfurl_explore_with_groupby(
UnfurlableUrl(url=url, args=args),
]
- with self.feature(["organizations:data-browsing-widget-unfurl"]):
- unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
+ unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
assert len(unfurls) == 1
assert len(mock_generate_chart.mock_calls) == 1
@@ -1221,8 +1199,7 @@ def test_unfurl_explore_forwards_multiple_groupbys_to_api(
raise AssertionError("Missing link_type/args")
links = [UnfurlableUrl(url=url, args=args)]
- with self.feature(["organizations:data-browsing-widget-unfurl"]):
- link_handlers[link_type].fn(self.integration, links, self.user)
+ link_handlers[link_type].fn(self.integration, links, self.user)
mock_view.assert_called_once()
request = mock_view.call_args[0][0]
@@ -1248,8 +1225,7 @@ def test_unfurl_explore_with_groupby_explicit_sort(
UnfurlableUrl(url=url, args=args),
]
- with self.feature(["organizations:data-browsing-widget-unfurl"]):
- unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
+ unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
assert len(unfurls) == 1
@@ -1277,8 +1253,7 @@ def test_unfurl_explore_default_yaxis(
UnfurlableUrl(url=url, args=args),
]
- with self.feature(["organizations:data-browsing-widget-unfurl"]):
- unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
+ unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
assert len(unfurls) == 1
assert len(mock_generate_chart.mock_calls) == 1
@@ -1305,8 +1280,7 @@ def test_unfurl_explore_malformed_aggregate_field(
UnfurlableUrl(url=url, args=args),
]
- with self.feature(["organizations:data-browsing-widget-unfurl"]):
- unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
+ unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
# Should still unfurl with default yAxis
assert len(unfurls) == 1
@@ -1341,8 +1315,7 @@ def test_unfurl_explore_end_to_end(
# Step 2: Run handler
links = [UnfurlableUrl(url=url, args=args)]
- with self.feature(["organizations:data-browsing-widget-unfurl"]):
- unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
+ unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
# Step 3: Verify events-timeseries was called with correct args
assert mock_client_get.call_count == 1
@@ -1402,8 +1375,7 @@ def test_unfurl_explore_with_visualize_chart_type(
UnfurlableUrl(url=url, args=args),
]
- with self.feature(["organizations:data-browsing-widget-unfurl"]):
- unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
+ unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
assert len(unfurls) == 1
assert len(mock_generate_chart.mock_calls) == 1
@@ -1429,8 +1401,7 @@ def test_unfurl_explore_without_chart_type_defaults_to_line(
UnfurlableUrl(url=url, args=args),
]
- with self.feature(["organizations:data-browsing-widget-unfurl"]):
- unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
+ unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
assert len(unfurls) == 1
chart_data = mock_generate_chart.call_args[0][1]
@@ -1456,8 +1427,7 @@ def test_unfurl_explore_skips_unsupported_chart_type(
UnfurlableUrl(url=url, args=args),
]
- with self.feature(["organizations:data-browsing-widget-unfurl"]):
- unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
+ unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
assert unfurls == {}
# Skip happens before the events-timeseries call, so neither the API
@@ -1486,8 +1456,7 @@ def test_unfurl_explore_without_chart_type_count_defaults_to_bar(
UnfurlableUrl(url=url, args=args),
]
- with self.feature(["organizations:data-browsing-widget-unfurl"]):
- unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
+ unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
assert len(unfurls) == 1
chart_data = mock_generate_chart.call_args[0][1]
@@ -1729,8 +1698,7 @@ def test_unfurl_explore_with_interval(
UnfurlableUrl(url=url, args=args),
]
- with self.feature(["organizations:data-browsing-widget-unfurl"]):
- unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
+ unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
assert len(unfurls) == 1
call_kwargs = mock_client_get.call_args[1]
@@ -1880,8 +1848,7 @@ def test_unfurl_explore_logs(
UnfurlableUrl(url=url, args=args),
]
- with self.feature(["organizations:data-browsing-widget-unfurl"]):
- unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
+ unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
assert (
unfurls[url]
@@ -2002,8 +1969,7 @@ def test_unfurl_explore_logs_customer_domain(
UnfurlableUrl(url=url, args=args),
]
- with self.feature(["organizations:data-browsing-widget-unfurl"]):
- unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
+ unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
assert len(unfurls) == 1
call_kwargs = mock_client_get.call_args[1]
@@ -2030,8 +1996,7 @@ def test_unfurl_explore_metrics(
UnfurlableUrl(url=url, args=args),
]
- with self.feature(["organizations:data-browsing-widget-unfurl"]):
- unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
+ unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
assert (
unfurls[url]
@@ -2075,8 +2040,7 @@ def test_unfurl_explore_metrics_skips_hidden_charts(
links = [UnfurlableUrl(url=url, args=args)]
- with self.feature(["organizations:data-browsing-widget-unfurl"]):
- unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
+ unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
assert (
unfurls[url]
@@ -2112,8 +2076,7 @@ def test_unfurl_explore_metrics_all_hidden_returns_no_unfurl(
links = [UnfurlableUrl(url=url, args=args)]
- with self.feature(["organizations:data-browsing-widget-unfurl"]):
- unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
+ unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
assert unfurls == {}
assert mock_generate_chart.call_count == 0
@@ -2171,8 +2134,7 @@ def test_unfurl_dashboards_spans_widget(
links = [UnfurlableUrl(url=url, args=args)]
- with self.feature(["organizations:dashboards-widget-unfurl"]):
- unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
+ unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
assert (
unfurls[url]
@@ -2213,36 +2175,11 @@ def test_unfurl_dashboards_customer_domain(
assert args is not None
links = [UnfurlableUrl(url=url, args=args)]
- with self.feature(["organizations:dashboards-widget-unfurl"]):
- unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
+ unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
assert len(unfurls) == 1
assert mock_generate_chart.call_count == 1
- @patch("sentry.integrations.slack.unfurl.dashboards.client.get")
- @patch("sentry.charts.backend.generate_chart", return_value="chart-url")
- def test_unfurl_dashboards_no_feature_flag(
- self, mock_generate_chart: MagicMock, mock_client_get: MagicMock
- ) -> None:
- mock_client_get.return_value = MagicMock(data=self._build_mock_timeseries_response())
- dashboard, _ = self._create_spans_widget()
-
- url = (
- f"https://sentry.io/organizations/{self.organization.slug}"
- f"/dashboard/{dashboard.id}/widget/0/?statsPeriod=7d"
- )
- link_type, args = match_link(url)
-
- assert link_type == LinkType.DASHBOARDS
- assert args is not None
-
- links = [UnfurlableUrl(url=url, args=args)]
- unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
-
- assert len(unfurls) == 0
- assert mock_generate_chart.call_count == 0
- assert mock_client_get.call_count == 0
-
@patch("sentry.integrations.slack.unfurl.dashboards.client.get")
@patch("sentry.charts.backend.generate_chart", return_value="chart-url")
def test_unfurl_dashboards_unsupported_widget_type_is_skipped(
@@ -2273,8 +2210,7 @@ def test_unfurl_dashboards_unsupported_widget_type_is_skipped(
assert link_type is not None and args is not None
links = [UnfurlableUrl(url=url, args=args)]
- with self.feature(["organizations:dashboards-widget-unfurl"]):
- unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
+ unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
assert len(unfurls) == 0
assert mock_client_get.call_count == 0
@@ -2298,8 +2234,7 @@ def test_unfurl_dashboards_unsupported_display_type(
assert link_type is not None and args is not None
links = [UnfurlableUrl(url=url, args=args)]
- with self.feature(["organizations:dashboards-widget-unfurl"]):
- unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
+ unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
assert len(unfurls) == 0
assert mock_client_get.call_count == 0
@@ -2320,8 +2255,7 @@ def test_unfurl_dashboards_widget_not_found(
assert link_type is not None and args is not None
links = [UnfurlableUrl(url=url, args=args)]
- with self.feature(["organizations:dashboards-widget-unfurl"]):
- unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
+ unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
assert len(unfurls) == 0
assert mock_client_get.call_count == 0
@@ -2372,8 +2306,7 @@ def test_unfurl_dashboards_multiple_queries_are_joined(
assert link_type is not None and args is not None
links = [UnfurlableUrl(url=url, args=args)]
- with self.feature(["organizations:dashboards-widget-unfurl"]):
- unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
+ unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
assert len(unfurls) == 1
assert mock_client_get.call_count == 2
@@ -2430,8 +2363,7 @@ def test_unfurl_dashboards_multi_query_same_aggregate(
assert link_type is not None and args is not None
links = [UnfurlableUrl(url=url, args=args)]
- with self.feature(["organizations:dashboards-widget-unfurl"]):
- link_handlers[link_type].fn(self.integration, links, self.user)
+ link_handlers[link_type].fn(self.integration, links, self.user)
chart_data = mock_generate_chart.call_args[0][1]
pairs = chart_data["timeSeries"]
@@ -2489,8 +2421,7 @@ def grouped_response(group_value: str):
assert link_type is not None and args is not None
links = [UnfurlableUrl(url=url, args=args)]
- with self.feature(["organizations:dashboards-widget-unfurl"]):
- link_handlers[link_type].fn(self.integration, links, self.user)
+ link_handlers[link_type].fn(self.integration, links, self.user)
chart_data = mock_generate_chart.call_args[0][1]
pairs = chart_data["timeSeries"]
@@ -2518,8 +2449,7 @@ def test_unfurl_dashboards_bar_display_type(
assert link_type is not None and args is not None
links = [UnfurlableUrl(url=url, args=args)]
- with self.feature(["organizations:dashboards-widget-unfurl"]):
- unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
+ unfurls = link_handlers[link_type].fn(self.integration, links, self.user)
assert len(unfurls) == 1
chart_data = mock_generate_chart.call_args[0][1]
diff --git a/tests/sentry/integrations/slack/webhooks/events/test_explore_link_shared.py b/tests/sentry/integrations/slack/webhooks/events/test_explore_link_shared.py
index fc3bb427542b35..d7b6946d46e967 100644
--- a/tests/sentry/integrations/slack/webhooks/events/test_explore_link_shared.py
+++ b/tests/sentry/integrations/slack/webhooks/events/test_explore_link_shared.py
@@ -93,7 +93,7 @@ def share_explore_links_ephemeral_sdk(self, mock_match_link, mock_):
return self.mock_post.call_args[1]
def test_share_explore_links_unlinked_user(self) -> None:
- with self.feature("organizations:data-browsing-widget-unfurl"):
+ with self.feature("organizations:visibility-explore-view"):
data = self.share_explore_links_ephemeral_sdk()
blocks = orjson.loads(data["blocks"])
diff --git a/tests/sentry/seer/agent/test_agent_client.py b/tests/sentry/seer/agent/test_agent_client.py
index 7319535b815498..1c479457fe59de 100644
--- a/tests/sentry/seer/agent/test_agent_client.py
+++ b/tests/sentry/seer/agent/test_agent_client.py
@@ -75,6 +75,8 @@ def test_start_run_basic(self, mock_collect_context, mock_post, mock_access):
assert run_id == 123
mock_collect_context.assert_called_once_with(self.user, self.organization, request=None)
assert mock_post.called
+ body = mock_post.call_args[0][0]
+ assert "enable_frontend_code_search" not in body
@patch("sentry.seer.agent.client.has_seer_access_with_detail")
@patch("sentry.seer.agent.client.make_agent_chat_request")
@@ -139,12 +141,14 @@ def test_start_run_with_categories(self, mock_collect_context, mock_post, mock_a
client = SeerAgentClient(
self.organization, self.user, category_key="bug-fixer", category_value="issue-123"
)
- run_id = client.start_run("Fix bug")
+ with self.feature("organizations:seer-agent-source-code-search"):
+ run_id = client.start_run("Fix bug")
assert run_id == 999
body = mock_post.call_args[0][0]
assert body["category_key"] == "bug-fixer"
assert body["category_value"] == "issue-123"
+ assert body["enable_frontend_code_search"] is True
@patch("sentry.seer.agent.client.has_seer_access_with_detail")
def test_init_category_key_only_raises_error(self, mock_access):
@@ -274,6 +278,8 @@ def test_continue_run_basic(self, mock_post, mock_access):
assert run_id == 456
assert mock_post.called
+ body = mock_post.call_args[0][0]
+ assert "enable_frontend_code_search" not in body
@patch("sentry.seer.agent.client.has_seer_access_with_detail")
@patch("sentry.seer.agent.client.make_agent_chat_request")
@@ -286,11 +292,14 @@ def test_continue_run_with_all_params(self, mock_post, mock_access):
mock_post.return_value = mock_response
client = SeerAgentClient(self.organization, self.user)
- run_id = client.continue_run(789, "Follow up", insert_index=2, on_page_context="context")
+ with self.feature("organizations:seer-agent-source-code-search"):
+ run_id = client.continue_run(
+ 789, "Follow up", insert_index=2, on_page_context="context"
+ )
assert run_id == 789
- call_args = mock_post.call_args
- assert call_args is not None
+ body = mock_post.call_args[0][0]
+ assert body["enable_frontend_code_search"] is True
@patch("sentry.seer.agent.client.has_seer_access_with_detail")
@patch("sentry.seer.agent.client.make_agent_chat_request")
diff --git a/tests/sentry/seer/endpoints/test_organization_seer_rpc.py b/tests/sentry/seer/endpoints/test_organization_seer_rpc.py
index 6a02f7039dc9ca..b9f6434c62fd60 100644
--- a/tests/sentry/seer/endpoints/test_organization_seer_rpc.py
+++ b/tests/sentry/seer/endpoints/test_organization_seer_rpc.py
@@ -63,6 +63,16 @@ def test_org_level_method_get_organization_project_ids(self) -> None:
project_ids = [p["id"] for p in response.data["projects"]]
assert self.project.id in project_ids
+ @with_feature("organizations:seer-public-rpc")
+ def test_org_level_method_get_organization_features(self) -> None:
+ """Test that get_organization_features returns the features key"""
+ path = self._get_path("get_organization_features")
+ response = self.client.post(path, data={"args": {}}, format="json")
+
+ assert response.status_code == 200
+ assert "features" in response.data
+ assert isinstance(response.data["features"], list)
+
@with_feature("organizations:seer-public-rpc")
def test_org_level_method_get_dsn(self) -> None:
project = self.create_project(organization=self.organization, slug="wordcraft")
diff --git a/tests/sentry/seer/endpoints/test_seer_rpc.py b/tests/sentry/seer/endpoints/test_seer_rpc.py
index 5ee70fbad72fad..f56be2ee5ceb51 100644
--- a/tests/sentry/seer/endpoints/test_seer_rpc.py
+++ b/tests/sentry/seer/endpoints/test_seer_rpc.py
@@ -25,6 +25,7 @@
generate_request_signature,
get_attributes_for_span,
get_github_enterprise_integration_config,
+ get_organization_features,
get_project_preferences,
get_repo_installation_id,
has_repo_code_mappings,
@@ -69,6 +70,17 @@ def test_404(self) -> None:
)
assert response.status_code == 404
+ def test_get_organization_features_registered_on_internal_rpc(self) -> None:
+ org = self.create_organization()
+ path = self._get_path("get_organization_features")
+ data: dict[str, Any] = {"args": {"org_id": org.id}, "meta": {}}
+ response = self.client.post(
+ path, data=data, HTTP_AUTHORIZATION=self.auth_header(path, data)
+ )
+ assert response.status_code == 200
+ assert "features" in response.data
+ assert isinstance(response.data["features"], list)
+
def test_snuba_rate_limit_returns_429(self) -> None:
"""Test that SnubaRPCRateLimitExceeded returns 429 to Seer for retry."""
path = self._get_path("get_trace_waterfall")
@@ -1616,6 +1628,62 @@ def test_bulk_get_project_preferences_returns_empty_for_no_projects(self) -> Non
assert result == {}
+# Two real api_expose=True flags used as a controlled feature set for
+# get_organization_features tests. Mocking features.all to this subset keeps
+# each test deterministic instead of iterating all 100+ registered flags.
+_ORG_FEATURES_TEST_SET = {
+ "organizations:seer-agent-source-code-search": object(),
+ "organizations:seer-explorer-chat-coding": object(),
+}
+
+
+class TestGetOrganizationFeatures(APITestCase):
+ def setUp(self) -> None:
+ super().setUp()
+ self.organization = self.create_organization(owner=self.user)
+
+ @patch("sentry.seer.endpoints.seer_rpc.features.all", return_value=_ORG_FEATURES_TEST_SET)
+ def test_returns_active_flags_without_prefix(self, _mock_all: object) -> None:
+ with self.feature("organizations:seer-agent-source-code-search"):
+ result = get_organization_features(org_id=self.organization.id)
+ assert result == {"features": ["seer-agent-source-code-search"]}
+
+ @patch("sentry.seer.endpoints.seer_rpc.features.all", return_value=_ORG_FEATURES_TEST_SET)
+ def test_excludes_inactive_flags(self, _mock_all: object) -> None:
+ result = get_organization_features(org_id=self.organization.id)
+ assert result == {"features": []}
+
+ @patch("sentry.seer.endpoints.seer_rpc.features.all", return_value=_ORG_FEATURES_TEST_SET)
+ def test_returns_sorted_list(self, _mock_all: object) -> None:
+ with self.feature(
+ {
+ "organizations:seer-agent-source-code-search": True,
+ "organizations:seer-explorer-chat-coding": True,
+ }
+ ):
+ result = get_organization_features(org_id=self.organization.id)
+ # "seer-agent-..." < "seer-explorer-..." alphabetically
+ assert result == {
+ "features": ["seer-agent-source-code-search", "seer-explorer-chat-coding"]
+ }
+
+ def test_org_not_found_returns_empty(self) -> None:
+ result = get_organization_features(org_id=0)
+ assert result == {"features": []}
+
+ @patch("sentry.seer.endpoints.seer_rpc.features.all", return_value=_ORG_FEATURES_TEST_SET)
+ def test_uses_user_as_actor_when_provided(self, _mock_all: object) -> None:
+ with self.feature("organizations:seer-agent-source-code-search"):
+ result = get_organization_features(org_id=self.organization.id, user_id=self.user.id)
+ assert result == {"features": ["seer-agent-source-code-search"]}
+
+ @patch("sentry.seer.endpoints.seer_rpc.features.all", return_value=_ORG_FEATURES_TEST_SET)
+ def test_unknown_user_id_falls_back_to_no_actor(self, _mock_all: object) -> None:
+ with self.feature("organizations:seer-agent-source-code-search"):
+ result = get_organization_features(org_id=self.organization.id, user_id=0)
+ assert result == {"features": ["seer-agent-source-code-search"]}
+
+
class TestTriggerCodingAgentLaunch:
@patch("sentry.seer.endpoints.seer_rpc.launch_coding_agents_for_run")
def test_not_found_returns_integration_not_found_error_code(self, mock_launch):