From 279f1731ef47643ca1c5ed6ed24c0376510e54a4 Mon Sep 17 00:00:00 2001 From: Cursor Agent Date: Sun, 31 May 2026 12:04:29 +0000 Subject: [PATCH] typing: strong-type release_health metrics_sessions_v2 Co-authored-by: Armen Zambrano G. --- pyproject.toml | 2 -- src/sentry/release_health/metrics_sessions_v2.py | 7 +++++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/pyproject.toml b/pyproject.toml index e3731299519f..c452610a6a03 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -394,7 +394,6 @@ ignore_missing_imports = true [[tool.mypy.overrides]] module = [ "sentry.api.endpoints.organization_releases", - "sentry.release_health.metrics_sessions_v2", "sentry.search.events.builder.errors", "sentry.search.events.builder.metrics", "sentry.search.events.datasets.filter_aliases", @@ -1279,7 +1278,6 @@ module = [ "sentry.release_health.base", "sentry.release_health.eap_sessions_rollout", "sentry.release_health.metrics", - "sentry.release_health.metrics_sessions_v2", "sentry.release_health.tasks", "sentry.releases", "sentry.releases.endpoints.*", diff --git a/src/sentry/release_health/metrics_sessions_v2.py b/src/sentry/release_health/metrics_sessions_v2.py index 790f24bd409d..ff2813b33176 100644 --- a/src/sentry/release_health/metrics_sessions_v2.py +++ b/src/sentry/release_health/metrics_sessions_v2.py @@ -45,7 +45,10 @@ MetricGroupByField, MetricOrderByField, ) -from sentry.snuba.metrics.utils import OrderByNotSupportedOverCompositeEntityException +from sentry.snuba.metrics.utils import ( + MetricOperationType, + OrderByNotSupportedOverCompositeEntityException, +) from sentry.snuba.sessions_v2 import ( QueryDefinition, finite_or_none, @@ -303,7 +306,7 @@ def __init__( class DurationField(Field): def __init__(self, name: str, raw_groupby: Sequence[str], status_filter: StatusFilter): - self.op = name[:3] # That this works is just a lucky coincidence + self.op = cast(MetricOperationType, name[:3]) # That this works is just a lucky coincidence super().__init__(name, raw_groupby, status_filter) def _get_session_status(self, metric_field: MetricField) -> SessionStatus | None: