feat(dashboard): Allow widgets to zoom #11709
Conversation
* Optimizes the number of queries and re-renders dashboard widgets make * Refactors intervals to be a bit more generic and allows dashboard widgets to zoom. * Adds tests
billyvg
force-pushed
the
feat/dashboard/allow-widget-zoom
branch
from
70dad63 to
56e6cf3
Compare
| }), | ||
| }; | ||
|
|
||
| export const DiscoverResult = PropTypes.arrayOf(PropTypes.shape(DiscoverResultShape)); |
There was a problem hiding this comment.
Should be named DiscoverResults (instead of DiscoverResult) and DiscoverResult (instead of DiscoverResultShape)
| return diffInMinutes <= TWENTY_FOUR_HOURS; | ||
| } | ||
|
|
||
| export function getInterval(datetimeObj, highFidelity) { |
There was a problem hiding this comment.
Maybe highFidelity=false here?
There was a problem hiding this comment.
Is it worth having unit tests for this function?
There was a problem hiding this comment.
isn't highFidelity=false implied?
There was a problem hiding this comment.
It's not required but it can be nice to have it always a boolean and in the method signature so reading the rest of the function won't be required to figure that out
|
|
||
| export function getInterval(datetimeObj) { | ||
| return useShortInterval(datetimeObj) ? '5m' : '30m'; | ||
| function getDiffInMinutes(datetimeObj) { |
| ), | ||
| timing: PropTypes.shape({ | ||
| duration_ms: PropTypes.number, | ||
| marks_ms: PropTypes.shape({ |
There was a problem hiding this comment.
Should we just do PropTypes.object here for now - I didn't realise this was being returned until now and it might be better to just exclude it from the api response
to zoom.
Depends on #11669