feat(dashboard): Add error boundary for widgets #11721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billyvg
force-pushed
the
feat/dashboard/add-error-boundary-for-widgets
branch
from
61873a9 to
8ff6d9e
Compare
Member
|
Last commit LGTM |
lynnagara
reviewed
Jan 29, 2019
| static propTypes = { | ||
| mini: PropTypes.bool, | ||
| message: PropTypes.node, | ||
| renderer: PropTypes.node, |
Member
There was a problem hiding this comment.
Should it be a function rather than a node? Or name the prop component?
lynnagara
approved these changes
Jan 30, 2019
billyvg
force-pushed
the
feat/dashboard/add-error-boundary-for-widgets
branch
from
5e02d3b to
659db09
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If widgets fail to render, display an error card. This allows user to see widgets that did not error and not completely crash dashboard.
Depends on #11709 and #11669