Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quotes around fix missing symbols URL #13921

Merged
merged 1 commit into from Jul 12, 2019
Merged

Conversation

@JosephDuffy
Copy link
Contributor

JosephDuffy commented Jul 8, 2019

When copy/pasting this command in fish (untested in other shells) the shell will try to expand the URL due to the ? in the URL (No matches for wildcard 'https://sentry.io/api/0/projects/[...]/processingissues/fix?_=[...]'. See `help expand`.)

This was raised in support request 22916. Colleen was kind enough to point me to this line of code.

I am not totally familiar with JSX syntax so I hope that simply adding quotes works and does not need any escaping.

When copy/pasting this command in [fish](https://fishshell.com/) (untested in other shells) the shell will try to expand the URL due to the `?` in the URL ("No matches for wildcard 'https://sentry.io/api/0/projects/[...]/processingissues/fix?_=[...]'. See `help expand`.")
@markstory markstory self-assigned this Jul 9, 2019
@markstory markstory merged commit 36fc679 into getsentry:master Jul 12, 2019
7 checks passed
7 checks passed
codecov/patch/javascript Coverage not affected when comparing b927934...8397205
Details
codecov/patch/python Coverage not affected when comparing b927934...8397205
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/snyk - package.json (sentry) No manifest changes detected
netlify/sentry-frontend/deploy-preview Deploy preview ready!
Details
percy/sentry Visual review automatically approved, no visual changes found.
Details
security/snyk - package.json (sentry) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.