feat(ui): Incident rules chart period should depend on time window [SEN-937] #14444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markstory
reviewed
Aug 20, 2019
src/sentry/static/sentry/app/views/settings/projectIncidentRules/ruleForm.tsx
Outdated
Show resolved
Hide resolved
src/sentry/static/sentry/app/views/settings/projectIncidentRules/ruleForm.tsx
Show resolved
Hide resolved
billyvg
force-pushed
the
feat/ui/incident-rules/events-request-period-dependent-on-time-window
branch
from
4ff94f5
to
d3b045f
Compare
billyvg
deleted the
feat/ui/incident-rules/events-request-period-dependent-on-time-window
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The time window -> period mapping may need just adjustments.
Fixes SEN-937