fix(SnubaEvent): Fix bug in get_minimal_user #16231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code didn't previously work (user should be an interface of an event), it just happens to not currently be called in any situation where snuba data isn't populated.
Member
Author
fpacifici
reviewed
Jan 1, 2020
Comment on lines
-440
to
-444
| else: | ||
| user_id = self.data["user_id"] | ||
| email = self.data["email"] | ||
| username = self.data["username"] | ||
| ip_address = self.data["ip_address"] |
Contributor
There was a problem hiding this comment.
I am not sure I get why this did actually not work.
Member
Author
There was a problem hiding this comment.
These properties are actually nested under self.data["user"] if they are present, this just gave a KeyError. The EventCommon implementation get_interface("user") takes care of loading them properly.
fpacifici
approved these changes
Jan 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code didn't previously work (user should be an interface of an
event), it just happens to not currently be called in any situation
where snuba data isn't populated.