ref: Make search_message a property of Event #16473
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since search_message is distinct from message, we should have them as separate properties of Event, rather than use them interchangably. Search_message is the internal only property for search, while message is the publicly exposed property. We temporarily save search_message into the message field in event_manager.save() to maintain backward compatibility with Django event format.
lynnagara
force-pushed
the
event-message-improvements
branch
from
20e99e7 to
dd25797
Compare
Member
Author
|
These changes were included in #16230 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since search_message is distinct from message, we should have them as
separate properties of Event, rather than use them interchangably.
Search_message is the internal only property for search, while message is
the publicly exposed property.
We temporarily save search_message into the message field in
event_manager.save() to maintain backward compatibility with Django
event format.